Unverified Commit 19c19164 authored by Jiwon Choi's avatar Jiwon Choi Committed by GitHub

fix(next-typescript-plugin): allow call expression for server actions (#63748)

cc @shuding

### Why?

The typescript plugin in #63667 does not target the call expression or
assigned actions.

```ts
'use server'

function action() {
  return async function() {
    return 'foo'
  }
}

async function action2() {
  return 'foo'
}

export const callAction = action() // call expression
export const assignedAction = action2 // assigned
```

### Current

![Screenshot 2024-03-27 at 2 29
04 PM](https://github.com/vercel/next.js/assets/120007119/7b35edba-c423-402b-94e7-9725c4d3cccc)

### Fixed

![Screenshot 2024-03-27 at 2 29
41 PM](https://github.com/vercel/next.js/assets/120007119/e9b7c164-4053-4c56-a4fb-eb4722094355)

x-ref: https://github.com/vercel/next.js/pull/63667
Closes #63743
parent 72ef9d94
...@@ -97,7 +97,9 @@ const serverBoundary = { ...@@ -97,7 +97,9 @@ const serverBoundary = {
initializer && initializer &&
(ts.isArrowFunction(initializer) || (ts.isArrowFunction(initializer) ||
ts.isFunctionDeclaration(initializer) || ts.isFunctionDeclaration(initializer) ||
ts.isFunctionExpression(initializer)) ts.isFunctionExpression(initializer) ||
ts.isCallExpression(initializer) ||
ts.isIdentifier(initializer))
) { ) {
diagnostics.push( diagnostics.push(
...serverBoundary.getSemanticDiagnosticsForFunctionExport( ...serverBoundary.getSemanticDiagnosticsForFunctionExport(
...@@ -127,6 +129,8 @@ const serverBoundary = { ...@@ -127,6 +129,8 @@ const serverBoundary = {
| tsModule.FunctionDeclaration | tsModule.FunctionDeclaration
| tsModule.ArrowFunction | tsModule.ArrowFunction
| tsModule.FunctionExpression | tsModule.FunctionExpression
| tsModule.CallExpression
| tsModule.Identifier
) { ) {
const ts = getTs() const ts = getTs()
const typeChecker = getTypeChecker() const typeChecker = getTypeChecker()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment