Unverified Commit 1c5c0ba3 authored by JJ Kasper's avatar JJ Kasper Committed by GitHub

Temporarily skip flakey action revalidate (#53134)

These have been flaking for quite a while so skips them more
consistently until they are investigated.

x-ref:
https://github.com/vercel/next.js/actions/runs/5650048471/job/15305721826#step:27:590
parent a0856eb5
...@@ -422,10 +422,8 @@ createNextDescribe( ...@@ -422,10 +422,8 @@ createNextDescribe(
}, 'https://example.com/') }, 'https://example.com/')
}) })
// TODO: investigate flakey behavior on deploy // TODO: investigate flakey behavior with revalidate
const skipDeploy = (global as any).isNextDeploy ? it.skip : it it.skip('should handle revalidatePath', async () => {
skipDeploy('should handle revalidatePath', async () => {
const browser = await next.browser('/revalidate') const browser = await next.browser('/revalidate')
const randomNumber = await browser.elementByCss('#random-number').text() const randomNumber = await browser.elementByCss('#random-number').text()
const justPutIt = await browser.elementByCss('#justputit').text() const justPutIt = await browser.elementByCss('#justputit').text()
...@@ -450,7 +448,8 @@ createNextDescribe( ...@@ -450,7 +448,8 @@ createNextDescribe(
}, 'success') }, 'success')
}) })
skipDeploy('should handle revalidateTag', async () => { // TODO: investigate flakey behavior with revalidate
it.skip('should handle revalidateTag', async () => {
const browser = await next.browser('/revalidate') const browser = await next.browser('/revalidate')
const randomNumber = await browser.elementByCss('#random-number').text() const randomNumber = await browser.elementByCss('#random-number').text()
const justPutIt = await browser.elementByCss('#justputit').text() const justPutIt = await browser.elementByCss('#justputit').text()
...@@ -475,7 +474,7 @@ createNextDescribe( ...@@ -475,7 +474,7 @@ createNextDescribe(
}, 'success') }, 'success')
}) })
// TODO: investigate flakey behavior // TODO: investigate flakey behavior with revalidate
it.skip('should handle revalidateTag + redirect', async () => { it.skip('should handle revalidateTag + redirect', async () => {
const browser = await next.browser('/revalidate') const browser = await next.browser('/revalidate')
const randomNumber = await browser.elementByCss('#random-number').text() const randomNumber = await browser.elementByCss('#random-number').text()
...@@ -501,42 +500,38 @@ createNextDescribe( ...@@ -501,42 +500,38 @@ createNextDescribe(
}, 'success') }, 'success')
}) })
skipDeploy( it.skip('should store revalidation data in the prefetch cache', async () => {
'should store revalidation data in the prefetch cache', const browser = await next.browser('/revalidate')
async () => { const justPutIt = await browser.elementByCss('#justputit').text()
const browser = await next.browser('/revalidate') await browser.elementByCss('#revalidate-justputit').click()
const justPutIt = await browser.elementByCss('#justputit').text()
await browser.elementByCss('#revalidate-justputit').click()
// TODO: investigate flakiness when deployed
if (!isNextDeploy) {
await check(async () => {
const newJustPutIt = await browser
.elementByCss('#justputit')
.text()
expect(newJustPutIt).not.toBe(justPutIt)
return 'success'
}, 'success')
}
const newJustPutIt = await browser.elementByCss('#justputit').text() // TODO: investigate flakiness when deployed
if (!isNextDeploy) {
await check(async () => {
const newJustPutIt = await browser.elementByCss('#justputit').text()
expect(newJustPutIt).not.toBe(justPutIt)
return 'success'
}, 'success')
}
await browser const newJustPutIt = await browser.elementByCss('#justputit').text()
.elementByCss('#navigate-client')
.click()
.waitForElementByCss('#inc')
await browser
.elementByCss('#navigate-revalidate')
.click()
.waitForElementByCss('#revalidate-justputit')
const newJustPutIt2 = await browser.elementByCss('#justputit').text() await browser
.elementByCss('#navigate-client')
.click()
.waitForElementByCss('#inc')
await browser
.elementByCss('#navigate-revalidate')
.click()
.waitForElementByCss('#revalidate-justputit')
expect(newJustPutIt).toEqual(newJustPutIt2) const newJustPutIt2 = await browser.elementByCss('#justputit').text()
}
)
skipDeploy('should revalidate when cookies.set is called', async () => { expect(newJustPutIt).toEqual(newJustPutIt2)
})
// TODO: investigate flakey behavior with revalidate
it.skip('should revalidate when cookies.set is called', async () => {
const browser = await next.browser('/revalidate') const browser = await next.browser('/revalidate')
const randomNumber = await browser.elementByCss('#random-cookie').text() const randomNumber = await browser.elementByCss('#random-cookie').text()
...@@ -551,67 +546,65 @@ createNextDescribe( ...@@ -551,67 +546,65 @@ createNextDescribe(
}, 'success') }, 'success')
}) })
skipDeploy( // TODO: investigate flakey behavior with revalidate
'should revalidate when cookies.set is called in a client action', it.skip('should revalidate when cookies.set is called in a client action', async () => {
async () => { const browser = await next.browser('/revalidate')
const browser = await next.browser('/revalidate') await browser.refresh()
await browser.refresh()
let randomCookie let randomCookie
await check(async () => { await check(async () => {
randomCookie = JSON.parse( randomCookie = JSON.parse(
await browser.elementByCss('#random-cookie').text() await browser.elementByCss('#random-cookie').text()
).value ).value
return randomCookie ? 'success' : 'failure' return randomCookie ? 'success' : 'failure'
}, 'success') }, 'success')
console.log(123, await browser.elementByCss('body').text()) console.log(123, await browser.elementByCss('body').text())
await browser.elementByCss('#another').click() await browser.elementByCss('#another').click()
await check(async () => { await check(async () => {
return browser.elementByCss('#title').text() return browser.elementByCss('#title').text()
}, 'another route') }, 'another route')
const newRandomCookie = JSON.parse( const newRandomCookie = JSON.parse(
await browser.elementByCss('#random-cookie').text() await browser.elementByCss('#random-cookie').text()
).value ).value
console.log(456, await browser.elementByCss('body').text()) console.log(456, await browser.elementByCss('body').text())
// Should be the same value // Should be the same value
expect(randomCookie).toEqual(newRandomCookie) expect(randomCookie).toEqual(newRandomCookie)
await browser.elementByCss('#back').click() await browser.elementByCss('#back').click()
// Modify the cookie // Modify the cookie
await browser.elementByCss('#set-cookie').click() await browser.elementByCss('#set-cookie').click()
// Should be different // Should be different
let revalidatedRandomCookie let revalidatedRandomCookie
await check(async () => { await check(async () => {
revalidatedRandomCookie = JSON.parse( revalidatedRandomCookie = JSON.parse(
await browser.elementByCss('#random-cookie').text() await browser.elementByCss('#random-cookie').text()
).value ).value
return randomCookie !== revalidatedRandomCookie return randomCookie !== revalidatedRandomCookie
? 'success' ? 'success'
: 'failure' : 'failure'
}, 'success') }, 'success')
await browser.elementByCss('#another').click() await browser.elementByCss('#another').click()
// The other page should be revalidated too // The other page should be revalidated too
await check(async () => { await check(async () => {
const newRandomCookie = await JSON.parse( const newRandomCookie = await JSON.parse(
await browser.elementByCss('#random-cookie').text() await browser.elementByCss('#random-cookie').text()
).value ).value
return revalidatedRandomCookie === newRandomCookie return revalidatedRandomCookie === newRandomCookie
? 'success' ? 'success'
: 'failure' : 'failure'
}, 'success') }, 'success')
} })
)
skipDeploy.each(['tag', 'path'])( it.skip.each(['tag', 'path'])(
'should invalidate client cache when %s is revalidated', 'should invalidate client cache when %s is revalidated',
async (type) => { async (type) => {
const browser = await next.browser('/revalidate') const browser = await next.browser('/revalidate')
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment