Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
1cc74578
Unverified
Commit
1cc74578
authored
Mar 01, 2026
by
Sebastian "Sebbie" Silbermann
Committed by
GitHub
Mar 01, 2026
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[devtools] Stop blocking overlay on error details copy (#90698)
parent
fb694e9d
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
81 additions
and
141 deletions
+81
-141
index.tsx
...ext-devtools/dev-overlay/components/copy-button/index.tsx
+28
-94
error-overlay-layout.tsx
...ents/errors/error-overlay-layout/error-overlay-layout.tsx
+1
-1
copy-error-button.tsx
...onents/errors/error-overlay-toolbar/copy-error-button.tsx
+1
-1
error-overlay-toolbar.tsx
...ts/errors/error-overlay-toolbar/error-overlay-toolbar.tsx
+1
-1
build-error.tsx
...t/src/next-devtools/dev-overlay/container/build-error.tsx
+1
-1
errors.tsx
...s/next/src/next-devtools/dev-overlay/container/errors.tsx
+49
-43
No files found.
packages/next/src/next-devtools/dev-overlay/components/copy-button/index.tsx
View file @
1cc74578
import
*
as
React
from
'react'
import
*
as
React
from
'react'
import
{
cx
}
from
'../../utils/cx'
import
{
cx
}
from
'../../utils/cx'
function
useCopyLegacy
(
content
:
string
)
{
function
useCopy
(
getContent
:
()
=>
Promise
<
string
>
)
{
type
CopyState
=
|
{
state
:
'initial'
}
|
{
state
:
'error'
error
:
unknown
}
|
{
state
:
'success'
}
|
{
state
:
'pending'
}
// This would be simpler with useActionState but we need to support React 18 here.
// React 18 also doesn't have async transitions.
const
[
copyState
,
dispatch
]
=
React
.
useReducer
(
(
state
:
CopyState
,
action
:
|
{
type
:
'reset'
|
'copied'
|
'copying'
}
|
{
type
:
'error'
;
error
:
unknown
}
):
CopyState
=>
{
if
(
action
.
type
===
'reset'
)
{
return
{
state
:
'initial'
}
}
if
(
action
.
type
===
'copied'
)
{
return
{
state
:
'success'
}
}
if
(
action
.
type
===
'copying'
)
{
return
{
state
:
'pending'
}
}
if
(
action
.
type
===
'error'
)
{
return
{
state
:
'error'
,
error
:
action
.
error
}
}
return
state
},
{
state
:
'initial'
,
}
)
function
copy
()
{
if
(
isPending
)
{
return
}
if
(
!
navigator
.
clipboard
)
{
dispatch
({
type
:
'error'
,
error
:
'Copy to clipboard is not supported in this browser'
,
})
}
else
{
dispatch
({
type
:
'copying'
})
navigator
.
clipboard
.
writeText
(
content
).
then
(
()
=>
{
dispatch
({
type
:
'copied'
})
},
(
error
)
=>
{
dispatch
({
type
:
'error'
,
error
})
}
)
}
}
const
reset
=
React
.
useCallback
(()
=>
{
dispatch
({
type
:
'reset'
})
},
[])
const
isPending
=
copyState
.
state
===
'pending'
return
[
copyState
,
copy
,
reset
,
isPending
]
as
const
}
function
useCopyModern
(
content
:
string
)
{
type
CopyState
=
type
CopyState
=
|
{
|
{
state
:
'initial'
state
:
'initial'
...
@@ -97,14 +27,16 @@ function useCopyModern(content: string) {
...
@@ -97,14 +27,16 @@ function useCopyModern(content: string) {
error
:
'Copy to clipboard is not supported in this browser'
,
error
:
'Copy to clipboard is not supported in this browser'
,
}
}
}
}
return
navigator
.
clipboard
.
writeText
(
content
).
then
(
return
getContent
().
then
((
content
)
=>
{
()
=>
{
return
navigator
.
clipboard
.
writeText
(
content
).
then
(
return
{
state
:
'success'
}
()
=>
{
},
return
{
state
:
'success'
}
(
error
)
=>
{
},
return
{
state
:
'error'
,
error
}
(
error
)
=>
{
}
return
{
state
:
'error'
,
error
}
)
}
)
})
}
}
return
state
return
state
},
},
...
@@ -130,9 +62,6 @@ function useCopyModern(content: string) {
...
@@ -130,9 +62,6 @@ function useCopyModern(content: string) {
return
[
copyState
,
copy
,
reset
,
isPending
]
as
const
return
[
copyState
,
copy
,
reset
,
isPending
]
as
const
}
}
const
useCopy
=
typeof
React
.
useActionState
===
'function'
?
useCopyModern
:
useCopyLegacy
type
CopyButtonProps
=
React
.
HTMLProps
<
HTMLButtonElement
>
&
{
type
CopyButtonProps
=
React
.
HTMLProps
<
HTMLButtonElement
>
&
{
actionLabel
:
string
actionLabel
:
string
successLabel
:
string
successLabel
:
string
...
@@ -140,7 +69,10 @@ type CopyButtonProps = React.HTMLProps<HTMLButtonElement> & {
...
@@ -140,7 +69,10 @@ type CopyButtonProps = React.HTMLProps<HTMLButtonElement> & {
}
}
export
function
CopyButton
(
export
function
CopyButton
(
props
:
CopyButtonProps
&
{
content
?:
string
;
getContent
?:
()
=>
string
}
props
:
CopyButtonProps
&
{
content
?:
string
getContent
?:
()
=>
Promise
<
string
>
}
)
{
)
{
const
{
const
{
content
,
content
,
...
@@ -151,17 +83,16 @@ export function CopyButton(
...
@@ -151,17 +83,16 @@ export function CopyButton(
disabled
,
disabled
,
...
rest
...
rest
}
=
props
}
=
props
const
getContentString
=
():
string
=>
{
const
getContentString
=
():
Promise
<
string
>
=>
{
if
(
content
)
{
if
(
content
)
{
return
content
return
Promise
.
resolve
(
content
)
}
}
if
(
getContent
)
{
if
(
getContent
)
{
return
getContent
()
return
getContent
()
}
}
return
''
return
Promise
.
resolve
(
''
)
}
}
const
contentString
=
getContentString
()
const
[
copyState
,
copy
,
reset
,
isPending
]
=
useCopy
(
getContentString
)
const
[
copyState
,
copy
,
reset
,
isPending
]
=
useCopy
(
contentString
)
const
error
=
copyState
.
state
===
'error'
?
copyState
.
error
:
null
const
error
=
copyState
.
state
===
'error'
?
copyState
.
error
:
null
React
.
useEffect
(()
=>
{
React
.
useEffect
(()
=>
{
...
@@ -206,8 +137,8 @@ export function CopyButton(
...
@@ -206,8 +137,8 @@ export function CopyButton(
title=
{
label
}
title=
{
label
}
aria
-
label=
{
label
}
aria
-
label=
{
label
}
aria
-
disabled=
{
isDisabled
}
aria
-
disabled=
{
isDisabled
}
disabled=
{
isDisabled
}
data
-
nextjs
-
copy
-
button
data
-
nextjs
-
copy
-
button
data
-
pending=
{
isPending
}
className=
{
cx
(
className=
{
cx
(
props
.
className
,
props
.
className
,
'nextjs-data-copy-button'
,
'nextjs-data-copy-button'
,
...
@@ -269,18 +200,21 @@ export const COPY_BUTTON_STYLES = `
...
@@ -269,18 +200,21 @@ export const COPY_BUTTON_STYLES = `
height: var(--size-16);
height: var(--size-16);
}
}
}
}
.nextjs-data-copy-button
:disabled
{
.nextjs-data-copy-button
[aria-disabled="true"]
{
background-color: var(--color-gray-100);
background-color: var(--color-gray-100);
cursor: not-allowed;
cursor: not-allowed;
}
}
.nextjs-data-copy-button--initial:hover:not(:disabled) {
.nextjs-data-copy-button[data-pending="true"] {
cursor: wait;
}
.nextjs-data-copy-button--initial:hover:not([aria-disabled="true"]) {
cursor: pointer;
cursor: pointer;
}
}
.nextjs-data-copy-button--error:not(
:disabled
),
.nextjs-data-copy-button--error:not(
[aria-disabled="true"]
),
.nextjs-data-copy-button--error:hover:not(
:disabled
) {
.nextjs-data-copy-button--error:hover:not(
[aria-disabled="true"]
) {
color: var(--color-ansi-red);
color: var(--color-ansi-red);
}
}
.nextjs-data-copy-button--success:not(
:disabled
) {
.nextjs-data-copy-button--success:not(
[aria-disabled="true"]
) {
color: var(--color-ansi-green);
color: var(--color-ansi-green);
}
}
`
`
packages/next/src/next-devtools/dev-overlay/components/errors/error-overlay-layout/error-overlay-layout.tsx
View file @
1cc74578
...
@@ -52,7 +52,7 @@ export interface ErrorOverlayLayoutProps extends ErrorBaseProps {
...
@@ -52,7 +52,7 @@ export interface ErrorOverlayLayoutProps extends ErrorBaseProps {
activeIdx
?:
number
activeIdx
?:
number
setActiveIndex
?:
(
index
:
number
)
=>
void
setActiveIndex
?:
(
index
:
number
)
=>
void
dialogResizerRef
?:
React
.
RefObject
<
HTMLDivElement
|
null
>
dialogResizerRef
?:
React
.
RefObject
<
HTMLDivElement
|
null
>
generateErrorInfo
:
()
=>
string
generateErrorInfo
:
()
=>
Promise
<
string
>
}
}
export
function
ErrorOverlayLayout
({
export
function
ErrorOverlayLayout
({
...
...
packages/next/src/next-devtools/dev-overlay/components/errors/error-overlay-toolbar/copy-error-button.tsx
View file @
1cc74578
...
@@ -5,7 +5,7 @@ export function CopyErrorButton({
...
@@ -5,7 +5,7 @@ export function CopyErrorButton({
generateErrorInfo
,
generateErrorInfo
,
}:
{
}:
{
error
:
Error
error
:
Error
generateErrorInfo
:
()
=>
string
generateErrorInfo
:
()
=>
Promise
<
string
>
})
{
})
{
return
(
return
(
<
CopyButton
<
CopyButton
...
...
packages/next/src/next-devtools/dev-overlay/components/errors/error-overlay-toolbar/error-overlay-toolbar.tsx
View file @
1cc74578
...
@@ -7,7 +7,7 @@ type ErrorOverlayToolbarProps = {
...
@@ -7,7 +7,7 @@ type ErrorOverlayToolbarProps = {
error
:
Error
error
:
Error
debugInfo
:
DebugInfo
|
undefined
debugInfo
:
DebugInfo
|
undefined
feedbackButton
?:
React
.
ReactNode
feedbackButton
?:
React
.
ReactNode
generateErrorInfo
:
()
=>
string
generateErrorInfo
:
()
=>
Promise
<
string
>
}
}
export
function
ErrorOverlayToolbar
({
export
function
ErrorOverlayToolbar
({
...
...
packages/next/src/next-devtools/dev-overlay/container/build-error.tsx
View file @
1cc74578
...
@@ -37,7 +37,7 @@ export const BuildError: React.FC<BuildErrorProps> = function BuildError({
...
@@ -37,7 +37,7 @@ export const BuildError: React.FC<BuildErrorProps> = function BuildError({
[
message
]
[
message
]
)
)
const
generateErrorInfo
=
useCallback
(()
=>
{
const
generateErrorInfo
=
useCallback
(
async
()
=>
{
const
parts
:
string
[]
=
[]
const
parts
:
string
[]
=
[]
// 1. Error Type
// 1. Error Type
...
...
packages/next/src/next-devtools/dev-overlay/container/errors.tsx
View file @
1cc74578
...
@@ -15,7 +15,6 @@ import {
...
@@ -15,7 +15,6 @@ import {
NEXTJS_HYDRATION_ERROR_LINK
,
NEXTJS_HYDRATION_ERROR_LINK
,
}
from
'../../shared/react-19-hydration-error'
}
from
'../../shared/react-19-hydration-error'
import
type
{
ReadyRuntimeError
}
from
'../utils/get-error-by-type'
import
type
{
ReadyRuntimeError
}
from
'../utils/get-error-by-type'
import
{
useFrames
}
from
'../utils/get-error-by-type'
import
type
{
ErrorBaseProps
}
from
'../components/errors/error-overlay/error-overlay'
import
type
{
ErrorBaseProps
}
from
'../components/errors/error-overlay/error-overlay'
import
type
{
HydrationErrorState
}
from
'../../shared/hydration-error'
import
type
{
HydrationErrorState
}
from
'../../shared/hydration-error'
import
{
useActiveRuntimeError
}
from
'../hooks/use-active-runtime-error'
import
{
useActiveRuntimeError
}
from
'../hooks/use-active-runtime-error'
...
@@ -605,21 +604,7 @@ export function Errors({
...
@@ -605,21 +604,7 @@ export function Errors({
setActiveIndex
,
setActiveIndex
,
}
=
useActiveRuntimeError
({
runtimeErrors
,
getSquashedHydrationErrorDetails
})
}
=
useActiveRuntimeError
({
runtimeErrors
,
getSquashedHydrationErrorDetails
})
// Get parsed frames data
const
generateErrorInfo
=
useCallback
(
async
()
=>
{
const
frames
=
useFrames
(
activeError
)
const
firstFrame
=
useMemo
(()
=>
{
const
firstFirstPartyFrameIndex
=
frames
.
findIndex
(
(
entry
)
=>
!
entry
.
ignored
&&
Boolean
(
entry
.
originalCodeFrame
)
&&
Boolean
(
entry
.
originalStackFrame
)
)
return
frames
[
firstFirstPartyFrameIndex
]
??
null
},
[
frames
])
const
generateErrorInfo
=
useCallback
(()
=>
{
if
(
!
activeError
)
return
''
if
(
!
activeError
)
return
''
const
parts
:
string
[]
=
[]
const
parts
:
string
[]
=
[]
...
@@ -641,37 +626,58 @@ export function Errors({
...
@@ -641,37 +626,58 @@ export function Errors({
if
(
message
)
{
if
(
message
)
{
parts
.
push
(
`## Error Message\n
${
message
}
`
)
parts
.
push
(
`## Error Message\n
${
message
}
`
)
}
}
// Append call stack
if
(
frames
.
length
>
0
)
{
const
visibleFrames
=
frames
.
filter
((
frame
)
=>
!
frame
.
ignored
)
if
(
visibleFrames
.
length
>
0
)
{
const
stackLines
=
visibleFrames
.
map
((
frame
)
=>
{
if
(
frame
.
originalStackFrame
)
{
const
{
methodName
,
file
,
line1
,
column1
}
=
frame
.
originalStackFrame
return
` at
${
methodName
}
(
${
file
}
:
${
line1
}
:
${
column1
}
)`
}
else
if
(
frame
.
sourceStackFrame
)
{
const
{
methodName
,
file
,
line1
,
column1
}
=
frame
.
sourceStackFrame
return
` at
${
methodName
}
(
${
file
}
:
${
line1
}
:
${
column1
}
)`
}
return
''
})
.
filter
(
Boolean
)
if
(
stackLines
.
length
>
0
)
{
const
frames
=
await
Promise
.
race
([
parts
.
push
(
`\n
${
stackLines
.
join
(
'
\
n'
)}
`
)
activeError
.
frames
(),
new
Promise
<
null
>
((
resolve
)
=>
setTimeout
(()
=>
resolve
(
null
),
2000
)),
])
// Append call stack
if
(
frames
===
null
)
{
parts
.
push
(
'Unable to retrieve stack frames for this error. Falling back to unsourcemapped stack
\
n
\
n'
+
error
.
stack
)
}
else
{
if
(
frames
.
length
>
0
)
{
const
visibleFrames
=
frames
.
filter
((
frame
)
=>
!
frame
.
ignored
)
if
(
visibleFrames
.
length
>
0
)
{
const
stackLines
=
visibleFrames
.
map
((
frame
)
=>
{
if
(
frame
.
originalStackFrame
)
{
const
{
methodName
,
file
,
line1
,
column1
}
=
frame
.
originalStackFrame
return
` at
${
methodName
}
(
${
file
}
:
${
line1
}
:
${
column1
}
)`
}
else
if
(
frame
.
sourceStackFrame
)
{
const
{
methodName
,
file
,
line1
,
column1
}
=
frame
.
sourceStackFrame
return
` at
${
methodName
}
(
${
file
}
:
${
line1
}
:
${
column1
}
)`
}
return
''
})
.
filter
(
Boolean
)
if
(
stackLines
.
length
>
0
)
{
parts
.
push
(
`\n
${
stackLines
.
join
(
'
\
n'
)}
`
)
}
}
}
}
}
}
// 3. Code Frame (decoded)
// 3. Code Frame (decoded)
if
(
firstFrame
?.
originalCodeFrame
)
{
const
firstFirstPartyFrameIndex
=
frames
.
findIndex
(
const
decodedCodeFrame
=
stripAnsi
(
(
entry
)
=>
formatCodeFrame
(
firstFrame
.
originalCodeFrame
)
!
entry
.
ignored
&&
Boolean
(
entry
.
originalCodeFrame
)
&&
Boolean
(
entry
.
originalStackFrame
)
)
)
parts
.
push
(
`## Code Frame\n
${
decodedCodeFrame
}
`
)
const
firstFrame
=
frames
[
firstFirstPartyFrameIndex
]
??
null
if
(
firstFrame
?.
originalCodeFrame
)
{
const
decodedCodeFrame
=
stripAnsi
(
formatCodeFrame
(
firstFrame
.
originalCodeFrame
)
)
parts
.
push
(
`## Code Frame\n
${
decodedCodeFrame
}
`
)
}
}
}
// Format as markdown error info
// Format as markdown error info
...
@@ -680,7 +686,7 @@ export function Errors({
...
@@ -680,7 +686,7 @@ export function Errors({
Next.js version:
${
props
.
versionInfo
.
installed
}
(
${
process
.
env
.
__NEXT_BUNDLER
}
)\n`
Next.js version:
${
props
.
versionInfo
.
installed
}
(
${
process
.
env
.
__NEXT_BUNDLER
}
)\n`
return
errorInfo
return
errorInfo
},
[
activeError
,
errorType
,
firstFrame
,
frames
,
props
.
versionInfo
])
},
[
activeError
,
errorType
,
props
.
versionInfo
])
if
(
isLoading
)
{
if
(
isLoading
)
{
// TODO: better loading state
// TODO: better loading state
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment