Unverified Commit 22812d49 authored by Donny/강동윤's avatar Donny/강동윤 Committed by GitHub

fix(turbopack): Use correct `SyntaxContext` for `__turbopack_esm__` (#73544)

### What?

### Why?

For description about the `resolver`/`hygiene` system, please see https://rustdoc.swc.rs/swc_core/ecma/transforms/base/fn.resolver.html

### How?

 - Closes https://github.com/vercel/next.js/issues/72232
 - Closes PACK-3372


 - Closes https://github.com/vercel/next.js/issues/73383
 - Closes PACK-3586

---------
Co-authored-by: 's avatarBenjamin Woodruff <benjamin.woodruff@vercel.com>
Co-authored-by: 's avatarTobias Koppers <tobias.koppers@googlemail.com>
parent a84d7476
......@@ -7,6 +7,7 @@ use swc_core::{
ecma::{
ast::*,
atoms::{atom, Atom},
utils::find_pat_ids,
visit::{Visit, VisitWith},
},
};
......@@ -178,6 +179,8 @@ pub(crate) struct ImportMap {
/// The module specifiers of star imports that are accessed dynamically and should be imported
/// as a whole.
full_star_imports: FxHashSet<Atom>,
pub(crate) exports: FxHashMap<RcStr, Id>,
}
/// Represents a collection of [webpack-style "magic comments"][magic] that override import
......@@ -605,7 +608,28 @@ impl Visit for Analyzer<'_> {
// only visit children if we potentially need to mark import / requires
n.visit_children_with(self);
}
match &n.decl {
Decl::Class(n) => {
self.data
.exports
.insert(n.ident.sym.as_str().into(), n.ident.to_id());
}
Decl::Fn(n) => {
self.data
.exports
.insert(n.ident.sym.as_str().into(), n.ident.to_id());
}
Decl::Var(..) | Decl::Using(..) => {
let ids: Vec<Id> = find_pat_ids(&n.decl);
for id in ids {
self.data.exports.insert(id.0.as_str().into(), id);
}
}
_ => {}
}
}
fn visit_export_default_decl(&mut self, n: &ExportDefaultDecl) {
self.data.has_exports = true;
......@@ -623,6 +647,28 @@ impl Visit for Analyzer<'_> {
}
}
fn visit_export_named_specifier(&mut self, n: &ExportNamedSpecifier) {
if let ModuleExportName::Ident(ident) = &n.exported.as_ref().unwrap_or(&n.orig) {
self.data
.exports
.insert(ident.sym.as_str().into(), ident.to_id());
}
}
fn visit_export_default_specifier(&mut self, n: &ExportDefaultSpecifier) {
self.data
.exports
.insert("default".into(), n.exported.to_id());
}
fn visit_export_namespace_specifier(&mut self, n: &ExportNamespaceSpecifier) {
if let ModuleExportName::Ident(ident) = &n.name {
self.data
.exports
.insert(ident.sym.as_str().into(), ident.to_id());
}
}
fn visit_program(&mut self, m: &Program) {
self.data.has_top_level_await = has_top_level_await(m).is_some();
......
......@@ -809,7 +809,7 @@ impl EcmascriptModuleContent {
if let EcmascriptExports::EsmExports(exports) = *exports.await? {
Some(
exports
.code_generation(module_graph, chunking_context)
.code_generation(module_graph, chunking_context, *parsed)
.await?,
)
} else {
......
......@@ -31,6 +31,7 @@ use crate::{
chunk::{EcmascriptChunkPlaceable, EcmascriptExports},
code_gen::{CodeGeneration, CodeGenerationHoistedStmt},
magic_identifier,
parse::ParseResult,
runtime_functions::{TURBOPACK_DYNAMIC, TURBOPACK_ESM},
};
......@@ -494,8 +495,14 @@ impl EsmExports {
self: Vc<Self>,
_module_graph: Vc<ModuleGraph>,
chunking_context: Vc<Box<dyn ChunkingContext>>,
parsed: Vc<ParseResult>,
) -> Result<CodeGeneration> {
let expanded = self.expand_exports().await?;
let parsed = parsed.await?;
let eval_context = match &*parsed {
ParseResult::Ok { eval_context, .. } => Some(eval_context),
_ => None,
};
let mut dynamic_exports = Vec::<Box<Expr>>::new();
for dynamic_export_asset in &expanded.dynamic_exports {
......@@ -522,20 +529,22 @@ impl EsmExports {
} else {
Cow::Borrowed(name.as_str())
};
let ctxt = eval_context
.and_then(|eval_context| {
eval_context.imports.exports.get(name).map(|id| id.1)
})
.unwrap_or_default();
if *mutable {
Some(quote!(
"([() => $local, ($new) => $local = $new])" as Expr,
local = Ident::new(local.into(), DUMMY_SP, Default::default()),
new = Ident::new(
format!("new_{name}").into(),
DUMMY_SP,
Default::default()
),
local = Ident::new(local.into(), DUMMY_SP, ctxt),
new = Ident::new(format!("new_{name}").into(), DUMMY_SP, ctxt),
))
} else {
Some(quote!(
"(() => $local)" as Expr,
local = Ident::new((name as &str).into(), DUMMY_SP, Default::default())
local = Ident::new((name as &str).into(), DUMMY_SP, ctxt)
))
}
}
......
......@@ -68,7 +68,11 @@ impl EcmascriptChunkItem for EcmascriptModuleFacadeChunkItem {
let esm_code_gens = self
.module
.code_generation(*self.module_graph, *chunking_context)
.code_generation(
*self.module_graph,
*chunking_context,
*self.module.await?.parsed,
)
.await?;
let additional_code_gens = [
self.module
......@@ -80,7 +84,11 @@ impl EcmascriptChunkItem for EcmascriptModuleFacadeChunkItem {
)
.await?,
exports
.code_generation(*self.module_graph, *chunking_context)
.code_generation(
*self.module_graph,
*chunking_context,
*self.module.await?.parsed,
)
.await?,
];
let code_gens = esm_code_gens.iter().chain(additional_code_gens.iter());
......
......@@ -17,7 +17,7 @@ use super::{
facade::module::EcmascriptModuleFacadeModule, locals::module::EcmascriptModuleLocalsModule,
};
use crate::{
chunk::EcmascriptChunkPlaceable, code_gen::CodeGeneration,
chunk::EcmascriptChunkPlaceable, code_gen::CodeGeneration, parse::ParseResult,
references::esm::base::ReferencedAsset, runtime_functions::TURBOPACK_IMPORT,
utils::module_id_to_lit,
};
......@@ -27,6 +27,7 @@ use crate::{
#[turbo_tasks::value]
pub struct EcmascriptModulePartReference {
pub module: ResolvedVc<Box<dyn EcmascriptChunkPlaceable>>,
pub parsed: ResolvedVc<ParseResult>,
pub part: Option<ModulePart>,
}
......@@ -35,18 +36,28 @@ impl EcmascriptModulePartReference {
#[turbo_tasks::function]
pub fn new_part(
module: ResolvedVc<Box<dyn EcmascriptChunkPlaceable>>,
parsed: ResolvedVc<ParseResult>,
part: ModulePart,
) -> Vc<Self> {
EcmascriptModulePartReference {
module,
parsed,
part: Some(part),
}
.cell()
}
#[turbo_tasks::function]
pub fn new(module: ResolvedVc<Box<dyn EcmascriptChunkPlaceable>>) -> Vc<Self> {
EcmascriptModulePartReference { module, part: None }.cell()
pub fn new(
module: ResolvedVc<Box<dyn EcmascriptChunkPlaceable>>,
parsed: ResolvedVc<ParseResult>,
) -> Vc<Self> {
EcmascriptModulePartReference {
module,
parsed,
part: None,
}
.cell()
}
}
......@@ -81,7 +92,7 @@ impl ModuleReference for EcmascriptModulePartReference {
| ModulePart::Facade
| ModulePart::RenamedExport { .. }
| ModulePart::RenamedNamespace { .. } => Vc::upcast(
EcmascriptModuleFacadeModule::new(*self.module, part.clone()),
EcmascriptModuleFacadeModule::new(*self.module, *self.parsed, part.clone()),
),
ModulePart::Export(..)
| ModulePart::Internal(..)
......
......@@ -162,6 +162,8 @@ impl EcmascriptModulePartAsset {
..
} = &*result.await?;
let parsed = module.parse();
let final_module = if let Some(new_export) = new_export {
if *new_export == export {
*final_module
......@@ -169,6 +171,7 @@ impl EcmascriptModulePartAsset {
ResolvedVc::upcast(
EcmascriptModuleFacadeModule::new(
**final_module,
parsed,
ModulePart::renamed_export(new_export.clone(), export.clone()),
)
.to_resolved()
......@@ -179,6 +182,7 @@ impl EcmascriptModulePartAsset {
ResolvedVc::upcast(
EcmascriptModuleFacadeModule::new(
**final_module,
parsed,
ModulePart::renamed_namespace(export.clone()),
)
.to_resolved()
......
......@@ -54,6 +54,7 @@ use turbopack_core::{
pub use turbopack_css as css;
pub use turbopack_ecmascript as ecmascript;
use turbopack_ecmascript::{
parse::ParseResult,
references::external_module::{CachedExternalModule, CachedExternalType},
tree_shake::asset::EcmascriptModulePartAsset,
};
......@@ -157,6 +158,7 @@ async fn apply_module_type(
}
}
let parsed = module.parse();
let options = options.await?;
match options.tree_shaking_mode {
Some(TreeShakingMode::ModuleFragments) => {
......@@ -172,6 +174,7 @@ async fn apply_module_type(
if *module.get_exports().needs_facade().await? {
Vc::upcast(EcmascriptModuleFacadeModule::new(
Vc::upcast(module),
parsed,
part,
))
} else {
......@@ -189,17 +192,20 @@ async fn apply_module_type(
Vc::upcast(
EcmascriptModuleFacadeModule::new(
Vc::upcast(module),
parsed,
ModulePart::exports(),
)
.resolve()
.await?,
),
parsed,
part,
side_effect_free_packages,
)
} else {
apply_reexport_tree_shaking(
Vc::upcast(module.resolve().await?),
parsed,
part,
side_effect_free_packages,
)
......@@ -214,6 +220,7 @@ async fn apply_module_type(
} else if *module.get_exports().needs_facade().await? {
Vc::upcast(EcmascriptModuleFacadeModule::new(
Vc::upcast(module),
parsed,
ModulePart::facade(),
))
} else {
......@@ -276,6 +283,7 @@ async fn apply_module_type(
#[turbo_tasks::function]
async fn apply_reexport_tree_shaking(
module: Vc<Box<dyn EcmascriptChunkPlaceable>>,
parsed: Vc<ParseResult>,
part: ModulePart,
side_effect_free_packages: Vc<Glob>,
) -> Result<Vc<Box<dyn Module>>> {
......@@ -291,12 +299,14 @@ async fn apply_reexport_tree_shaking(
} else {
Vc::upcast(EcmascriptModuleFacadeModule::new(
**final_module,
parsed,
ModulePart::renamed_export(new_export.clone(), export.clone()),
))
}
} else {
Vc::upcast(EcmascriptModuleFacadeModule::new(
**final_module,
parsed,
ModulePart::renamed_namespace(export.clone()),
))
};
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment