Unverified Commit 24033486 authored by Will Binns-Smith's avatar Will Binns-Smith Committed by GitHub

next-analyze: improve network error visuals (#86222)

This improves how network errors (such as when the bundle analyzer error server is shut down) are shown.

Fixes PACK-5877

![image.png](https://app.graphite.com/user-attachments/assets/69e57bb7-03ca-45ec-9816-f4bc512bfd58.png)

![image.png](https://app.graphite.com/user-attachments/assets/450ed52c-5368-49ee-a149-e7b17a8c21db.png)
parent e07cc5cc
...@@ -4,6 +4,7 @@ import type React from 'react' ...@@ -4,6 +4,7 @@ import type React from 'react'
import { useEffect, useMemo, useRef, useState } from 'react' import { useEffect, useMemo, useRef, useState } from 'react'
import useSWR from 'swr' import useSWR from 'swr'
import { ImportChain } from '@/components/import-chain' import { ImportChain } from '@/components/import-chain'
import { ErrorState } from '@/components/error-state'
import { import {
RouteTypeahead, RouteTypeahead,
type RouteTypeaheadRef, type RouteTypeaheadRef,
...@@ -15,7 +16,7 @@ import { Skeleton, TreemapSkeleton } from '@/components/ui/skeleton' ...@@ -15,7 +16,7 @@ import { Skeleton, TreemapSkeleton } from '@/components/ui/skeleton'
import { ToggleGroup, ToggleGroupItem } from '@/components/ui/toggle-group' import { ToggleGroup, ToggleGroupItem } from '@/components/ui/toggle-group'
import { AnalyzeData, ModulesData } from '@/lib/analyze-data' import { AnalyzeData, ModulesData } from '@/lib/analyze-data'
import { SpecialModule } from '@/lib/types' import { SpecialModule } from '@/lib/types'
import { getSpecialModuleType } from '@/lib/utils' import { getSpecialModuleType, fetchStrict } from '@/lib/utils'
function formatBytes(bytes: number): string { function formatBytes(bytes: number): string {
if (bytes === 0) return '0 B' if (bytes === 0) return '0 B'
...@@ -164,12 +165,6 @@ export default function Home() { ...@@ -164,12 +165,6 @@ export default function Home() {
</div> </div>
<div className="basis-2/3 flex justify-end"> <div className="basis-2/3 flex justify-end">
{error && (
<div className="text-sm text-red-600 font-medium">
Error: {error?.message}
</div>
)}
{analyzeData && ( {analyzeData && (
<> <>
<ToggleGroup <ToggleGroup
...@@ -227,7 +222,9 @@ export default function Home() { ...@@ -227,7 +222,9 @@ export default function Home() {
</div> </div>
<div className="flex-1 flex min-h-0"> <div className="flex-1 flex min-h-0">
{isAnyLoading ? ( {error && !analyzeData ? (
<ErrorState error={error} />
) : isAnyLoading ? (
<> <>
<div className="flex-1 min-w-0 p-4 bg-background"> <div className="flex-1 min-w-0 p-4 bg-background">
<TreemapSkeleton /> <TreemapSkeleton />
...@@ -414,12 +411,3 @@ async function fetchModulesData(url: string): Promise<ModulesData> { ...@@ -414,12 +411,3 @@ async function fetchModulesData(url: string): Promise<ModulesData> {
const resp = await fetchStrict(url) const resp = await fetchStrict(url)
return new ModulesData(await resp.arrayBuffer()) return new ModulesData(await resp.arrayBuffer())
} }
function fetchStrict(url: string): Promise<Response> {
return fetch(url).then((res) => {
if (!res.ok) {
throw new Error(`Failed to fetch ${url}: ${res.status} ${res.statusText}`)
}
return res
})
}
'use client'
import { RefreshCw, AlertTriangle } from 'lucide-react'
import { NetworkError } from '@/lib/errors'
interface ErrorStateProps {
error: unknown
onRetry?: () => void
}
export function ErrorState({ error }: ErrorStateProps) {
const isNetwork = error instanceof NetworkError
const title = isNetwork ? 'Server Connection Lost' : 'Error'
const message = isNetwork
? 'Unable to connect to the bundle analyzer server. Please ensure the server is running and try again.'
: ((error as any)?.message ?? 'An unexpected error occurred.')
return (
<div className="flex-1 flex items-center justify-center">
<div className="text-center space-y-4 max-w-md px-6">
<div className="inline-flex items-center justify-center w-16 h-16 rounded-full bg-destructive/10 text-destructive mb-2">
<AlertTriangle className="w-8 h-8" />
</div>
<div>
<h3 className="text-lg font-semibold text-foreground mb-2">
{title}
</h3>
<p className="text-sm text-muted-foreground mb-4">{message}</p>
<button
onClick={() => {
window.location.reload()
}}
className="inline-flex items-center gap-2 px-4 py-2 rounded-md bg-primary text-primary-foreground hover:bg-primary/90 transition-colors text-sm font-medium"
>
<RefreshCw className="w-4 h-4" />
Retry Connection
</button>
</div>
</div>
</div>
)
}
export { ImportChain } from './import-chain' export { ImportChain } from './import-chain'
export { RouteTypeahead } from './route-typeahead' export { RouteTypeahead } from './route-typeahead'
export { TreemapVisualizer } from './treemap-visualizer' export { TreemapVisualizer } from './treemap-visualizer'
export { ErrorState } from './error-state'
...@@ -18,6 +18,7 @@ import { ...@@ -18,6 +18,7 @@ import {
PopoverTrigger, PopoverTrigger,
} from '@/components/ui/popover' } from '@/components/ui/popover'
import { cn, jsonFetcher } from '@/lib/utils' import { cn, jsonFetcher } from '@/lib/utils'
import { NetworkError } from '@/lib/errors'
interface RouteTypeaheadProps { interface RouteTypeaheadProps {
selectedRoute: string | null selectedRoute: string | null
...@@ -55,8 +56,13 @@ export const RouteTypeahead = forwardRef< ...@@ -55,8 +56,13 @@ export const RouteTypeahead = forwardRef<
if (error) { if (error) {
return ( return (
<div className="flex max-w-full text-red-600"> <div className="flex items-center gap-2 px-3 py-2 rounded-md bg-destructive/10 border border-destructive/20 text-destructive text-sm max-w-full">
Failed to load routes manifest: {error.message} <span className="font-medium">⚠</span>
<span className="truncate">
{error instanceof NetworkError
? 'Unable to connect to server'
: error.message}
</span>
</div> </div>
) )
} }
......
export class NetworkError extends Error {
constructor(message: string, options?: { cause?: unknown }) {
super(message)
this.name = 'NetworkError'
// Preserve error cause when supported
if (options && 'cause' in options) {
;(this as any).cause = options.cause
}
}
}
import { type ClassValue, clsx } from 'clsx' import { type ClassValue, clsx } from 'clsx'
import { twMerge } from 'tailwind-merge' import { twMerge } from 'tailwind-merge'
import { SpecialModule } from './types' import { SpecialModule } from './types'
import { NetworkError } from './errors'
import { AnalyzeData } from './analyze-data' import { AnalyzeData } from './analyze-data'
export function cn(...inputs: ClassValue[]) { export function cn(...inputs: ClassValue[]) {
return twMerge(clsx(inputs)) return twMerge(clsx(inputs))
} }
export function jsonFetcher<T>(url: string): Promise<T> { export async function fetchStrict(url: string): Promise<Response> {
return fetch(url).then((res) => res.json()) let res: Response
try {
res = await fetch(url)
} catch (err) {
throw new NetworkError(`Failed to fetch ${url}`, { cause: err })
}
if (!res.ok) {
throw new Error(`Failed to fetch ${url}: ${res.status} ${res.statusText}`)
}
return res
}
export async function jsonFetcher<T>(url: string): Promise<T> {
const res = await fetchStrict(url)
return res.json() as Promise<T>
} }
export function getSpecialModuleType( export function getSpecialModuleType(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment