Unverified Commit 24c480e3 authored by rauno's avatar rauno Committed by GitHub

[dev-overlay] Increase padding if no `x` button present (#76898)

Fixes lack of padding on the right if there is no `x` close button

![CleanShot 2025-03-07 at 14 11
57@2x](https://github.com/user-attachments/assets/2543855f-bb6b-4179-9e21-3808bc99e19b)

After the changes:

![CleanShot 2025-03-07 at 14 12
33@2x](https://github.com/user-attachments/assets/c369963a-d621-4fc6-b6d6-fcf0888dca69)

---

Closes DSN-756
parent 8ea354cd
...@@ -190,11 +190,12 @@ export const NextLogo = forwardRef(function NextLogo( ...@@ -190,11 +190,12 @@ export const NextLogo = forwardRef(function NextLogo(
} }
[data-issues] { [data-issues] {
--padding-left: 8px;
display: flex; display: flex;
gap: 2px; gap: 2px;
align-items: center; align-items: center;
padding-left: 8px; padding-left: 8px;
padding-right: ${isBuildError ? '8px' : 'calc(2px * 2)'}; padding-right: 8px;
height: var(--size-32); height: var(--size-32);
margin: 0 2px; margin: 0 2px;
border-radius: var(--rounded-full); border-radius: var(--rounded-full);
...@@ -204,6 +205,10 @@ export const NextLogo = forwardRef(function NextLogo( ...@@ -204,6 +205,10 @@ export const NextLogo = forwardRef(function NextLogo(
background: var(--color-hover-alpha-error); background: var(--color-hover-alpha-error);
} }
&:has([data-issues-collapse]) {
padding-right: calc(var(--padding-left) / 2);
}
[data-cross] { [data-cross] {
translate: 0px -1px; translate: 0px -1px;
} }
......
import type { Meta, StoryObj } from '@storybook/react' import type { Meta, StoryObj } from '@storybook/react'
import type { OverlayState } from '../shared' import type { OverlayState } from '../shared'
// @ts-expect-error
import imgApp from './app.png'
import { useState } from 'react' import { useState } from 'react'
import { DevOverlay } from './dev-overlay' import { DevOverlay } from './dev-overlay'
import { ACTION_UNHANDLED_ERROR } from '../shared' import { ACTION_UNHANDLED_ERROR } from '../shared'
...@@ -84,11 +87,22 @@ export const Default: Story = { ...@@ -84,11 +87,22 @@ export const Default: Story = {
render: function DevOverlayStory() { render: function DevOverlayStory() {
const [isErrorOverlayOpen, setIsErrorOverlayOpen] = useState(true) const [isErrorOverlayOpen, setIsErrorOverlayOpen] = useState(true)
return ( return (
<DevOverlay <>
state={state} <img
isErrorOverlayOpen={isErrorOverlayOpen} src={imgApp}
setIsErrorOverlayOpen={setIsErrorOverlayOpen} style={{
/> width: '100%',
height: '100%',
objectFit: 'contain',
filter: 'invert(1)',
}}
/>
<DevOverlay
state={state}
isErrorOverlayOpen={isErrorOverlayOpen}
setIsErrorOverlayOpen={setIsErrorOverlayOpen}
/>
</>
) )
}, },
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment