Unverified Commit 252d3b72 authored by JJ Kasper's avatar JJ Kasper Committed by GitHub

Ensure we do not ignore module not found errors during build (#38026)

* Ensure we do not ignore module not found errors during build

* lint-fix
parent 1648064d
...@@ -41,7 +41,6 @@ import * as Log from './output/log' ...@@ -41,7 +41,6 @@ import * as Log from './output/log'
import { loadComponents } from '../server/load-components' import { loadComponents } from '../server/load-components'
import { trace } from '../trace' import { trace } from '../trace'
import { setHttpAgentOptions } from '../server/config' import { setHttpAgentOptions } from '../server/config'
import isError from '../lib/is-error'
import { recursiveDelete } from '../lib/recursive-delete' import { recursiveDelete } from '../lib/recursive-delete'
import { Sema } from 'next/dist/compiled/async-sema' import { Sema } from 'next/dist/compiled/async-sema'
import { MiddlewareManifest } from './webpack/plugins/middleware-plugin' import { MiddlewareManifest } from './webpack/plugins/middleware-plugin'
...@@ -871,119 +870,114 @@ export async function isPageStatic( ...@@ -871,119 +870,114 @@ export async function isPageStatic(
}> { }> {
const isPageStaticSpan = trace('is-page-static-utils', parentId) const isPageStaticSpan = trace('is-page-static-utils', parentId)
return isPageStaticSpan.traceAsyncFn(async () => { return isPageStaticSpan.traceAsyncFn(async () => {
try { require('../shared/lib/runtime-config').setConfig(runtimeEnvConfig)
require('../shared/lib/runtime-config').setConfig(runtimeEnvConfig) setHttpAgentOptions(httpAgentOptions)
setHttpAgentOptions(httpAgentOptions)
const mod = await loadComponents(distDir, page, serverless) const mod = await loadComponents(distDir, page, serverless)
const Comp = mod.Component const Comp = mod.Component
if (!Comp || !isValidElementType(Comp) || typeof Comp === 'string') { if (!Comp || !isValidElementType(Comp) || typeof Comp === 'string') {
throw new Error('INVALID_DEFAULT_EXPORT') throw new Error('INVALID_DEFAULT_EXPORT')
} }
const hasGetInitialProps = !!(Comp as any).getInitialProps const hasGetInitialProps = !!(Comp as any).getInitialProps
const hasStaticProps = !!mod.getStaticProps const hasStaticProps = !!mod.getStaticProps
const hasStaticPaths = !!mod.getStaticPaths const hasStaticPaths = !!mod.getStaticPaths
const hasServerProps = !!mod.getServerSideProps const hasServerProps = !!mod.getServerSideProps
const hasLegacyServerProps = !!(await mod.ComponentMod const hasLegacyServerProps = !!(await mod.ComponentMod
.unstable_getServerProps) .unstable_getServerProps)
const hasLegacyStaticProps = !!(await mod.ComponentMod const hasLegacyStaticProps = !!(await mod.ComponentMod
.unstable_getStaticProps) .unstable_getStaticProps)
const hasLegacyStaticPaths = !!(await mod.ComponentMod const hasLegacyStaticPaths = !!(await mod.ComponentMod
.unstable_getStaticPaths) .unstable_getStaticPaths)
const hasLegacyStaticParams = !!(await mod.ComponentMod const hasLegacyStaticParams = !!(await mod.ComponentMod
.unstable_getStaticParams) .unstable_getStaticParams)
if (hasLegacyStaticParams) { if (hasLegacyStaticParams) {
throw new Error( throw new Error(
`unstable_getStaticParams was replaced with getStaticPaths. Please update your code.` `unstable_getStaticParams was replaced with getStaticPaths. Please update your code.`
) )
} }
if (hasLegacyStaticPaths) { if (hasLegacyStaticPaths) {
throw new Error( throw new Error(
`unstable_getStaticPaths was replaced with getStaticPaths. Please update your code.` `unstable_getStaticPaths was replaced with getStaticPaths. Please update your code.`
) )
} }
if (hasLegacyStaticProps) { if (hasLegacyStaticProps) {
throw new Error( throw new Error(
`unstable_getStaticProps was replaced with getStaticProps. Please update your code.` `unstable_getStaticProps was replaced with getStaticProps. Please update your code.`
) )
} }
if (hasLegacyServerProps) { if (hasLegacyServerProps) {
throw new Error( throw new Error(
`unstable_getServerProps was replaced with getServerSideProps. Please update your code.` `unstable_getServerProps was replaced with getServerSideProps. Please update your code.`
) )
} }
// A page cannot be prerendered _and_ define a data requirement. That's // A page cannot be prerendered _and_ define a data requirement. That's
// contradictory! // contradictory!
if (hasGetInitialProps && hasStaticProps) { if (hasGetInitialProps && hasStaticProps) {
throw new Error(SSG_GET_INITIAL_PROPS_CONFLICT) throw new Error(SSG_GET_INITIAL_PROPS_CONFLICT)
} }
if (hasGetInitialProps && hasServerProps) { if (hasGetInitialProps && hasServerProps) {
throw new Error(SERVER_PROPS_GET_INIT_PROPS_CONFLICT) throw new Error(SERVER_PROPS_GET_INIT_PROPS_CONFLICT)
} }
if (hasStaticProps && hasServerProps) { if (hasStaticProps && hasServerProps) {
throw new Error(SERVER_PROPS_SSG_CONFLICT) throw new Error(SERVER_PROPS_SSG_CONFLICT)
} }
const pageIsDynamic = isDynamicRoute(page) const pageIsDynamic = isDynamicRoute(page)
// A page cannot have static parameters if it is not a dynamic page. // A page cannot have static parameters if it is not a dynamic page.
if (hasStaticProps && hasStaticPaths && !pageIsDynamic) { if (hasStaticProps && hasStaticPaths && !pageIsDynamic) {
throw new Error( throw new Error(
`getStaticPaths can only be used with dynamic pages, not '${page}'.` + `getStaticPaths can only be used with dynamic pages, not '${page}'.` +
`\nLearn more: https://nextjs.org/docs/routing/dynamic-routes` `\nLearn more: https://nextjs.org/docs/routing/dynamic-routes`
) )
} }
if (hasStaticProps && pageIsDynamic && !hasStaticPaths) { if (hasStaticProps && pageIsDynamic && !hasStaticPaths) {
throw new Error( throw new Error(
`getStaticPaths is required for dynamic SSG pages and is missing for '${page}'.` + `getStaticPaths is required for dynamic SSG pages and is missing for '${page}'.` +
`\nRead more: https://nextjs.org/docs/messages/invalid-getstaticpaths-value` `\nRead more: https://nextjs.org/docs/messages/invalid-getstaticpaths-value`
) )
} }
let prerenderRoutes: Array<string> | undefined let prerenderRoutes: Array<string> | undefined
let encodedPrerenderRoutes: Array<string> | undefined let encodedPrerenderRoutes: Array<string> | undefined
let prerenderFallback: boolean | 'blocking' | undefined let prerenderFallback: boolean | 'blocking' | undefined
if (hasStaticProps && hasStaticPaths) { if (hasStaticProps && hasStaticPaths) {
;({ ;({
paths: prerenderRoutes, paths: prerenderRoutes,
fallback: prerenderFallback, fallback: prerenderFallback,
encodedPaths: encodedPrerenderRoutes, encodedPaths: encodedPrerenderRoutes,
} = await buildStaticPaths( } = await buildStaticPaths(
page, page,
mod.getStaticPaths!, mod.getStaticPaths!,
configFileName, configFileName,
locales, locales,
defaultLocale defaultLocale
)) ))
} }
const isNextImageImported = (global as any).__NEXT_IMAGE_IMPORTED const isNextImageImported = (global as any).__NEXT_IMAGE_IMPORTED
const config: PageConfig = mod.pageConfig const config: PageConfig = mod.pageConfig
return { return {
isStatic: !hasStaticProps && !hasGetInitialProps && !hasServerProps, isStatic: !hasStaticProps && !hasGetInitialProps && !hasServerProps,
isHybridAmp: config.amp === 'hybrid', isHybridAmp: config.amp === 'hybrid',
isAmpOnly: config.amp === true, isAmpOnly: config.amp === true,
prerenderRoutes, prerenderRoutes,
prerenderFallback, prerenderFallback,
encodedPrerenderRoutes, encodedPrerenderRoutes,
hasStaticProps, hasStaticProps,
hasServerProps, hasServerProps,
isNextImageImported, isNextImageImported,
traceIncludes: config.unstable_includeFiles || [], traceIncludes: config.unstable_includeFiles || [],
traceExcludes: config.unstable_excludeFiles || [], traceExcludes: config.unstable_excludeFiles || [],
}
} catch (err) {
if (isError(err) && err.code === 'MODULE_NOT_FOUND') return {}
throw err
} }
}) })
} }
......
module.exports = {
eslint: {
ignoreDuringBuilds: true,
},
}
/* eslint-env jest */
import fs from 'fs-extra'
import { join } from 'path'
import { nextBuild } from 'next-test-utils'
const appDir = join(__dirname, '..')
const pagesDir = join(appDir, 'pages')
const testPage = join(pagesDir, 'test.js')
const writePage = async (content) => {
await fs.ensureDir(pagesDir)
await fs.writeFile(testPage, content)
}
describe('GSP build errors', () => {
afterEach(() => fs.remove(pagesDir))
it('should fail build from module not found', async () => {
await writePage(`
__non_webpack_require__('a-cool-module')
export function getStaticProps() {
return {
props: {}
}
}
export default function () {
return null
}
`)
const { stderr, code } = await nextBuild(appDir, [], { stderr: true })
expect(code).toBe(1)
expect(stderr).toContain('a-cool-module')
})
it('should fail build from ENOENT in getStaticProps', async () => {
await writePage(`
export function getStaticProps() {
require('fs').readFileSync('a-cool-file')
return {
props: {}
}
}
export default function () {
return null
}
`)
const { stderr, code } = await nextBuild(appDir, [], { stderr: true })
expect(code).toBe(1)
expect(stderr).toContain('a-cool-file')
})
it('should fail build on normal error in getStaticProps', async () => {
await writePage(`
export function getStaticProps() {
throw new Error('a cool error')
return {
props: {}
}
}
export default function () {
return null
}
`)
const { stderr, code } = await nextBuild(appDir, [], { stderr: true })
expect(code).toBe(1)
expect(stderr).toContain('a cool error')
})
it('should fail build from undefined error in getStaticProps', async () => {
await writePage(`
export function getStaticProps() {
throw undefined
return {
props: {}
}
}
export default function () {
return null
}
`)
const { stderr, code } = await nextBuild(appDir, [], { stderr: true })
expect(code).toBe(1)
expect(stderr).toContain('undefined')
})
it('should fail build from string error in getStaticProps', async () => {
await writePage(`
export function getStaticProps() {
throw 'a string error'
return {
props: {}
}
}
export default function () {
return null
}
`)
const { stderr, code } = await nextBuild(appDir, [], { stderr: true })
expect(code).toBe(1)
expect(stderr).toContain('a string error')
})
})
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment