Unverified Commit 252d3b72 authored by JJ Kasper's avatar JJ Kasper Committed by GitHub

Ensure we do not ignore module not found errors during build (#38026)

* Ensure we do not ignore module not found errors during build

* lint-fix
parent 1648064d
...@@ -41,7 +41,6 @@ import * as Log from './output/log' ...@@ -41,7 +41,6 @@ import * as Log from './output/log'
import { loadComponents } from '../server/load-components' import { loadComponents } from '../server/load-components'
import { trace } from '../trace' import { trace } from '../trace'
import { setHttpAgentOptions } from '../server/config' import { setHttpAgentOptions } from '../server/config'
import isError from '../lib/is-error'
import { recursiveDelete } from '../lib/recursive-delete' import { recursiveDelete } from '../lib/recursive-delete'
import { Sema } from 'next/dist/compiled/async-sema' import { Sema } from 'next/dist/compiled/async-sema'
import { MiddlewareManifest } from './webpack/plugins/middleware-plugin' import { MiddlewareManifest } from './webpack/plugins/middleware-plugin'
...@@ -871,7 +870,6 @@ export async function isPageStatic( ...@@ -871,7 +870,6 @@ export async function isPageStatic(
}> { }> {
const isPageStaticSpan = trace('is-page-static-utils', parentId) const isPageStaticSpan = trace('is-page-static-utils', parentId)
return isPageStaticSpan.traceAsyncFn(async () => { return isPageStaticSpan.traceAsyncFn(async () => {
try {
require('../shared/lib/runtime-config').setConfig(runtimeEnvConfig) require('../shared/lib/runtime-config').setConfig(runtimeEnvConfig)
setHttpAgentOptions(httpAgentOptions) setHttpAgentOptions(httpAgentOptions)
...@@ -981,10 +979,6 @@ export async function isPageStatic( ...@@ -981,10 +979,6 @@ export async function isPageStatic(
traceIncludes: config.unstable_includeFiles || [], traceIncludes: config.unstable_includeFiles || [],
traceExcludes: config.unstable_excludeFiles || [], traceExcludes: config.unstable_excludeFiles || [],
} }
} catch (err) {
if (isError(err) && err.code === 'MODULE_NOT_FOUND') return {}
throw err
}
}) })
} }
......
module.exports = {
eslint: {
ignoreDuringBuilds: true,
},
}
/* eslint-env jest */
import fs from 'fs-extra'
import { join } from 'path'
import { nextBuild } from 'next-test-utils'
const appDir = join(__dirname, '..')
const pagesDir = join(appDir, 'pages')
const testPage = join(pagesDir, 'test.js')
const writePage = async (content) => {
await fs.ensureDir(pagesDir)
await fs.writeFile(testPage, content)
}
describe('GSP build errors', () => {
afterEach(() => fs.remove(pagesDir))
it('should fail build from module not found', async () => {
await writePage(`
__non_webpack_require__('a-cool-module')
export function getStaticProps() {
return {
props: {}
}
}
export default function () {
return null
}
`)
const { stderr, code } = await nextBuild(appDir, [], { stderr: true })
expect(code).toBe(1)
expect(stderr).toContain('a-cool-module')
})
it('should fail build from ENOENT in getStaticProps', async () => {
await writePage(`
export function getStaticProps() {
require('fs').readFileSync('a-cool-file')
return {
props: {}
}
}
export default function () {
return null
}
`)
const { stderr, code } = await nextBuild(appDir, [], { stderr: true })
expect(code).toBe(1)
expect(stderr).toContain('a-cool-file')
})
it('should fail build on normal error in getStaticProps', async () => {
await writePage(`
export function getStaticProps() {
throw new Error('a cool error')
return {
props: {}
}
}
export default function () {
return null
}
`)
const { stderr, code } = await nextBuild(appDir, [], { stderr: true })
expect(code).toBe(1)
expect(stderr).toContain('a cool error')
})
it('should fail build from undefined error in getStaticProps', async () => {
await writePage(`
export function getStaticProps() {
throw undefined
return {
props: {}
}
}
export default function () {
return null
}
`)
const { stderr, code } = await nextBuild(appDir, [], { stderr: true })
expect(code).toBe(1)
expect(stderr).toContain('undefined')
})
it('should fail build from string error in getStaticProps', async () => {
await writePage(`
export function getStaticProps() {
throw 'a string error'
return {
props: {}
}
}
export default function () {
return null
}
`)
const { stderr, code } = await nextBuild(appDir, [], { stderr: true })
expect(code).toBe(1)
expect(stderr).toContain('a string error')
})
})
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment