Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
25e84157
Commit
25e84157
authored
Mar 18, 2026
by
Tobias Koppers
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Box the Expr fields in ExportBinding to reduce stack frame size
Co-Authored-By:
Claude
<
noreply@anthropic.com
>
parent
a41bef94
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
29 additions
and
27 deletions
+29
-27
export.rs
.../crates/turbopack-ecmascript/src/references/esm/export.rs
+29
-27
No files found.
turbopack/crates/turbopack-ecmascript/src/references/esm/export.rs
View file @
25e84157
...
@@ -687,18 +687,18 @@ impl EsmExports {
...
@@ -687,18 +687,18 @@ impl EsmExports {
#[derive(Eq,
PartialEq)]
#[derive(Eq,
PartialEq)]
enum
ExportBinding
{
enum
ExportBinding
{
Getter
(
Expr
),
Getter
(
Box
<
Expr
>
),
GetterSetter
(
Expr
,
Expr
),
GetterSetter
(
Box
<
Expr
>
,
Box
<
Expr
>
),
Value
(
Expr
),
Value
(
Box
<
Expr
>
),
None
,
None
,
}
}
let
mut
getters
=
Vec
::
new
();
let
mut
getters
=
Vec
::
new
();
for
(
exported
,
local
)
in
&
expanded
.exports
{
for
(
exported
,
local
)
in
&
expanded
.exports
{
let
exprs
:
ExportBinding
=
match
local
{
let
exprs
:
ExportBinding
=
match
local
{
EsmExport
::
Error
=>
ExportBinding
::
Getter
(
quote!
(
EsmExport
::
Error
=>
ExportBinding
::
Getter
(
Box
::
new
(
quote!
(
"(() => { throw new Error(
\
"
Failed
binding
. See
build
errors!
\
"); })"
as
Expr
,
"(() => { throw new Error(
\
"
Failed
binding
. See
build
errors!
\
"); })"
as
Expr
,
)),
))
)
,
EsmExport
::
LocalBinding
(
name
,
liveness
)
=>
{
EsmExport
::
LocalBinding
(
name
,
liveness
)
=>
{
// TODO ideally, this information would just be stored in
// TODO ideally, this information would just be stored in
// EsmExport::LocalBinding and we wouldn't have to re-correlated this
// EsmExport::LocalBinding and we wouldn't have to re-correlated this
...
@@ -727,19 +727,21 @@ impl EsmExports {
...
@@ -727,19 +727,21 @@ impl EsmExports {
let
local
=
Ident
::
new
(
local
.into
(),
DUMMY_SP
,
ctxt
);
let
local
=
Ident
::
new
(
local
.into
(),
DUMMY_SP
,
ctxt
);
match
(
liveness
,
export_usage_info
.is_circuit_breaker
)
{
match
(
liveness
,
export_usage_info
.is_circuit_breaker
)
{
(
Liveness
::
Constant
,
false
)
=>
ExportBinding
::
Value
(
Expr
::
Ident
(
local
)),
(
Liveness
::
Constant
,
false
)
=>
{
ExportBinding
::
Value
(
Box
::
new
(
Expr
::
Ident
(
local
)))
}
// If the value might change or we are a circuit breaker we must bind a
// If the value might change or we are a circuit breaker we must bind a
// getter to avoid capturing the value at the wrong time.
// getter to avoid capturing the value at the wrong time.
(
Liveness
::
Live
,
_
)
|
(
Liveness
::
Constant
,
true
)
=>
{
(
Liveness
::
Live
,
_
)
|
(
Liveness
::
Constant
,
true
)
=>
ExportBinding
::
Getter
(
ExportBinding
::
Getter
(
quote!
(
"() => $local"
as
Expr
,
local
=
local
))
Box
::
new
(
quote!
(
"() => $local"
as
Expr
,
local
=
local
)),
}
),
(
Liveness
::
Mutable
,
_
)
=>
ExportBinding
::
GetterSetter
(
(
Liveness
::
Mutable
,
_
)
=>
ExportBinding
::
GetterSetter
(
quote!
(
"() => $local"
as
Expr
,
local
=
local
.clone
(
)),
Box
::
new
(
quote!
(
"() => $local"
as
Expr
,
local
=
local
.clone
()
)),
quote!
(
Box
::
new
(
quote!
(
"($new) => $local = $new"
as
Expr
,
"($new) => $local = $new"
as
Expr
,
local
:
AssignTarget
=
AssignTarget
::
Simple
(
local
.into
()),
local
:
AssignTarget
=
AssignTarget
::
Simple
(
local
.into
()),
new
=
Ident
::
new
(
format!
(
"new_{name}"
)
.into
(),
DUMMY_SP
,
ctxt
),
new
=
Ident
::
new
(
format!
(
"new_{name}"
)
.into
(),
DUMMY_SP
,
ctxt
),
),
)
)
,
),
),
}
}
}
}
...
@@ -759,25 +761,25 @@ impl EsmExports {
...
@@ -759,25 +761,25 @@ impl EsmExports {
// If we are re-exporting something but got merged with it we can treat it like a local export
// If we are re-exporting something but got merged with it we can treat it like a local export
match
(
liveness
,
export_usage_info
.is_circuit_breaker
)
{
match
(
liveness
,
export_usage_info
.is_circuit_breaker
)
{
(
Liveness
::
Constant
,
false
)
=>
{
(
Liveness
::
Constant
,
false
)
=>
{
ExportBinding
::
Value
(
read_expr
)
ExportBinding
::
Value
(
Box
::
new
(
read_expr
)
)
}
}
// If the value might change or we are a circuit breaker we must bind a
// If the value might change or we are a circuit breaker we must bind a
// getter to avoid capturing the value at the wrong time.
// getter to avoid capturing the value at the wrong time.
(
Liveness
::
Live
,
_
)
|
(
Liveness
::
Constant
,
true
)
=>
{
(
Liveness
::
Live
,
_
)
|
(
Liveness
::
Constant
,
true
)
=>
{
// In the constant case, we could still export as a value if we knew that the module
// In the constant case, we could still export as a value if we knew that the module
// came _before_ us, but we don't at this point.
// came _before_ us, but we don't at this point.
ExportBinding
::
Getter
(
quote!
(
"() => $local"
as
Expr
,
local
:
Expr
=
read_expr
))
ExportBinding
::
Getter
(
Box
::
new
(
quote!
(
"() => $local"
as
Expr
,
local
:
Expr
=
read_expr
)
))
}
}
(
Liveness
::
Mutable
,
_
)
=>
{
(
Liveness
::
Mutable
,
_
)
=>
{
let
assign_target
=
AssignTarget
::
Simple
(
let
assign_target
=
AssignTarget
::
Simple
(
ident
.as_expr_individual
(
DUMMY_SP
)
.map_either
(|
i
|
SimpleAssignTarget
::
Ident
(
i
.into
()),
SimpleAssignTarget
::
Member
)
.into_inner
());
ident
.as_expr_individual
(
DUMMY_SP
)
.map_either
(|
i
|
SimpleAssignTarget
::
Ident
(
i
.into
()),
SimpleAssignTarget
::
Member
)
.into_inner
());
ExportBinding
::
GetterSetter
(
ExportBinding
::
GetterSetter
(
quote!
(
"() => $local"
as
Expr
,
local
:
Expr
=
read_expr
.clone
(
)),
Box
::
new
(
quote!
(
"() => $local"
as
Expr
,
local
:
Expr
=
read_expr
.clone
()
)),
quote!
(
Box
::
new
(
quote!
(
"($new) => $lhs = $new"
as
Expr
,
"($new) => $lhs = $new"
as
Expr
,
lhs
:
AssignTarget
=
assign_target
,
lhs
:
AssignTarget
=
assign_target
,
new
=
Ident
::
new
(
format!
(
"new_{name}"
)
.into
(),
DUMMY_SP
,
*
ctxt
),
new
=
Ident
::
new
(
format!
(
"new_{name}"
)
.into
(),
DUMMY_SP
,
*
ctxt
),
)
)
)
)
)
}
}
}
}
...
@@ -786,13 +788,13 @@ impl EsmExports {
...
@@ -786,13 +788,13 @@ impl EsmExports {
// Otherwise we need to bind as a getter to preserve the 'liveness' of the other modules bindings.
// Otherwise we need to bind as a getter to preserve the 'liveness' of the other modules bindings.
// TODO: If this becomes important it might be faster to use the runtime to copy PropertyDescriptors across modules
// TODO: If this becomes important it might be faster to use the runtime to copy PropertyDescriptors across modules
// since that would reduce allocations and optimize access. We could do this by passing the module-id up.
// since that would reduce allocations and optimize access. We could do this by passing the module-id up.
let
getter
=
quote!
(
"() => $expr"
as
Expr
,
expr
:
Expr
=
read_expr
);
let
getter
=
Box
::
new
(
quote!
(
"() => $expr"
as
Expr
,
expr
:
Expr
=
read_expr
)
);
let
assign_target
=
AssignTarget
::
Simple
(
let
assign_target
=
AssignTarget
::
Simple
(
ident
.as_expr_individual
(
DUMMY_SP
)
.map_either
(|
i
|
SimpleAssignTarget
::
Ident
(
i
.into
()),
SimpleAssignTarget
::
Member
)
.into_inner
());
ident
.as_expr_individual
(
DUMMY_SP
)
.map_either
(|
i
|
SimpleAssignTarget
::
Ident
(
i
.into
()),
SimpleAssignTarget
::
Member
)
.into_inner
());
if
*
mutable
{
if
*
mutable
{
ExportBinding
::
GetterSetter
(
ExportBinding
::
GetterSetter
(
getter
,
getter
,
quote!
(
Box
::
new
(
quote!
(
"($new) => $lhs = $new"
as
Expr
,
"($new) => $lhs = $new"
as
Expr
,
lhs
:
AssignTarget
=
assign_target
,
lhs
:
AssignTarget
=
assign_target
,
new
=
Ident
::
new
(
new
=
Ident
::
new
(
...
@@ -800,7 +802,7 @@ impl EsmExports {
...
@@ -800,7 +802,7 @@ impl EsmExports {
DUMMY_SP
,
DUMMY_SP
,
Default
::
default
()
Default
::
default
()
),
),
))
))
)
}
else
{
}
else
{
ExportBinding
::
Getter
(
getter
)
ExportBinding
::
Getter
(
getter
)
}
}
...
@@ -817,12 +819,12 @@ impl EsmExports {
...
@@ -817,12 +819,12 @@ impl EsmExports {
.map
(|
ident
|
{
.map
(|
ident
|
{
let
imported
=
ident
.as_expr
(
DUMMY_SP
,
false
);
let
imported
=
ident
.as_expr
(
DUMMY_SP
,
false
);
if
export_usage_info
.is_circuit_breaker
{
if
export_usage_info
.is_circuit_breaker
{
ExportBinding
::
Getter
(
quote!
(
ExportBinding
::
Getter
(
Box
::
new
(
quote!
(
"(() => $imported)"
as
Expr
,
"(() => $imported)"
as
Expr
,
imported
:
Expr
=
imported
imported
:
Expr
=
imported
))
))
)
}
else
{
}
else
{
ExportBinding
::
Value
(
imported
)
ExportBinding
::
Value
(
Box
::
new
(
imported
)
)
}
}
})
})
.unwrap_or
(
ExportBinding
::
None
)
.unwrap_or
(
ExportBinding
::
None
)
...
@@ -839,17 +841,17 @@ impl EsmExports {
...
@@ -839,17 +841,17 @@ impl EsmExports {
));
));
match
exprs
{
match
exprs
{
ExportBinding
::
Getter
(
getter
)
=>
{
ExportBinding
::
Getter
(
getter
)
=>
{
getters
.push
(
Some
(
getter
.into
()));
getters
.push
(
Some
(
(
*
getter
)
.into
()));
}
}
ExportBinding
::
GetterSetter
(
getter
,
setter
)
=>
{
ExportBinding
::
GetterSetter
(
getter
,
setter
)
=>
{
getters
.push
(
Some
(
getter
.into
()));
getters
.push
(
Some
(
(
*
getter
)
.into
()));
getters
.push
(
Some
(
setter
.into
()));
getters
.push
(
Some
(
(
*
setter
)
.into
()));
}
}
ExportBinding
::
Value
(
value
)
=>
{
ExportBinding
::
Value
(
value
)
=>
{
// We need to push a discriminator in this case to make the fact that we are
// We need to push a discriminator in this case to make the fact that we are
// binding a value unambiguous to the runtime.
// binding a value unambiguous to the runtime.
getters
.push
(
Some
(
Expr
::
Lit
(
Lit
::
Num
(
Number
::
from
(
0
)))
.into
()));
getters
.push
(
Some
(
Expr
::
Lit
(
Lit
::
Num
(
Number
::
from
(
0
)))
.into
()));
getters
.push
(
Some
(
value
.into
()));
getters
.push
(
Some
(
(
*
value
)
.into
()));
}
}
ExportBinding
::
None
=>
{}
ExportBinding
::
None
=>
{}
};
};
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment