Unverified Commit 263dc23a authored by Jiachi Liu's avatar Jiachi Liu Committed by GitHub

[error overlay] fix missing html error is not displayed (#75831)

### What

`[data-nextjs-dialog-content]` was set to `height: 100%`, which has
conflicted with useMeasureHeight hook. `data-nextjs-dialog-content]` 's
parent is always controlled by `useMeasureHeight`, and the height is
anmiating from 0 to the child height. If the child is aligned with that
parent, then the height is always 0, which lead to not displayed

Closes NDX-797
parent c0031816
...@@ -29,7 +29,9 @@ const styles = css` ...@@ -29,7 +29,9 @@ const styles = css`
outline: none; outline: none;
} }
/* Place overflow: hidden on this so we can break out from [data-nextjs-dialog] */ ${
'' /* Place overflow: hidden on this so we can break out from [data-nextjs-dialog] */
}
[data-nextjs-dialog-sizer] { [data-nextjs-dialog-sizer] {
overflow: hidden; overflow: hidden;
border-radius: inherit; border-radius: inherit;
...@@ -48,7 +50,6 @@ const styles = css` ...@@ -48,7 +50,6 @@ const styles = css`
[data-nextjs-dialog-content] { [data-nextjs-dialog-content] {
border: none; border: none;
margin: 0; margin: 0;
height: 100%;
display: flex; display: flex;
flex-direction: column; flex-direction: column;
position: relative; position: relative;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment