Unverified Commit 2bd65884 authored by Zack Tanner's avatar Zack Tanner Committed by GitHub

add additional x-middleware-set-cookie filtering (#75869)

Backports:
- #75561
parent 0d9f6059
......@@ -36,6 +36,11 @@ export async function sendResponse(
// Copy over the response headers.
response.headers?.forEach((value, name) => {
// `x-middleware-set-cookie` is an internal header not needed for the response
if (name.toLowerCase() === 'x-middleware-set-cookie') {
return
}
// The append handling is special cased for `set-cookie`.
if (name.toLowerCase() === 'set-cookie') {
// TODO: (wyattjoh) replace with native response iteration when we can upgrade undici
......
......@@ -191,6 +191,12 @@ describe('app-dir with middleware', () => {
const response = await next.fetch('/rsc-cookies/cookie-options')
expect(response.status).toBe(200)
expect(response.headers.get('x-middleware-set-cookie')).toBeNull()
const response2 = await next.fetch('/cookies/api')
expect(response2.status).toBe(200)
expect(response2.headers.get('x-middleware-set-cookie')).toBeNull()
expect(response2.headers.get('set-cookie')).toBeDefined()
expect(response2.headers.get('set-cookie')).toContain('example')
})
it('should ignore x-middleware-set-cookie as a request header', async () => {
......
import { NextResponse } from 'next/server'
export function GET() {
const response = new NextResponse()
response.cookies.set({
name: 'example',
value: 'example',
})
return response
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment