Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
2c05914f
Unverified
Commit
2c05914f
authored
Oct 09, 2024
by
Jiachi Liu
Committed by
GitHub
Oct 09, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
codemod: fix type only react import (#71053)
Co-authored-by:
JJ Kasper
<
jj@jjsweb.site
>
parent
c21a74c7
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
36 additions
and
12 deletions
+36
-12
access-props-04.input.tsx
...async-request-api-dynamic-props/access-props-04.input.tsx
+2
-2
access-props-04.output.tsx
...sync-request-api-dynamic-props/access-props-04.output.tsx
+2
-2
access-props-30.input.tsx
...async-request-api-dynamic-props/access-props-30.input.tsx
+13
-0
access-props-30.output.tsx
...sync-request-api-dynamic-props/access-props-30.output.tsx
+15
-0
utils.ts
...es/next-codemod/transforms/lib/async-request-api/utils.ts
+4
-8
No files found.
packages/next-codemod/transforms/__testfixtures__/next-async-request-api-dynamic-props/access-props-04.input.tsx
View file @
2c05914f
'use client'
import
{
useState
}
from
'react'
import
{
useState
,
type
JSX
}
from
'react'
export
default
function
Page
({
params
}:
{
params
:
{
slug
:
string
}
})
{
export
default
function
Page
({
params
}:
{
params
:
{
slug
:
string
}
})
:
JSX
.
Element
{
const
[
text
,
setText
]
=
useState
(
''
)
// usage of `params`
globalThis
.
f1
(
params
)
...
...
packages/next-codemod/transforms/__testfixtures__/next-async-request-api-dynamic-props/access-props-04.output.tsx
View file @
2c05914f
'use client'
import
{
useState
,
use
}
from
'react'
;
import
{
useState
,
type
JSX
,
use
}
from
'react'
;
export
default
function
Page
(
props
:
{
params
:
Promise
<
{
slug
:
string
}
>
})
{
export
default
function
Page
(
props
:
{
params
:
Promise
<
{
slug
:
string
}
>
})
:
JSX
.
Element
{
const
params
=
use
(
props
.
params
);
const
[
text
,
setText
]
=
useState
(
''
)
// usage of `params`
...
...
packages/next-codemod/transforms/__testfixtures__/next-async-request-api-dynamic-props/access-props-30.input.tsx
0 → 100644
View file @
2c05914f
'use client'
import
type
{
JSX
}
from
'react'
interface
Props
{
params
:
{
slug
:
string
}
}
export
default
function
Page
({
params
}:
Props
):
JSX
.
Element
{
const
{
slug
}
=
params
return
<
p
>
{
slug
}
</
p
>
}
packages/next-codemod/transforms/__testfixtures__/next-async-request-api-dynamic-props/access-props-30.output.tsx
0 → 100644
View file @
2c05914f
'use client'
;
import
{
use
}
from
"react"
;
import
type
{
JSX
}
from
'react'
interface
Props
{
params
:
Promise
<
{
slug
:
string
}
>
}
export
default
function
Page
(
props
:
Props
):
JSX
.
Element
{
const
params
=
use
(
props
.
params
);
const
{
slug
}
=
params
return
<
p
>
{
slug
}
</
p
>
}
packages/next-codemod/transforms/lib/async-request-api/utils.ts
View file @
2c05914f
...
...
@@ -188,6 +188,8 @@ export function insertReactUseImport(root: Collection<any>, j: API['j']) {
source
:
{
value
:
'react'
,
},
// Skip the type only react imports
importKind
:
'value'
,
})
if
(
reactImportDeclaration
.
size
()
>
0
)
{
...
...
@@ -197,14 +199,8 @@ export function insertReactUseImport(root: Collection<any>, j: API['j']) {
importNode
.
specifiers
.
push
(
j
.
importSpecifier
(
j
.
identifier
(
'use'
)))
}
else
{
// Final all type imports to 'react'
const
reactImport
=
root
.
find
(
j
.
ImportDeclaration
,
{
source
:
{
value
:
'react'
,
},
})
if
(
reactImport
.
size
()
>
0
)
{
reactImport
if
(
reactImportDeclaration
.
size
()
>
0
)
{
reactImportDeclaration
.
get
()
.
node
.
specifiers
.
push
(
j
.
importSpecifier
(
j
.
identifier
(
'use'
)))
}
else
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment