Unverified Commit 2ca8d3d3 authored by OJ Kwon's avatar OJ Kwon Committed by GitHub

test(fixture): separate pnpm cache for the test installation (#61783)

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->

### What?
https://vercel.slack.com/archives/C04DUD7EB1B/p1707296379554859

I hit this badly as well, pnpm cache grows > 300gb due to running test
locally a bunch. Trying to adjust fixture setup to use tmpdir as cache
location if the pkg installation is for the test.


Closes PACK-2434
parent 09c8eae4
......@@ -9,11 +9,14 @@ const { linkPackages } =
const PREFER_OFFLINE = process.env.NEXT_TEST_PREFER_OFFLINE === '1'
async function installDependencies(cwd) {
async function installDependencies(cwd, tmpDir) {
const args = [
'install',
'--strict-peer-dependencies=false',
'--no-frozen-lockfile',
// For the testing installation, use a separate cache directory
// to avoid local testing grows pnpm's default cache indefinitely with test packages.
`--config.cacheDir=${tmpDir}`,
]
if (PREFER_OFFLINE) {
......@@ -36,10 +39,11 @@ async function createNextInstall({
dirSuffix = '',
keepRepoDir = false,
}) {
const tmpDir = await fs.realpath(process.env.NEXT_TEST_DIR || os.tmpdir())
return await parentSpan
.traceChild('createNextInstall')
.traceAsyncFn(async (rootSpan) => {
const tmpDir = await fs.realpath(process.env.NEXT_TEST_DIR || os.tmpdir())
const origRepoDir = path.join(__dirname, '../../')
const installDir = path.join(
tmpDir,
......@@ -169,7 +173,7 @@ async function createNextInstall({
} else {
await rootSpan
.traceChild('run generic install command')
.traceAsyncFn(() => installDependencies(installDir))
.traceAsyncFn(() => installDependencies(installDir, tmpDir))
}
if (!keepRepoDir && tmpRepoDir) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment