Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
2ce4e440
Unverified
Commit
2ce4e440
authored
Nov 09, 2024
by
Sebastian "Sebbie" Silbermann
Committed by
GitHub
Nov 09, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Expand `server-source-maps` scenarios to cover Edge runtime (#72288)
...and use test patterns more consistently
parent
9b78a23b
Hide whitespace changes
Inline
Side-by-side
Showing
18 changed files
with
286 additions
and
130 deletions
+286
-130
app-render-error-log.test.ts
...lopment/app-render-error-log/app-render-error-log.test.ts
+0
-39
page.tsx
test/development/app-render-error-log/app/edge/page.tsx
+0
-8
fn.ts
test/development/app-render-error-log/app/fn.ts
+0
-7
next.config.js
test/development/app-render-error-log/next.config.js
+0
-1
layout.js
...app-dir/server-source-maps/fixtures/default/app/layout.js
+5
-1
page.js
...rce-maps/fixtures/default/app/rsc-error-log-cause/page.js
+5
-1
page.js
...ps/fixtures/default/app/rsc-error-log-custom-name/page.js
+5
-1
page.js
.../fixtures/default/app/rsc-error-log-ignore-listed/page.js
+4
-1
page.js
...er-source-maps/fixtures/default/app/rsc-error-log/page.js
+5
-1
Thrower.js
...ver-source-maps/fixtures/default/app/ssr-throw/Thrower.js
+9
-0
page.js
...server-source-maps/fixtures/default/app/ssr-throw/page.js
+7
-0
layout.js
...2e/app-dir/server-source-maps/fixtures/edge/app/layout.js
+9
-0
page.js
...erver-source-maps/fixtures/edge/app/rsc-error-log/page.js
+1
-4
page.js
...ir/server-source-maps/fixtures/edge/app/rsc-throw/page.js
+8
-0
page.js
...ir/server-source-maps/fixtures/edge/app/ssr-throw/page.js
+10
-0
next.config.js
...e/app-dir/server-source-maps/fixtures/edge/next.config.js
+10
-0
server-source-maps-edge.test.ts
...pp-dir/server-source-maps/server-source-maps-edge.test.ts
+99
-0
server-source-maps.test.ts
...e2e/app-dir/server-source-maps/server-source-maps.test.ts
+109
-66
No files found.
test/development/app-render-error-log/app-render-error-log.test.ts
deleted
100644 → 0
View file @
9b78a23b
import
{
nextTestSetup
}
from
'e2e-utils'
import
{
check
}
from
'next-test-utils'
describe
(
'app-render-error-log'
,
()
=>
{
const
{
next
}
=
nextTestSetup
({
files
:
__dirname
,
})
it
(
'should log the correct values on app-render error'
,
async
()
=>
{
const
outputIndex
=
next
.
cliOutput
.
length
await
next
.
fetch
(
'/'
)
await
check
(()
=>
next
.
cliOutput
.
slice
(
outputIndex
),
/at Page/
)
const
cliOutput
=
next
.
cliOutput
.
slice
(
outputIndex
)
await
check
(()
=>
cliOutput
,
/digest:/
)
expect
(
cliOutput
).
toInclude
(
'Error: boom'
)
expect
(
cliOutput
).
toInclude
(
'at fn2 (./app/fn.ts'
)
expect
(
cliOutput
).
toMatch
(
/at
(
Module
\.)?
fn1
\(\.\/
app
\/
fn
\.
ts/
)
expect
(
cliOutput
).
toInclude
(
'at Page (./app/page.tsx'
)
expect
(
cliOutput
).
not
.
toInclude
(
'webpack-internal'
)
})
it
(
'should log the correct values on app-render error with edge runtime'
,
async
()
=>
{
const
outputIndex
=
next
.
cliOutput
.
length
await
next
.
fetch
(
'/edge'
)
await
check
(()
=>
next
.
cliOutput
.
slice
(
outputIndex
),
/at EdgePage/
)
const
cliOutput
=
next
.
cliOutput
.
slice
(
outputIndex
)
await
check
(()
=>
cliOutput
,
/digest:/
)
expect
(
cliOutput
).
toInclude
(
'Error: boom'
)
expect
(
cliOutput
).
toInclude
(
'at fn2 (./app/fn.ts'
)
expect
(
cliOutput
).
toMatch
(
/at
(
Module
\.)?
fn1
\(\.\/
app
\/
fn
\.
ts/
)
expect
(
cliOutput
).
toInclude
(
'at EdgePage (./app/edge/page.tsx'
)
expect
(
cliOutput
).
not
.
toInclude
(
'webpack-internal'
)
})
})
test/development/app-render-error-log/app/edge/page.tsx
deleted
100644 → 0
View file @
9b78a23b
export
const
runtime
=
'edge'
import
{
fn1
}
from
'../fn'
export
default
function
EdgePage
()
{
fn1
()
return
<
p
>
hello world
</
p
>
}
test/development/app-render-error-log/app/fn.ts
deleted
100644 → 0
View file @
9b78a23b
function
fn2
()
{
throw
new
Error
(
'boom'
)
}
export
function
fn1
()
{
fn2
()
}
test/development/app-render-error-log/next.config.js
deleted
100644 → 0
View file @
9b78a23b
module
.
exports
=
{}
test/e2e/app-dir/server-source-maps/fixtures/default/app/layout.js
View file @
2ce4e440
import
{
Suspense
}
from
'react'
export
default
function
Root
({
children
})
{
export
default
function
Root
({
children
})
{
return
(
return
(
<
html
>
<
html
>
<
body
>
{
children
}
<
/body
>
<
body
>
<
Suspense
>
{
children
}
<
/Suspense
>
<
/body
>
<
/html
>
<
/html
>
)
)
}
}
test/e2e/app-dir/server-source-maps/fixtures/default/app/rsc-error-log-cause/page.js
View file @
2ce4e440
import
{
connection
}
from
'next/server'
function
logError
(
cause
)
{
function
logError
(
cause
)
{
const
error
=
new
Error
(
'Boom'
,
{
cause
})
const
error
=
new
Error
(
'Boom'
,
{
cause
})
console
.
error
(
error
)
console
.
error
(
error
)
}
}
export
default
function
Page
()
{
export
default
async
function
Page
()
{
await
connection
()
const
error
=
new
Error
(
'Boom'
)
const
error
=
new
Error
(
'Boom'
)
logError
(
error
)
logError
(
error
)
return
null
return
null
...
...
test/e2e/app-dir/server-source-maps/fixtures/default/app/rsc-error-log-custom-name/page.js
View file @
2ce4e440
import
{
connection
}
from
'next/server'
class
UnnamedError
extends
Error
{}
class
UnnamedError
extends
Error
{}
class
NamedError
extends
Error
{
class
NamedError
extends
Error
{
name
=
'MyError'
name
=
'MyError'
}
}
export
default
function
Page
()
{
export
default
async
function
Page
()
{
await
connection
()
console
.
error
(
new
UnnamedError
(
'Foo'
))
console
.
error
(
new
UnnamedError
(
'Foo'
))
console
.
error
(
new
NamedError
(
'Bar'
))
console
.
error
(
new
NamedError
(
'Bar'
))
return
null
return
null
...
...
test/e2e/app-dir/server-source-maps/fixtures/default/app/rsc-error-log-ignore-listed/page.js
View file @
2ce4e440
import
{
connection
}
from
'next/server'
import
{
run
}
from
'internal-pkg'
import
{
run
}
from
'internal-pkg'
function
logError
()
{
function
logError
()
{
...
@@ -5,7 +6,9 @@ function logError() {
...
@@ -5,7 +6,9 @@ function logError() {
console
.
error
(
error
)
console
.
error
(
error
)
}
}
export
default
function
Page
()
{
export
default
async
function
Page
()
{
await
connection
()
run
(()
=>
logError
())
run
(()
=>
logError
())
return
null
return
null
}
}
test/e2e/app-dir/server-source-maps/fixtures/default/app/rsc-error-log/page.js
View file @
2ce4e440
import
{
connection
}
from
'next/server'
function
logError
()
{
function
logError
()
{
const
error
=
new
Error
(
'Boom'
)
const
error
=
new
Error
(
'Boom'
)
console
.
error
(
error
)
console
.
error
(
error
)
}
}
export
default
function
Page
()
{
export
default
async
function
Page
()
{
await
connection
()
logError
()
logError
()
return
null
return
null
}
}
test/e2e/app-dir/server-source-maps/fixtures/default/app/ssr-throw/Thrower.js
0 → 100644
View file @
2ce4e440
'use client'
function
throwError
()
{
throw
new
Error
(
'Boom'
)
}
export
function
Thrower
()
{
throwError
()
}
test/e2e/app-dir/server-source-maps/fixtures/default/app/ssr-throw/page.js
0 → 100644
View file @
2ce4e440
import
{
connection
}
from
'next/server'
import
{
Thrower
}
from
'./Thrower'
export
default
async
function
Page
()
{
await
connection
()
return
<
Thrower
/>
}
test/
development/app-render-error-log/app/layout.tsx
→
test/
e2e/app-dir/server-source-maps/fixtures/edge/app/layout.js
View file @
2ce4e440
export
default
function
Root
({
children
}:
{
children
:
React
.
ReactNode
})
{
export
const
runtime
=
'edge'
export
default
function
Root
({
children
})
{
return
(
return
(
<
html
>
<
html
>
<
body
>
{
children
}
<
/body
>
<
body
>
{
children
}
<
/body
>
...
...
test/e2e/app-dir/server-source-maps/fixtures/
default/app/ssr
-error-log/page.js
→
test/e2e/app-dir/server-source-maps/fixtures/
edge/app/rsc
-error-log/page.js
View file @
2ce4e440
'use client'
function
logError
()
{
function
logError
()
{
const
error
=
new
Error
(
'Boom'
)
console
.
error
(
new
Error
(
'Boom'
))
console
.
error
(
error
)
}
}
export
default
function
Page
()
{
export
default
function
Page
()
{
...
...
test/
development/app-render-error-log/app/page.tsx
→
test/
e2e/app-dir/server-source-maps/fixtures/edge/app/rsc-throw/page.js
View file @
2ce4e440
import
{
fn1
}
from
'./fn'
function
throwError
()
{
throw
new
Error
(
'Boom'
)
}
export
default
function
Page
()
{
export
default
function
Page
()
{
fn1
()
throwError
()
return
<
p
>
hello world
</
p
>
return
null
}
}
test/e2e/app-dir/server-source-maps/fixtures/edge/app/ssr-throw/page.js
0 → 100644
View file @
2ce4e440
'use client'
function
throwError
()
{
throw
new
Error
(
'Boom'
)
}
export
default
function
Page
()
{
throwError
()
return
null
}
test/e2e/app-dir/server-source-maps/fixtures/edge/next.config.js
0 → 100644
View file @
2ce4e440
/**
* @type {import('next').NextConfig}
*/
const
nextConfig
=
{
experimental
:
{
serverSourceMaps
:
true
,
},
}
module
.
exports
=
nextConfig
test/e2e/app-dir/server-source-maps/server-source-maps-edge.test.ts
0 → 100644
View file @
2ce4e440
/* eslint-disable jest/no-standalone-expect */
import
*
as
path
from
'path'
import
{
nextTestSetup
}
from
'e2e-utils'
import
stripAnsi
from
'strip-ansi'
import
{
retry
}
from
'next-test-utils'
function
normalizeCliOutput
(
output
:
string
)
{
return
stripAnsi
(
output
)
}
describe
(
'app-dir - server source maps edge runtime'
,
()
=>
{
const
{
skipped
,
next
,
isNextDev
,
isTurbopack
}
=
nextTestSetup
({
files
:
path
.
join
(
__dirname
,
'fixtures/edge'
),
// Deploy tests don't have access to runtime logs.
// Manually verify that the runtime logs match.
skipDeployment
:
true
,
})
if
(
skipped
)
return
it
(
'logged errors have a sourcemapped stack with a codeframe'
,
async
()
=>
{
const
outputIndex
=
next
.
cliOutput
.
length
await
next
.
render
(
'/rsc-error-log'
)
if
(
isNextDev
)
{
await
retry
(()
=>
{
expect
(
next
.
cliOutput
.
slice
(
outputIndex
)).
toContain
(
'Error: Boom'
)
})
expect
(
normalizeCliOutput
(
next
.
cliOutput
.
slice
(
outputIndex
))).
toContain
(
isTurbopack
?
// TODO(veil): Error stack should be printed
'
\
n[Error: Boom]
\
n'
:
// TODO(veil): Error stack should be printed
'
\
n[Error: Boom]
\
n'
)
}
else
{
// TODO: Test `next build` with `--enable-source-maps`.
}
})
it
(
'thrown SSR errors'
,
async
()
=>
{
const
outputIndex
=
next
.
cliOutput
.
length
await
next
.
render
(
'/ssr-throw'
)
if
(
isNextDev
)
{
await
retry
(()
=>
{
expect
(
next
.
cliOutput
.
slice
(
outputIndex
)).
toContain
(
'Error: Boom'
)
})
const
cliOutput
=
stripAnsi
(
next
.
cliOutput
.
slice
(
outputIndex
))
expect
(
cliOutput
).
toContain
(
isTurbopack
?
'
\
n ⨯ Error: Boom'
+
'
\
n at throwError (./app/ssr-throw/page.js:4:9)'
+
'
\
n at Page (./app/ssr-throw/page.js:8:3)'
+
'
\
ndigest: "'
:
'
\
n ⨯ Error: Boom'
+
'
\
n at throwError (./app/ssr-throw/page.js:6:11)'
+
'
\
n at Page (./app/ssr-throw/page.js:9:5)'
+
'
\
ndigest: "'
)
expect
(
cliOutput
).
toMatch
(
/digest: "
\d
+"/
)
}
else
{
// TODO: Test `next build` with `--enable-source-maps`.
}
})
it
(
'should log the correct values on app-render error'
,
async
()
=>
{
const
outputIndex
=
next
.
cliOutput
.
length
await
next
.
fetch
(
'/rsc-throw'
)
if
(
isNextDev
)
{
await
retry
(()
=>
{
expect
(
next
.
cliOutput
.
slice
(
outputIndex
)).
toMatch
(
/Error: Boom/
)
})
const
cliOutput
=
stripAnsi
(
next
.
cliOutput
.
slice
(
outputIndex
))
// TODO(veil): Hide Node.js internal stackframes
expect
(
cliOutput
).
toContain
(
isTurbopack
?
'
\
n ⨯ Error: Boom'
+
'
\
n at throwError (./app/rsc-throw/page.js:2:9)'
+
'
\
n at Page (./app/rsc-throw/page.js:6:3)'
+
// TODO(veil): Hide Node.js internal stackframes
'
\
n at AsyncLocalStorage.run (node:async_hooks:346:14)'
+
'
\
ndigest: "'
:
'
\
n ⨯ Error: Boom'
+
'
\
n at throwError (./app/rsc-throw/page.js:6:11)'
+
'
\
n at Page (./app/rsc-throw/page.js:9:5)'
+
// TODO(veil): Hide Node.js internal stackframes
'
\
n at AsyncLocalStorage.run (node:async_hooks:346:14)'
+
'
\
ndigest: "'
)
expect
(
cliOutput
).
toMatch
(
/digest: "
\d
+"/
)
}
else
{
// TODO: Test `next build` with `--enable-source-maps`.
}
})
})
test/e2e/app-dir/server-source-maps/server-source-maps.test.ts
View file @
2ce4e440
...
@@ -26,61 +26,67 @@ describe('app-dir - server source maps', () => {
...
@@ -26,61 +26,67 @@ describe('app-dir - server source maps', () => {
if
(
skipped
)
return
if
(
skipped
)
return
it
(
'logged errors have a sourcemapped stack with a codeframe'
,
async
()
=>
{
it
(
'logged errors have a sourcemapped stack with a codeframe'
,
async
()
=>
{
const
outputIndex
=
next
.
cliOutput
.
length
await
next
.
render
(
'/rsc-error-log'
)
await
next
.
render
(
'/rsc-error-log'
)
if
(
isNextDev
)
{
if
(
isNextDev
)
{
await
retry
(()
=>
{
await
retry
(()
=>
{
expect
(
normalizeCliOutput
(
next
.
cliOutput
)).
toContain
(
expect
(
next
.
cliOutput
.
slice
(
outputIndex
)).
toContain
(
'Error: Boom'
)
'
\
nError: Boom'
+
'
\
n at logError (app/rsc-error-log/page.js:2:16)'
+
(
isTurbopack
?
'
\
n at Page (app/rsc-error-log/page.js:7:2)'
:
// FIXME: Method name should be "Page"
'
\
n at logError (app/rsc-error-log/page.js:7:2)'
)
+
'
\
n 1 | function logError() {'
+
"
\n
> 2 | const error = new Error('Boom')"
+
'
\
n | ^'
+
'
\
n 3 | console.error(error)'
+
'
\
n 4 | }'
+
'
\
n 5 |'
+
'
\
n'
)
})
})
expect
(
normalizeCliOutput
(
next
.
cliOutput
.
slice
(
outputIndex
))).
toContain
(
'
\
nError: Boom'
+
'
\
n at logError (app/rsc-error-log/page.js:4:16)'
+
(
isTurbopack
?
'
\
n at Page (app/rsc-error-log/page.js:11:2)'
:
// TODO(veil): Method name should be "Page"
'
\
n at logError (app/rsc-error-log/page.js:11:2)'
)
+
'
\
n 2 |'
+
'
\
n 3 | function logError() {'
+
"
\n
> 4 | const error = new Error('Boom')"
+
'
\
n | ^'
+
'
\
n 5 | console.error(error)'
+
'
\
n 6 | }'
+
'
\
n 7 |'
+
'
\
n'
)
}
else
{
}
else
{
// TODO: Test `next build` with `--enable-source-maps`.
// TODO: Test `next build` with `--enable-source-maps`.
}
}
})
})
it
(
'logged errors have a sourcemapped `cause`'
,
async
()
=>
{
it
(
'logged errors have a sourcemapped `cause`'
,
async
()
=>
{
const
outputIndex
=
next
.
cliOutput
.
length
await
next
.
render
(
'/rsc-error-log-cause'
)
await
next
.
render
(
'/rsc-error-log-cause'
)
if
(
isNextDev
)
{
if
(
isNextDev
)
{
await
retry
(()
=>
{
await
retry
(()
=>
{
expect
(
normalizeCliOutput
(
next
.
cliOutput
)).
toContain
(
expect
(
next
.
cliOutput
.
slice
(
outputIndex
)).
toContain
(
'Error: Boom'
)
'
\
nError: Boom'
+
'
\
n at logError (app/rsc-error-log-cause/page.js:2:16)'
+
(
isTurbopack
?
'
\
n at Page (app/rsc-error-log-cause/page.js:8:2)'
:
// FIXME: Method name should be "Page"
'
\
n at logError (app/rsc-error-log-cause/page.js:8:2)'
)
+
'
\
n 1 | function logError(cause) {'
+
"
\n
> 2 | const error = new Error('Boom', { cause })"
+
'
\
n | ^'
+
'
\
n 3 | console.error(error)'
+
'
\
n 4 | }'
+
'
\
n 5 | {'
+
'
\
n [cause]: Error: Boom'
+
'
\
n at Page (app/rsc-error-log-cause/page.js:7:16)'
+
'
\
n 5 |'
+
'
\
n 6 | export default function Page() {'
+
"
\n
> 7 | const error = new Error('Boom')"
+
'
\
n | ^'
+
'
\
n 8 | logError(error)'
+
'
\
n 9 | return null'
+
'
\
n 10 | }'
+
'
\
n'
)
})
})
expect
(
normalizeCliOutput
(
next
.
cliOutput
)).
toContain
(
'
\
nError: Boom'
+
'
\
n at logError (app/rsc-error-log-cause/page.js:4:16)'
+
(
isTurbopack
?
'
\
n at Page (app/rsc-error-log-cause/page.js:12:2)'
:
// FIXME: Method name should be "Page"
'
\
n at logError (app/rsc-error-log-cause/page.js:12:2)'
)
+
'
\
n 2 |'
+
'
\
n 3 | function logError(cause) {'
+
"
\n
> 4 | const error = new Error('Boom', { cause })"
+
'
\
n | ^'
+
'
\
n 5 | console.error(error)'
+
'
\
n 6 | }'
+
'
\
n 7 | {'
+
'
\
n [cause]: Error: Boom'
+
'
\
n at Page (app/rsc-error-log-cause/page.js:11:16)'
+
'
\
n 9 | await connection()'
+
'
\
n 10 |'
+
"
\n
> 11 | const error = new Error('Boom')"
+
'
\
n | ^'
+
'
\
n 12 | logError(error)'
+
'
\
n 13 | return null'
+
'
\
n 14 | }'
+
'
\
n'
)
}
else
{
}
else
{
// TODO: Test `next build` with `--enable-source-maps`.
// TODO: Test `next build` with `--enable-source-maps`.
}
}
...
@@ -91,22 +97,24 @@ describe('app-dir - server source maps', () => {
...
@@ -91,22 +97,24 @@ describe('app-dir - server source maps', () => {
;(
isTurbopack
?
it
.
skip
:
it
)(
;(
isTurbopack
?
it
.
skip
:
it
)(
'stack frames are ignore-listed in ssr'
,
'stack frames are ignore-listed in ssr'
,
async
()
=>
{
async
()
=>
{
const
outputIndex
=
next
.
cliOutput
.
length
await
next
.
render
(
'/ssr-error-log-ignore-listed'
)
await
next
.
render
(
'/ssr-error-log-ignore-listed'
)
if
(
isNextDev
)
{
if
(
isNextDev
)
{
await
retry
(()
=>
{
await
retry
(()
=>
{
expect
(
normalizeCliOutput
(
next
.
cliOutput
)).
toContain
(
expect
(
next
.
cliOutput
.
slice
(
outputIndex
)).
toContain
(
'Error: Boom'
)
isTurbopack
?
// FIXME: Turbopack resolver bug
"Module not found: Can't resolve 'internal-pkg'"
:
'
\
nError: Boom'
+
'
\
n at logError (app/ssr-error-log-ignore-listed/page.js:5:16)'
+
// FIXME: Method name should be "Page"
'
\
n at logError (app/ssr-error-log-ignore-listed/page.js:10:12)'
+
'
\
n at Page (app/ssr-error-log-ignore-listed/page.js:10:6)'
+
'
\
n 3 |'
)
})
})
expect
(
normalizeCliOutput
(
next
.
cliOutput
.
slice
(
outputIndex
))).
toContain
(
isTurbopack
?
// FIXME: Turbopack resolver bug
"Module not found: Can't resolve 'internal-pkg'"
:
'
\
nError: Boom'
+
'
\
n at logError (app/ssr-error-log-ignore-listed/page.js:5:16)'
+
// FIXME: Method name should be "Page"
'
\
n at logError (app/ssr-error-log-ignore-listed/page.js:10:12)'
+
'
\
n at Page (app/ssr-error-log-ignore-listed/page.js:10:6)'
+
'
\
n 3 |'
)
}
else
{
}
else
{
// TODO: Test `next build` with `--enable-source-maps`.
// TODO: Test `next build` with `--enable-source-maps`.
}
}
...
@@ -118,36 +126,71 @@ describe('app-dir - server source maps', () => {
...
@@ -118,36 +126,71 @@ describe('app-dir - server source maps', () => {
;(
isTurbopack
?
it
.
skip
:
it
)(
;(
isTurbopack
?
it
.
skip
:
it
)(
'stack frames are ignore-listed in rsc'
,
'stack frames are ignore-listed in rsc'
,
async
()
=>
{
async
()
=>
{
const
outputIndex
=
next
.
cliOutput
.
length
await
next
.
render
(
'/rsc-error-log-ignore-listed'
)
await
next
.
render
(
'/rsc-error-log-ignore-listed'
)
if
(
isNextDev
)
{
if
(
isNextDev
)
{
await
retry
(()
=>
{
await
retry
(()
=>
{
expect
(
normalizeCliOutput
(
next
.
cliOutput
)).
toContain
(
expect
(
isTurbopack
normalizeCliOutput
(
next
.
cliOutput
.
slice
(
outputIndex
))
?
// FIXME: Turbopack resolver bug
).
toContain
(
'Error: Boom'
)
"Module not found: Can't resolve 'internal-pkg'"
:
'
\
nError: Boom'
+
'
\
n at logError (app/rsc-error-log-ignore-listed/page.js:4:16)'
+
// FIXME: Method name should be "Page"
'
\
n at logError (app/rsc-error-log-ignore-listed/page.js:9:12)'
+
'
\
n at Page (app/rsc-error-log-ignore-listed/page.js:9:6)'
+
'
\
n 2 |'
)
})
})
expect
(
normalizeCliOutput
(
next
.
cliOutput
.
slice
(
outputIndex
))).
toContain
(
isTurbopack
?
// FIXME: Turbopack resolver bug
"Module not found: Can't resolve 'internal-pkg'"
:
'
\
nError: Boom'
+
'
\
n at logError (app/rsc-error-log-ignore-listed/page.js:5:16)'
+
// FIXME: Method name should be "Page"
'
\
n at logError (app/rsc-error-log-ignore-listed/page.js:12:12)'
+
'
\
n at Page (app/rsc-error-log-ignore-listed/page.js:12:6)'
+
'
\
n 3 |'
)
}
else
{
}
else
{
// TODO: Test `next build` with `--enable-source-maps`.
// TODO: Test `next build` with `--enable-source-maps`.
}
}
}
}
)
)
it
(
'thrown SSR errors'
,
async
()
=>
{
const
outputIndex
=
next
.
cliOutput
.
length
await
next
.
render
(
'/ssr-throw'
)
if
(
isNextDev
)
{
await
retry
(()
=>
{
expect
(
next
.
cliOutput
.
slice
(
outputIndex
)).
toContain
(
'Error: Boom'
)
})
const
cliOutput
=
stripAnsi
(
next
.
cliOutput
.
slice
(
outputIndex
))
expect
(
cliOutput
).
toContain
(
isTurbopack
?
'
\
n ⨯ Error: Boom'
+
'
\
n at throwError (./app/ssr-throw/Thrower.js:4:9)'
+
'
\
n at Thrower (./app/ssr-throw/Thrower.js:8:3)'
+
'
\
ndigest: "'
:
'
\
n ⨯ Error: Boom'
+
'
\
n at throwError (./app/ssr-throw/Thrower.js:6:11)'
+
'
\
n at Thrower (./app/ssr-throw/Thrower.js:9:5)'
+
'
\
ndigest: "'
)
expect
(
cliOutput
).
toMatch
(
/digest: "
\d
+"/
)
}
else
{
// TODO: Test `next build` with `--enable-source-maps`.
}
})
it
(
'logged errors preserve their name'
,
async
()
=>
{
it
(
'logged errors preserve their name'
,
async
()
=>
{
const
outputIndex
=
next
.
cliOutput
.
length
await
next
.
render
(
'/rsc-error-log-custom-name'
)
await
next
.
render
(
'/rsc-error-log-custom-name'
)
expect
(
next
.
cliOutput
).
toContain
(
await
retry
(()
=>
{
// TODO: isNextDev ? 'UnnamedError: Foo' : '[Error]: Foo'
expect
(
next
.
cliOutput
.
slice
(
outputIndex
)).
toContain
(
isNextDev
?
'Error: Foo'
:
'Error: Foo'
// TODO: isNextDev ? 'UnnamedError: Foo' : '[Error]: Foo'
)
isNextDev
?
'Error: Foo'
:
'Error: Foo'
expect
(
next
.
cliOutput
).
toContain
(
)
})
expect
(
next
.
cliOutput
.
slice
(
outputIndex
)).
toContain
(
// TODO: isNextDev ? 'NamedError [MyError]: Bar' : '[MyError]: Bar'
// TODO: isNextDev ? 'NamedError [MyError]: Bar' : '[MyError]: Bar'
isNextDev
?
'Error [MyError]: Bar'
:
'Error [MyError]: Bar'
isNextDev
?
'Error [MyError]: Bar'
:
'Error [MyError]: Bar'
)
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment