Unverified Commit 31453fa2 authored by Jiachi Liu's avatar Jiachi Liu Committed by GitHub

Lock node version to 18.16 (#52894)

As we're using nodejs with latest version of 18.x on CI, there's a new behavior change of `url.fileURLToPath` that didn't join the paths as expected

locally with node 16.x or 18.16
```
/private/var/folders/mh/y8kwzkls6v3_w3_k6q384cw80000gn/T/next-install-b033b516612809c6fb0a0de77c6e50f7d7f8af34dfd3d01812b99345352dc992/node_modules/.pnpm/file+..+next-repo-7e52b07043e986127273a2d951e5c412b0dd45fb24eb34001bd372e2afff79db+packages+n_vyqu6i4c4i3efp5pqsaeaoe5s4/node_modules/next/dist/compiled/@vercel/og/noto-sans-v27-latin-regular.ttf
```

in the actions runner with node 18.17 it's
```
/tmp/next-install-8efaa47c1546bed07990d8f130decceb6536e1a36146e7885cb68e3c3dea21f7/node_modules/.pnpm/file+..+next-repo-9679355e05341947e7aa0b42c994e3ac_krcuriy4thl7zawouf7sswlrgy/node_modules/next/dist/compiled/@vercel/og/index.node.js/../noto-sans-v27-latin-regular.ttf
```

You can see that `index.node.js` is still present in the path as a folder which is unexpected
```
index.node.js/../
```

x-ref: https://github.com/vercel/next.js/actions/runs/5600417148/jobs/10242827739?pr=52790
parent 55fdfe42
...@@ -11,7 +11,7 @@ RUN apt install unzip wget curl nano htop screen build-essential pkg-config libs ...@@ -11,7 +11,7 @@ RUN apt install unzip wget curl nano htop screen build-essential pkg-config libs
RUN ln $(which python3) /usr/bin/python RUN ln $(which python3) /usr/bin/python
RUN curl -sfLS https://install-node.vercel.app/v18 | bash -s -- -f RUN curl -sfLS https://install-node.vercel.app/v18.16.1 | bash -s -- -f
# Install node_modules # Install node_modules
RUN npm i -g pnpm@7.24.3 yarn@1.22.19 RUN npm i -g pnpm@7.24.3 yarn@1.22.19
......
...@@ -10,7 +10,7 @@ env: ...@@ -10,7 +10,7 @@ env:
TURBO_VERSION: 1.9.6 TURBO_VERSION: 1.9.6
PNPM_VERSION: 7.24.3 PNPM_VERSION: 7.24.3
NODE_MAINTENANCE_VERSION: 16 NODE_MAINTENANCE_VERSION: 16
NODE_LTS_VERSION: 18 NODE_LTS_VERSION: 18.16.1
jobs: jobs:
build: build:
......
...@@ -11,7 +11,7 @@ env: ...@@ -11,7 +11,7 @@ env:
TURBO_VERSION: 1.9.6 TURBO_VERSION: 1.9.6
PNPM_VERSION: 7.24.3 PNPM_VERSION: 7.24.3
NODE_MAINTENANCE_VERSION: 16 NODE_MAINTENANCE_VERSION: 16
NODE_LTS_VERSION: 18 NODE_LTS_VERSION: 18.16.1
TEST_CONCURRENCY: 6 TEST_CONCURRENCY: 6
# disable backtrace for test snapshots # disable backtrace for test snapshots
RUST_BACKTRACE: 0 RUST_BACKTRACE: 0
......
...@@ -55,7 +55,7 @@ env: ...@@ -55,7 +55,7 @@ env:
TURBO_VERSION: 1.9.6 TURBO_VERSION: 1.9.6
PNPM_VERSION: 7.24.3 PNPM_VERSION: 7.24.3
NODE_MAINTENANCE_VERSION: 16 NODE_MAINTENANCE_VERSION: 16
NODE_LTS_VERSION: 18 NODE_LTS_VERSION: 18.16.1
TEST_CONCURRENCY: 6 TEST_CONCURRENCY: 6
# disable backtrace for test snapshots # disable backtrace for test snapshots
RUST_BACKTRACE: 0 RUST_BACKTRACE: 0
......
...@@ -9,7 +9,7 @@ env: ...@@ -9,7 +9,7 @@ env:
TURBO_VERSION: 1.9.6 TURBO_VERSION: 1.9.6
PNPM_VERSION: 7.24.3 PNPM_VERSION: 7.24.3
NODE_MAINTENANCE_VERSION: 16 NODE_MAINTENANCE_VERSION: 16
NODE_LTS_VERSION: 18 NODE_LTS_VERSION: 18.16.1
TEST_CONCURRENCY: 6 TEST_CONCURRENCY: 6
TURBO_TEAM: 'vercel' TURBO_TEAM: 'vercel'
......
...@@ -28,7 +28,7 @@ env: ...@@ -28,7 +28,7 @@ env:
TURBO_VERSION: 1.9.6 TURBO_VERSION: 1.9.6
PNPM_VERSION: 7.24.3 PNPM_VERSION: 7.24.3
NODE_MAINTENANCE_VERSION: 16 NODE_MAINTENANCE_VERSION: 16
NODE_LTS_VERSION: 18 NODE_LTS_VERSION: 18.16.1
jobs: jobs:
start: start:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment