Unverified Commit 31dddcaa authored by Tobias Koppers's avatar Tobias Koppers Committed by GitHub

Turbopack: reenable some skipped test cases (#57177)

### What?

### Why?

better CI coverage

### How?



Closes WEB-1820
parent 488a61fd
...@@ -58,12 +58,6 @@ const SKIPPED_TEST_SUITES = { ...@@ -58,12 +58,6 @@ const SKIPPED_TEST_SUITES = {
'test/integration/app-document-remove-hmr/test/index.test.js': [ 'test/integration/app-document-remove-hmr/test/index.test.js': [
'_app removal HMR should HMR when _document is removed', '_app removal HMR should HMR when _document is removed',
], ],
'test/integration/create-next-app/package-manager.test.ts': [
'should use pnpm as the package manager on supplying --use-pnpm',
'should use pnpm as the package manager on supplying --use-pnpm with example',
'should infer pnpm as the package manager',
'should infer pnpm as the package manager with example',
],
'test/integration/css/test/css-modules.test.js': [ 'test/integration/css/test/css-modules.test.js': [
'CSS Modules Composes Ordering Development Mode should have correct color on index page (on nav from other)', 'CSS Modules Composes Ordering Development Mode should have correct color on index page (on nav from other)',
'CSS Modules Composes Ordering Development Mode should have correct color on index page (on nav from index)', 'CSS Modules Composes Ordering Development Mode should have correct color on index page (on nav from index)',
...@@ -80,10 +74,6 @@ const SKIPPED_TEST_SUITES = { ...@@ -80,10 +74,6 @@ const SKIPPED_TEST_SUITES = {
'test/integration/import-assertion/test/index.test.js': [ 'test/integration/import-assertion/test/index.test.js': [
/should handle json assertions/, /should handle json assertions/,
], ],
'test/integration/trailing-slashes/test/index.test.js': [
'Trailing slashes dev mode, with basepath, trailingSlash: true /docs/linker?href=/ should navigate to /docs/',
'Trailing slashes dev mode, with basepath, trailingSlash: true /docs/linker?href=/ should push route to /docs/',
],
'test/integration/env-config/test/index.test.js': [ 'test/integration/env-config/test/index.test.js': [
'Env Config dev mode with hot reload should provide env for SSG', 'Env Config dev mode with hot reload should provide env for SSG',
'Env Config dev mode with hot reload should provide env correctly for SSR', 'Env Config dev mode with hot reload should provide env correctly for SSR',
...@@ -116,6 +106,8 @@ async function updatePassingTests() { ...@@ -116,6 +106,8 @@ async function updatePassingTests() {
}) })
const skips = SKIPPED_TEST_SUITES[filepath] ?? [] const skips = SKIPPED_TEST_SUITES[filepath] ?? []
const skippedPassingNames = []
let initializationFailed = false let initializationFailed = false
for (const testCase of testResult.assertionResults) { for (const testCase of testResult.assertionResults) {
let { fullName, status } = testCase let { fullName, status } = testCase
...@@ -129,6 +121,7 @@ async function updatePassingTests() { ...@@ -129,6 +121,7 @@ async function updatePassingTests() {
status = 'failed' status = 'failed'
} }
if (shouldSkip(fullName, skips)) { if (shouldSkip(fullName, skips)) {
if (status === 'passed') skippedPassingNames.push(fullName)
status = 'flakey' status = 'flakey'
} }
...@@ -138,6 +131,18 @@ async function updatePassingTests() { ...@@ -138,6 +131,18 @@ async function updatePassingTests() {
} }
statusArray.push(fullName) statusArray.push(fullName)
} }
if (skippedPassingNames.length > 0) {
console.log(
`${filepath} has ${
skippedPassingNames.length
} passing tests that are marked as skipped: ${JSON.stringify(
skippedPassingNames,
0,
2
)}`
)
}
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment