Unverified Commit 332720a3 authored by Will Binns-Smith's avatar Will Binns-Smith Committed by GitHub

Always respect NEXT_TRACE_UPLOAD_DISABLED (#61402)

Closes PACK-2326
parent 9c35f21f
...@@ -205,7 +205,10 @@ const nextDev: CliCommand = async (args) => { ...@@ -205,7 +205,10 @@ const nextDev: CliCommand = async (args) => {
const isExperimentalTestProxy = args['--experimental-test-proxy'] const isExperimentalTestProxy = args['--experimental-test-proxy']
if (args['--experimental-upload-trace']) { if (
args['--experimental-upload-trace'] &&
!process.env.NEXT_TRACE_UPLOAD_DISABLED
) {
traceUploadUrl = args['--experimental-upload-trace'] traceUploadUrl = args['--experimental-upload-trace']
} }
...@@ -292,7 +295,7 @@ const nextDev: CliCommand = async (args) => { ...@@ -292,7 +295,7 @@ const nextDev: CliCommand = async (args) => {
// Starting the dev server will overwrite the `.next/trace` file, so we // Starting the dev server will overwrite the `.next/trace` file, so we
// must upload the existing contents before restarting the server to // must upload the existing contents before restarting the server to
// preserve the metrics. // preserve the metrics.
if (traceUploadUrl && !process.env.NEXT_TRACE_UPLOAD_DISABLED) { if (traceUploadUrl) {
uploadTrace({ uploadTrace({
traceUploadUrl, traceUploadUrl,
mode: 'dev', mode: 'dev',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment