Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
3352f9ee
Unverified
Commit
3352f9ee
authored
Dec 17, 2025
by
Hendrik Liebau
Committed by
GitHub
Dec 17, 2025
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[test] Don't use `request.allHeaders()` in sync `page.on()` callbacks (#86751)
parent
d36c03ed
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
26 deletions
+11
-26
index.test.ts
test/e2e/app-dir/app-basepath/index.test.ts
+3
-16
index.test.ts
test/e2e/switchable-runtime/index.test.ts
+8
-10
No files found.
test/e2e/app-dir/app-basepath/index.test.ts
View file @
3352f9ee
...
@@ -75,22 +75,8 @@ describe('app dir - basepath', () => {
...
@@ -75,22 +75,8 @@ describe('app dir - basepath', () => {
let
rscRequests
=
[]
let
rscRequests
=
[]
const
browser
=
await
next
.
browser
(
path
,
{
const
browser
=
await
next
.
browser
(
path
,
{
beforePageLoad
(
page
)
{
beforePageLoad
(
page
)
{
page
.
on
(
'request'
,
async
(
request
)
=>
{
page
.
on
(
'request'
,
(
request
)
=>
{
let
headers
:
{
[
key
:
string
]:
string
}
const
headers
=
request
.
headers
()
try
{
headers
=
await
request
.
allHeaders
()
}
catch
(
e
)
{
if
(
e
.
message
.
includes
(
'Target page, context or browser has been closed'
)
)
{
// Ignore errors caused by closed browser during test teardown
return
}
throw
e
}
if
(
if
(
headers
[
'rsc'
]
===
'1'
&&
headers
[
'rsc'
]
===
'1'
&&
// Prefetches also include `rsc`
// Prefetches also include `rsc`
...
@@ -103,6 +89,7 @@ describe('app dir - basepath', () => {
...
@@ -103,6 +89,7 @@ describe('app dir - basepath', () => {
})
})
await
browser
.
elementByCss
(
'button'
).
click
()
await
browser
.
elementByCss
(
'button'
).
click
()
await
browser
.
waitForIdleNetwork
()
await
retry
(
async
()
=>
{
await
retry
(
async
()
=>
{
expect
(
rscRequests
).
toEqual
([
expect
(
rscRequests
).
toEqual
([
expect
.
stringContaining
(
`
${
next
.
url
}${
path
}
`
),
expect
.
stringContaining
(
`
${
next
.
url
}${
path
}
`
),
...
...
test/e2e/switchable-runtime/index.test.ts
View file @
3352f9ee
...
@@ -107,11 +107,10 @@ describe('Switchable runtime', () => {
...
@@ -107,11 +107,10 @@ describe('Switchable runtime', () => {
const
browser
=
await
webdriver
(
context
.
appPort
,
'/node'
,
{
const
browser
=
await
webdriver
(
context
.
appPort
,
'/node'
,
{
beforePageLoad
(
page
)
{
beforePageLoad
(
page
)
{
page
.
on
(
'request'
,
(
request
)
=>
{
page
.
on
(
'request'
,
(
request
)
=>
{
return
request
.
allHeaders
().
then
((
headers
)
=>
{
const
headers
=
request
.
headers
()
if
(
headers
[
'rsc'
]
===
'1'
)
{
if
(
headers
[
'rsc'
]
===
'1'
)
{
flightRequest
=
request
.
url
()
flightRequest
=
request
.
url
()
}
}
})
})
})
},
},
})
})
...
@@ -639,11 +638,10 @@ describe('Switchable runtime', () => {
...
@@ -639,11 +638,10 @@ describe('Switchable runtime', () => {
const
browser
=
await
webdriver
(
context
.
appPort
,
'/node'
,
{
const
browser
=
await
webdriver
(
context
.
appPort
,
'/node'
,
{
beforePageLoad
(
page
)
{
beforePageLoad
(
page
)
{
page
.
on
(
'request'
,
(
request
)
=>
{
page
.
on
(
'request'
,
(
request
)
=>
{
request
.
allHeaders
().
then
((
headers
)
=>
{
const
headers
=
request
.
headers
()
if
(
headers
[
'rsc'
]
===
'1'
)
{
if
(
headers
[
'rsc'
]
===
'1'
)
{
flightRequest
=
request
.
url
()
flightRequest
=
request
.
url
()
}
}
})
})
})
},
},
})
})
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment