Commit 3898cb53 authored by Arunoda Susiripala's avatar Arunoda Susiripala Committed by GitHub

Make sure page-loader doesn't throw errors when registering. (#2282)

Even if it does it, we need to mark it as a page error.
parent db1ee2e1
...@@ -87,9 +87,14 @@ export default class PageLoader { ...@@ -87,9 +87,14 @@ export default class PageLoader {
// This method if called by the route code. // This method if called by the route code.
registerPage (route, regFn) { registerPage (route, regFn) {
const register = () => { const register = () => {
const { error, page } = regFn() try {
this.pageCache[route] = { error, page } const { error, page } = regFn()
this.pageRegisterEvents.emit(route, { error, page }) this.pageCache[route] = { error, page }
this.pageRegisterEvents.emit(route, { error, page })
} catch (error) {
this.pageCache[route] = { error }
this.pageRegisterEvents.emit(route, { error })
}
} }
// Wait for webpack to became idle if it's not. // Wait for webpack to became idle if it's not.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment