Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
39f30fbd
Unverified
Commit
39f30fbd
authored
Dec 20, 2022
by
Hannes Bornö
Committed by
GitHub
Dec 20, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove browser.refresh in app tests (#44186)
parent
66408466
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
26 deletions
+8
-26
ReactRefreshRegression.test.ts
...development/acceptance-app/ReactRefreshRegression.test.ts
+5
-14
server-components.test.ts
test/development/acceptance-app/server-components.test.ts
+3
-12
No files found.
test/development/acceptance-app/ReactRefreshRegression.test.ts
View file @
39f30fbd
...
@@ -145,8 +145,7 @@ describe('ReactRefreshRegression app', () => {
...
@@ -145,8 +145,7 @@ describe('ReactRefreshRegression app', () => {
})
})
// https://github.com/vercel/next.js/issues/13978
// https://github.com/vercel/next.js/issues/13978
// TODO-APP: fix case where server component is moved to a client component
test
(
'can fast refresh a page with dynamic rendering'
,
async
()
=>
{
test
.
skip
(
'can fast refresh a page with dynamic rendering'
,
async
()
=>
{
const
{
session
,
cleanup
}
=
await
sandbox
(
next
)
const
{
session
,
cleanup
}
=
await
sandbox
(
next
)
await
session
.
patch
(
await
session
.
patch
(
...
@@ -216,8 +215,7 @@ describe('ReactRefreshRegression app', () => {
...
@@ -216,8 +215,7 @@ describe('ReactRefreshRegression app', () => {
})
})
// https://github.com/vercel/next.js/issues/13978
// https://github.com/vercel/next.js/issues/13978
// TODO-APP: fix case where server component is moved to a client component
test
(
'can fast refresh a page with config'
,
async
()
=>
{
test
.
skip
(
'can fast refresh a page with config'
,
async
()
=>
{
const
{
session
,
cleanup
}
=
await
sandbox
(
next
)
const
{
session
,
cleanup
}
=
await
sandbox
(
next
)
await
session
.
patch
(
await
session
.
patch
(
...
@@ -264,17 +262,14 @@ describe('ReactRefreshRegression app', () => {
...
@@ -264,17 +262,14 @@ describe('ReactRefreshRegression app', () => {
})
})
// https://github.com/vercel/next.js/issues/11504
// https://github.com/vercel/next.js/issues/11504
// TODO-APP: fix case where error is not resolved to source correctly.
test
(
'shows an overlay for anonymous function server-side error'
,
async
()
=>
{
test
(
'shows an overlay for anonymous function server-side error'
,
async
()
=>
{
const
{
session
,
browser
,
cleanup
}
=
await
sandbox
(
next
)
const
{
session
,
cleanup
}
=
await
sandbox
(
next
)
await
session
.
patch
(
await
session
.
patch
(
'app/page.js'
,
'app/page.js'
,
`export default function () { throw new Error('boom'); }`
`export default function () { throw new Error('boom'); }`
)
)
await
browser
.
refresh
()
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
const
source
=
await
session
.
getRedboxSource
()
const
source
=
await
session
.
getRedboxSource
()
...
@@ -287,15 +282,13 @@ describe('ReactRefreshRegression app', () => {
...
@@ -287,15 +282,13 @@ describe('ReactRefreshRegression app', () => {
})
})
test
(
'shows an overlay for server-side error in server component'
,
async
()
=>
{
test
(
'shows an overlay for server-side error in server component'
,
async
()
=>
{
const
{
session
,
browser
,
cleanup
}
=
await
sandbox
(
next
)
const
{
session
,
cleanup
}
=
await
sandbox
(
next
)
await
session
.
patch
(
await
session
.
patch
(
'app/page.js'
,
'app/page.js'
,
`export default function Page() { throw new Error('boom'); }`
`export default function Page() { throw new Error('boom'); }`
)
)
await
browser
.
refresh
()
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
const
source
=
await
session
.
getRedboxSource
()
const
source
=
await
session
.
getRedboxSource
()
...
@@ -308,7 +301,7 @@ describe('ReactRefreshRegression app', () => {
...
@@ -308,7 +301,7 @@ describe('ReactRefreshRegression app', () => {
})
})
test
(
'shows an overlay for server-side error in client component'
,
async
()
=>
{
test
(
'shows an overlay for server-side error in client component'
,
async
()
=>
{
const
{
session
,
browser
,
cleanup
}
=
await
sandbox
(
next
)
const
{
session
,
cleanup
}
=
await
sandbox
(
next
)
await
session
.
patch
(
await
session
.
patch
(
'app/page.js'
,
'app/page.js'
,
...
@@ -316,8 +309,6 @@ describe('ReactRefreshRegression app', () => {
...
@@ -316,8 +309,6 @@ describe('ReactRefreshRegression app', () => {
export default function Page() { throw new Error('boom'); }`
export default function Page() { throw new Error('boom'); }`
)
)
await
browser
.
refresh
()
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
const
source
=
await
session
.
getRedboxSource
()
const
source
=
await
session
.
getRedboxSource
()
...
...
test/development/acceptance-app/server-components.test.ts
View file @
39f30fbd
...
@@ -22,7 +22,7 @@ describe('Error Overlay for server components', () => {
...
@@ -22,7 +22,7 @@ describe('Error Overlay for server components', () => {
describe
(
'createContext called in Server Component'
,
()
=>
{
describe
(
'createContext called in Server Component'
,
()
=>
{
it
(
'should show error when React.createContext is called'
,
async
()
=>
{
it
(
'should show error when React.createContext is called'
,
async
()
=>
{
const
{
session
,
browser
,
cleanup
}
=
await
sandbox
(
const
{
session
,
cleanup
}
=
await
sandbox
(
next
,
next
,
new
Map
([
new
Map
([
[
[
...
@@ -43,9 +43,6 @@ describe('Error Overlay for server components', () => {
...
@@ -43,9 +43,6 @@ describe('Error Overlay for server components', () => {
])
])
)
)
// TODO-APP: currently requires a full reload because moving from a client component to a server component isn't causing a Fast Refresh yet.
await
browser
.
refresh
()
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
await
check
(
async
()
=>
{
await
check
(
async
()
=>
{
expect
(
await
session
.
getRedboxSource
(
true
)).
toContain
(
expect
(
await
session
.
getRedboxSource
(
true
)).
toContain
(
...
@@ -61,7 +58,7 @@ describe('Error Overlay for server components', () => {
...
@@ -61,7 +58,7 @@ describe('Error Overlay for server components', () => {
})
})
it
(
'should show error when React.createContext is called in external package'
,
async
()
=>
{
it
(
'should show error when React.createContext is called in external package'
,
async
()
=>
{
const
{
session
,
browser
,
cleanup
}
=
await
sandbox
(
const
{
session
,
cleanup
}
=
await
sandbox
(
next
,
next
,
new
Map
([
new
Map
([
[
[
...
@@ -97,9 +94,6 @@ describe('Error Overlay for server components', () => {
...
@@ -97,9 +94,6 @@ describe('Error Overlay for server components', () => {
])
])
)
)
// TODO-APP: currently requires a full reload because moving from a client component to a server component isn't causing a Fast Refresh yet.
await
browser
.
refresh
()
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
await
check
(
async
()
=>
{
await
check
(
async
()
=>
{
...
@@ -117,7 +111,7 @@ describe('Error Overlay for server components', () => {
...
@@ -117,7 +111,7 @@ describe('Error Overlay for server components', () => {
})
})
it
(
'should show error when createContext is called in external package'
,
async
()
=>
{
it
(
'should show error when createContext is called in external package'
,
async
()
=>
{
const
{
session
,
browser
,
cleanup
}
=
await
sandbox
(
const
{
session
,
cleanup
}
=
await
sandbox
(
next
,
next
,
new
Map
([
new
Map
([
[
[
...
@@ -153,9 +147,6 @@ describe('Error Overlay for server components', () => {
...
@@ -153,9 +147,6 @@ describe('Error Overlay for server components', () => {
])
])
)
)
// TODO-APP: currently requires a full reload because moving from a client component to a server component isn't causing a Fast Refresh yet.
await
browser
.
refresh
()
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
expect
(
await
session
.
hasRedbox
(
true
)).
toBe
(
true
)
await
check
(
async
()
=>
{
await
check
(
async
()
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment