Unverified Commit 3a50598b authored by Tim Neutkens's avatar Tim Neutkens Committed by GitHub

Enable test/integration for TURBOPACK_BUILD (#63679)

## What?

Enables Turbopack build tests for `test/integration`. Follow-up to
#63671

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->


Closes NEXT-2918
parent b0843fea
...@@ -97,50 +97,50 @@ jobs: ...@@ -97,50 +97,50 @@ jobs:
test/turbopack-test-junit-report test/turbopack-test-junit-report
# TODO: Implement specifically running production tests only for Turbopack. Enabling this now enables running `test/integration` with development mode too. # TODO: Implement specifically running production tests only for Turbopack. Enabling this now enables running `test/integration` with development mode too.
# test-integration-production: test-integration-production:
# name: Next.js production integration test (Integration) name: Next.js production integration test (Integration)
# needs: [setup_nextjs] needs: [setup_nextjs]
# runs-on: runs-on:
# - 'self-hosted' - 'self-hosted'
# - 'linux' - 'linux'
# - 'x64' - 'x64'
# - 'metal' - 'metal'
# timeout-minutes: 180 timeout-minutes: 180
# strategy: strategy:
# fail-fast: false fail-fast: false
# matrix: matrix:
# group: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12] group: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12]
# steps: steps:
# - uses: actions/cache/restore@v3 - uses: actions/cache/restore@v3
# id: restore-build id: restore-build
# with: with:
# path: ./* path: ./*
# key: ${{ inputs.version }}-${{ github.sha }} key: ${{ inputs.version }}-${{ github.sha }}
# fail-on-cache-miss: true fail-on-cache-miss: true
# - name: Enable corepack and install yarn - name: Enable corepack and install yarn
# run: | run: |
# corepack enable corepack enable
# corepack prepare --activate yarn@1.22.19 corepack prepare --activate yarn@1.22.19
# - name: Setup playwright - name: Setup playwright
# run: | run: |
# pnpm playwright install pnpm playwright install
# - name: Run test/integration - name: Run test/integration
# run: | run: |
# TURBOPACK=1 TURBOPACK_BUILD=1 node run-tests.js -g ${{ matrix.group }}/12 -c ${TEST_CONCURRENCY} --type integration TURBOPACK=1 TURBOPACK_BUILD=1 node run-tests.js -g ${{ matrix.group }}/12 -c ${TEST_CONCURRENCY} --type integration
# continue-on-error: true continue-on-error: true
# - name: Upload test report artifacts - name: Upload test report artifacts
# uses: actions/upload-artifact@v4 uses: actions/upload-artifact@v4
# with: with:
# name: test-reports-build-integration-${{ matrix.group }} name: test-reports-build-integration-${{ matrix.group }}
# if-no-files-found: 'error' if-no-files-found: 'error'
# path: | path: |
# test/turbopack-test-junit-report test/turbopack-test-junit-report
# Collect integration test results from execute_tests, # Collect integration test results from execute_tests,
# Store it as github artifact for next step to consume. # Store it as github artifact for next step to consume.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment