Unverified Commit 406c9961 authored by Ludovico Fischer's avatar Ludovico Fischer Committed by GitHub

fix: bump node-sass peer dependency (#21084)

Get rid of the unmet peer dependency warning when installing
a next.js project wtih node-sass 5.

node-sass 5 is the currently maintained version and removes
support one deprecated API and Node.js versions that Next.js does
not support either. Next.js uses node-sass 5 in devDependencies.

node-sass changelog: https://github.com/sass/node-sass/releases

On the other hand, as the docs encourage the sass package instead of node-sass,
(see errors/duplicate-sass.md)
I have updated examples which used node-sass 4 to the latest sass instead.
parent bddb0228
...@@ -15,7 +15,7 @@ ...@@ -15,7 +15,7 @@
"carbon-components-react": "^7.3.0", "carbon-components-react": "^7.3.0",
"carbon-icons": "^7.0.7", "carbon-icons": "^7.0.7",
"next": "latest", "next": "latest",
"node-sass": "^4.12.0", "sass": "^1.32.4",
"react": "^16.7.0", "react": "^16.7.0",
"react-dom": "^16.7.0" "react-dom": "^16.7.0"
} }
......
...@@ -17,7 +17,7 @@ ...@@ -17,7 +17,7 @@
"devDependencies": { "devDependencies": {
"@types/node": "^14.0.27", "@types/node": "^14.0.27",
"@types/react": "^16.9.43", "@types/react": "^16.9.43",
"node-sass": "^4.14.1", "sass": "^1.32.4",
"typescript": "^3.9.7" "typescript": "^3.9.7"
} }
} }
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
}, },
"dependencies": { "dependencies": {
"next": "^10.0.0", "next": "^10.0.0",
"node-sass": "^4.14.1", "sass": "^1.32.4",
"react": "17.0.1", "react": "17.0.1",
"react-dom": "17.0.1", "react-dom": "17.0.1",
"styled-jsx-plugin-sass": "^1.0.0" "styled-jsx-plugin-sass": "^1.0.0"
......
...@@ -8,10 +8,10 @@ ...@@ -8,10 +8,10 @@
}, },
"dependencies": { "dependencies": {
"next": "latest", "next": "latest",
"node-sass": "4.5.3", "sass": "1.32.4",
"react": "^16.7.0", "react": "^16.7.0",
"react-dom": "^16.7.0", "react-dom": "^16.7.0",
"styled-jsx-plugin-sass": "0.2.0" "styled-jsx-plugin-sass": "1.0.0"
}, },
"license": "MIT" "license": "MIT"
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment