Unverified Commit 432a1dec authored by Joseph Knowles's avatar Joseph Knowles Committed by GitHub

Fix with-firebase-authentication example: Update the cookie when ID token…

Fix with-firebase-authentication example: Update the cookie when ID token refreshes on client (#15628)

I noticed a problem with the example - when you leave it logged in for more than an hour it breaks. The example API call starts to fail with `auth/id-token-expired`.

Looking at the code I saw that we never update the id token after signing in, but firebase automatically updates it every hour, meaning our `verifyIdToken` fails after an hour. 

So I used the `onIdTokenChanged` function from firebase to update the cookie every time the id token changes.

I'm open to suggestions on refactoring the code I've added.
parent 669cad97
...@@ -3,8 +3,9 @@ import { useEffect, useState } from 'react' ...@@ -3,8 +3,9 @@ import { useEffect, useState } from 'react'
import StyledFirebaseAuth from 'react-firebaseui/StyledFirebaseAuth' import StyledFirebaseAuth from 'react-firebaseui/StyledFirebaseAuth'
import firebase from 'firebase/app' import firebase from 'firebase/app'
import 'firebase/auth' import 'firebase/auth'
import cookie from 'js-cookie'
import initFirebase from '../utils/auth/initFirebase' import initFirebase from '../utils/auth/initFirebase'
import { setUserCookie } from '../utils/auth/userCookies'
import { mapUserData } from '../utils/auth/mapUserData'
// Init the Firebase app. // Init the Firebase app.
initFirebase() initFirebase()
...@@ -23,17 +24,8 @@ const firebaseAuthConfig = { ...@@ -23,17 +24,8 @@ const firebaseAuthConfig = {
credentialHelper: 'none', credentialHelper: 'none',
callbacks: { callbacks: {
signInSuccessWithAuthResult: async ({ user }, redirectUrl) => { signInSuccessWithAuthResult: async ({ user }, redirectUrl) => {
// xa is the access token, which can be retrieved through const userData = mapUserData(user)
// firebase.auth().currentUser.getIdToken() setUserCookie(userData)
const { uid, email, xa } = user
const userData = {
id: uid,
email,
token: xa,
}
cookie.set('auth', userData, {
expires: 1,
})
}, },
}, },
} }
......
...@@ -51,7 +51,7 @@ const Index = () => { ...@@ -51,7 +51,7 @@ const Index = () => {
</Link> </Link>
</div> </div>
{error && <div>Failed to fetch food!</div>} {error && <div>Failed to fetch food!</div>}
{data ? ( {data && !error ? (
<div>Your favorite food is {data.food}.</div> <div>Your favorite food is {data.food}.</div>
) : ( ) : (
<div>Loading...</div> <div>Loading...</div>
......
export const mapUserData = (user) => {
const { uid, email, xa } = user
return {
id: uid,
email,
token: xa,
}
}
import { useEffect, useState } from 'react' import { useEffect, useState } from 'react'
import { useRouter } from 'next/router' import { useRouter } from 'next/router'
import cookies from 'js-cookie'
import firebase from 'firebase/app' import firebase from 'firebase/app'
import 'firebase/auth' import 'firebase/auth'
import initFirebase from '../auth/initFirebase' import initFirebase from '../auth/initFirebase'
import {
removeUserCookie,
setUserCookie,
getUserFromCookie,
} from './userCookies'
import { mapUserData } from './mapUserData'
initFirebase() initFirebase()
...@@ -17,8 +22,6 @@ const useUser = () => { ...@@ -17,8 +22,6 @@ const useUser = () => {
.signOut() .signOut()
.then(() => { .then(() => {
// Sign-out successful. // Sign-out successful.
cookies.remove('auth')
setUser()
router.push('/auth') router.push('/auth')
}) })
.catch((e) => { .catch((e) => {
...@@ -27,12 +30,26 @@ const useUser = () => { ...@@ -27,12 +30,26 @@ const useUser = () => {
} }
useEffect(() => { useEffect(() => {
const cookie = cookies.get('auth') // Firebase updates the id token every hour, this
if (!cookie) { // makes sure the react state and the cookie are
// both kept up to date
firebase.auth().onIdTokenChanged((user) => {
if (user) {
const userData = mapUserData(user)
setUserCookie(userData)
setUser(userData)
} else {
removeUserCookie()
setUser()
}
})
const userFromCookie = getUserFromCookie()
if (!userFromCookie) {
router.push('/') router.push('/')
return return
} }
setUser(JSON.parse(cookie)) setUser(userFromCookie)
// eslint-disable-next-line react-hooks/exhaustive-deps // eslint-disable-next-line react-hooks/exhaustive-deps
}, []) }, [])
......
import cookies from 'js-cookie'
export const getUserFromCookie = () => {
const cookie = cookies.get('auth')
if (!cookie) {
return
}
return JSON.parse(cookie)
}
export const setUserCookie = (user) => {
cookies.set('auth', user, {
// firebase id tokens expire in one hour
// set cookie expiry to match
expires: 1 / 24,
})
}
export const removeUserCookie = () => cookies.remove('auth')
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment