Unverified Commit 4abf9cab authored by Syed Sohail Hussain's avatar Syed Sohail Hussain Committed by GitHub

test: fix 'ouput' typo in parseIdsFromCliOutput (#97266)

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

We encourage you to use AI to assist you in researching, creating, and
reviewing changes. However, you must review and deeply understand the
contributions you are making. For this reason, **pull request
descriptions from external contributors must be written by a human**.

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Signed commits

- This repository requires verified commit signatures on protected
branches.
- If this pull request is blocked for unsigned commits, re-sign the
commits and force-push the branch.
- A `Signed-off-by` line in the commit message is not enough.

## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
parent 52a3410d
...@@ -172,7 +172,7 @@ export class NextDeployInstance extends NextInstance { ...@@ -172,7 +172,7 @@ export class NextDeployInstance extends NextInstance {
} }
} }
private parseIdsFromCliOuput(): void { private parseIdsFromCliOutput(): void {
const buildId = this._cliOutput.match(/BUILD_ID: (.+)/)?.[1]?.trim() const buildId = this._cliOutput.match(/BUILD_ID: (.+)/)?.[1]?.trim()
if (!buildId) { if (!buildId) {
throw new Error(`Failed to get buildId from logs ${this._cliOutput}`) throw new Error(`Failed to get buildId from logs ${this._cliOutput}`)
...@@ -245,7 +245,7 @@ export class NextDeployInstance extends NextInstance { ...@@ -245,7 +245,7 @@ export class NextDeployInstance extends NextInstance {
} }
// The markers never appeared within the retry window; return the last // The markers never appeared within the retry window; return the last
// output so `parseIdsFromCliOuput` throws a descriptive error including it. // output so `parseIdsFromCliOutput` throws a descriptive error including it.
return output return output
} }
...@@ -299,7 +299,7 @@ export class NextDeployInstance extends NextInstance { ...@@ -299,7 +299,7 @@ export class NextDeployInstance extends NextInstance {
this._cliOutput = buildLogs.stdout + buildLogs.stderr this._cliOutput = buildLogs.stdout + buildLogs.stderr
} }
this.parseIdsFromCliOuput() this.parseIdsFromCliOutput()
return return
} }
...@@ -323,7 +323,7 @@ export class NextDeployInstance extends NextInstance { ...@@ -323,7 +323,7 @@ export class NextDeployInstance extends NextInstance {
// Use the custom logs script to get build logs and extract buildId // Use the custom logs script to get build logs and extract buildId
this._cliOutput = await this.fetchBuildLogsUsingCustomScript() this._cliOutput = await this.fetchBuildLogsUsingCustomScript()
this.parseIdsFromCliOuput() this.parseIdsFromCliOutput()
return return
} }
...@@ -528,7 +528,7 @@ export class NextDeployInstance extends NextInstance { ...@@ -528,7 +528,7 @@ export class NextDeployInstance extends NextInstance {
vercelFlags vercelFlags
) )
this.parseIdsFromCliOuput() this.parseIdsFromCliOutput()
} }
// When preview builds are private, the deploy build installs Next.js // When preview builds are private, the deploy build installs Next.js
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment