Commit 4bd3849c authored by Zack Tanner's avatar Zack Tanner Committed by Janka Uryga

create-next-app: fix font file corruption when using import alias (#69806)

There's code that uses `glob` to find all template files and replaces
the default import alias with whatever is specified during CNA. This
does so without excluding fonts, and so we're unintentionally corrupting
these `woff` files.

This wasn't a problem in previous versions because we didn't use
`localFont` in the default template, just `Inter`. The files were
technically still being corrupted it just never manifested unless you
went to actually use them.

This is a quick fix to introduce minimal changes but ideally in a
follow-up we should figure out a better solution for replacing aliases,
ie by using an allowlist rather than an exclude list.

h/t to @lubieowoce for the thorough test cases

Fixes #69748

---------
Co-authored-by: 's avatarJanka Uryga <lolzatu2@gmail.com>
parent 37568010
...@@ -97,7 +97,16 @@ export const installTemplate = async ({ ...@@ -97,7 +97,16 @@ export const installTemplate = async ({
stats: false, stats: false,
// We don't want to modify compiler options in [ts/js]config.json // We don't want to modify compiler options in [ts/js]config.json
// and none of the files in the .git folder // and none of the files in the .git folder
ignore: ["tsconfig.json", "jsconfig.json", ".git/**/*"], // TODO: Refactor this to be an allowlist, rather than a denylist,
// to avoid corrupting files that weren't intended to be replaced
ignore: [
"tsconfig.json",
"jsconfig.json",
".git/**/*",
"**/fonts/**",
"**/favicon.ico",
],
}); });
const writeSema = new Sema(8, { capacity: files.length }); const writeSema = new Sema(8, { capacity: files.length });
await Promise.all( await Promise.all(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment