Unverified Commit 4c144825 authored by Dima Voytenko's avatar Dima Voytenko Committed by GitHub

[chore] Upgrade playwright to 1.35.1 (#53875)

parent c8020758
...@@ -442,7 +442,7 @@ jobs: ...@@ -442,7 +442,7 @@ jobs:
- run: RESET_VC_PROJECT=true node scripts/reset-vercel-project.mjs - run: RESET_VC_PROJECT=true node scripts/reset-vercel-project.mjs
name: Reset test project name: Reset test project
- run: docker run --rm -v $(pwd):/work mcr.microsoft.com/playwright:v1.28.1-jammy /bin/bash -c "cd /work && NODE_VERSION=${{ env.NODE_LTS_VERSION }} ./scripts/setup-node.sh && corepack enable > /dev/null && DATADOG_TRACE_NEXTJS_TEST=TRUE DATADOG_API_KEY=${DATADOG_API_KEY} DD_ENV=ci VERCEL_TEST_TOKEN=${{ secrets.VERCEL_TEST_TOKEN }} VERCEL_TEST_TEAM=vtest314-next-e2e-tests NEXT_TEST_JOB=1 NEXT_TEST_MODE=deploy TEST_TIMINGS_TOKEN=${{ secrets.TEST_TIMINGS_TOKEN }} NEXT_TEST_CONTINUE_ON_ERROR=1 xvfb-run node run-tests.js --type e2e >> /proc/1/fd/1" - run: docker run --rm -v $(pwd):/work mcr.microsoft.com/playwright:v1.35.1-jammy /bin/bash -c "cd /work && NODE_VERSION=${{ env.NODE_LTS_VERSION }} ./scripts/setup-node.sh && corepack enable > /dev/null && DATADOG_TRACE_NEXTJS_TEST=TRUE DATADOG_API_KEY=${DATADOG_API_KEY} DD_ENV=ci VERCEL_TEST_TOKEN=${{ secrets.VERCEL_TEST_TOKEN }} VERCEL_TEST_TEAM=vtest314-next-e2e-tests NEXT_TEST_JOB=1 NEXT_TEST_MODE=deploy TEST_TIMINGS_TOKEN=${{ secrets.TEST_TIMINGS_TOKEN }} NEXT_TEST_CONTINUE_ON_ERROR=1 xvfb-run node run-tests.js --type e2e >> /proc/1/fd/1"
name: Run test/e2e (deploy) name: Run test/e2e (deploy)
- name: Upload test trace - name: Upload test trace
......
...@@ -44,5 +44,5 @@ jobs: ...@@ -44,5 +44,5 @@ jobs:
- run: pnpm install - run: pnpm install
- run: pnpm build - run: pnpm build
- run: docker run --rm -v $(pwd):/work mcr.microsoft.com/playwright:v1.28.1-focal /bin/bash -c "cd /work && curl -s https://install-node.vercel.app/v${{ matrix.node }} | FORCE=1 bash && node -v && corepack enable > /dev/null && NEXT_TEST_JOB=1 NEXT_TEST_MODE=start xvfb-run node run-tests.js --type examples >> /proc/1/fd/1" - run: docker run --rm -v $(pwd):/work mcr.microsoft.com/playwright:v1.35.1-focal /bin/bash -c "cd /work && curl -s https://install-node.vercel.app/v${{ matrix.node }} | FORCE=1 bash && node -v && corepack enable > /dev/null && NEXT_TEST_JOB=1 NEXT_TEST_MODE=start xvfb-run node run-tests.js --type examples >> /proc/1/fd/1"
name: Run test/examples name: Run test/examples
...@@ -66,7 +66,7 @@ stages: ...@@ -66,7 +66,7 @@ stages:
condition: eq(variables['isDocsOnly'], 'No') condition: eq(variables['isDocsOnly'], 'No')
displayName: 'Install and build' displayName: 'Install and build'
- script: npx playwright@1.28.1 install chromium - script: npx playwright@1.35.1 install chromium
condition: eq(variables['isDocsOnly'], 'No') condition: eq(variables['isDocsOnly'], 'No')
- script: | - script: |
...@@ -138,7 +138,7 @@ stages: ...@@ -138,7 +138,7 @@ stages:
# condition: eq(variables['isDocsOnly'], 'No') # condition: eq(variables['isDocsOnly'], 'No')
# displayName: 'Install and build' # displayName: 'Install and build'
# - script: npx playwright@1.28.1 install chromium # - script: npx playwright@1.35.1 install chromium
# condition: eq(variables['isDocsOnly'], 'No') # condition: eq(variables['isDocsOnly'], 'No')
# - script: | # - script: |
...@@ -175,7 +175,7 @@ stages: ...@@ -175,7 +175,7 @@ stages:
# condition: eq(variables['isDocsOnly'], 'No') # condition: eq(variables['isDocsOnly'], 'No')
# displayName: 'Install and build' # displayName: 'Install and build'
# - script: npx playwright@1.28.1 install chromium # - script: npx playwright@1.35.1 install chromium
# condition: eq(variables['isDocsOnly'], 'No') # condition: eq(variables['isDocsOnly'], 'No')
# - script: | # - script: |
......
...@@ -175,8 +175,8 @@ ...@@ -175,8 +175,8 @@
"open": "9.0.0", "open": "9.0.0",
"outdent": "0.8.0", "outdent": "0.8.0",
"pixrem": "5.0.0", "pixrem": "5.0.0",
"playwright-chromium": "1.28.1", "playwright-chromium": "1.35.1",
"playwright-core": "1.28.1", "playwright-core": "1.35.1",
"plop": "3.0.5", "plop": "3.0.5",
"postcss": "8.4.14", "postcss": "8.4.14",
"postcss-nested": "4.2.1", "postcss-nested": "4.2.1",
......
...@@ -372,11 +372,11 @@ importers: ...@@ -372,11 +372,11 @@ importers:
specifier: 5.0.0 specifier: 5.0.0
version: 5.0.0 version: 5.0.0
playwright-chromium: playwright-chromium:
specifier: 1.28.1 specifier: 1.35.1
version: 1.28.1 version: 1.35.1
playwright-core: playwright-core:
specifier: 1.28.1 specifier: 1.35.1
version: 1.28.1 version: 1.35.1
plop: plop:
specifier: 3.0.5 specifier: 3.0.5
version: 3.0.5 version: 3.0.5
...@@ -20369,18 +20369,18 @@ packages: ...@@ -20369,18 +20369,18 @@ packages:
/platform@1.3.6: /platform@1.3.6:
resolution: {integrity: sha512-fnWVljUchTro6RiCFvCXBbNhJc2NijN7oIQxbwsyL0buWJPG85v81ehlHI9fXrJsMNgTofEoWIQeClKpgxFLrg==} resolution: {integrity: sha512-fnWVljUchTro6RiCFvCXBbNhJc2NijN7oIQxbwsyL0buWJPG85v81ehlHI9fXrJsMNgTofEoWIQeClKpgxFLrg==}
/playwright-chromium@1.28.1: /playwright-chromium@1.35.1:
resolution: {integrity: sha512-+JVgyAOaLUVN8ppAATtURmb5hEl6kaJjK5j3qh05viZvgJi9QoWkb5K02iBy99ww3q86vSnPoMmtKa1Bv+P7LQ==} resolution: {integrity: sha512-bPuWIk/DYWtrg10ajcc9cZLo5s9XQrs6JF6wwiieqZ73rCG3PLVEm0RX8fCUzziuEAhYsoL09UNuKSKv7pKz9A==}
engines: {node: '>=14'} engines: {node: '>=16'}
hasBin: true hasBin: true
requiresBuild: true requiresBuild: true
dependencies: dependencies:
playwright-core: 1.28.1 playwright-core: 1.35.1
dev: true dev: true
/playwright-core@1.28.1: /playwright-core@1.35.1:
resolution: {integrity: sha512-3PixLnGPno0E8rSBJjtwqTwJe3Yw72QwBBBxNoukIj3lEeBNXwbNiKrNuB1oyQgTBw5QHUhNO3SteEtHaMK6ag==} resolution: {integrity: sha512-pNXb6CQ7OqmGDRspEjlxE49w+4YtR6a3X6mT1hZXeJHWmsEz7SunmvZeiG/+y1yyMZdHnnn73WKYdtV1er0Xyg==}
engines: {node: '>=14'} engines: {node: '>=16'}
hasBin: true hasBin: true
dev: true dev: true
......
...@@ -340,6 +340,10 @@ function runTests({ isDev = false, isExport = false, isPages404 = false }) { ...@@ -340,6 +340,10 @@ function runTests({ isDev = false, isExport = false, isPages404 = false }) {
item.as ? `, "${item.as}"` : '' item.as ? `, "${item.as}"` : ''
})` })`
) )
await check(
() => browser.eval('document.readyState'),
/interactive|complete/
)
expect(await browser.eval('window.location.pathname')).toBe(item.pathname) expect(await browser.eval('window.location.pathname')).toBe(item.pathname)
expect(await browser.eval('window.location.search')).toBe( expect(await browser.eval('window.location.search')).toBe(
item.search || '' item.search || ''
......
...@@ -90,7 +90,18 @@ export class Playwright extends BrowserInterface { ...@@ -90,7 +90,18 @@ export class Playwright extends BrowserInterface {
if (browserName === 'safari') { if (browserName === 'safari') {
return await webkit.launch(launchOptions) return await webkit.launch(launchOptions)
} else if (browserName === 'firefox') { } else if (browserName === 'firefox') {
return await firefox.launch(launchOptions) return await firefox.launch({
...launchOptions,
firefoxUserPrefs: {
...launchOptions.firefoxUserPrefs,
// The "fission.webContentIsolationStrategy" pref must be
// set to 1 on Firefox due to the bug where a new history
// state is pushed on a page reload.
// See https://github.com/microsoft/playwright/issues/22640
// See https://bugzilla.mozilla.org/show_bug.cgi?id=1832341
'fission.webContentIsolationStrategy': 1,
},
})
} else { } else {
return await chromium.launch({ return await chromium.launch({
devtools: !launchOptions.headless, devtools: !launchOptions.headless,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment