Unverified Commit 4d2ac245 authored by Michal Piechowiak's avatar Michal Piechowiak Committed by GitHub

feat: provide nextVersion to modifyConfig adapter hook (#90735)

For providers that either don't manage or allow for custom build
commands, checking Next.js version in their builders is not reliable.
Especially for providers that already have existing support there needs
to be very reliable way to only apply certain configuration adjustments
for supported versions of Adapters API.

So this adds `nextVersion` to `modifyConfig` to allow that. It also
brings parity to this hook (`onBuildComplete` already does receive
`nextVersion`.

Corresponding adjustments for docs (just types update) prepared in
https://github.com/vercel/next.js/compare/canary...pieh:next.js:docs/nextVersion-in-adapter-modifyConfig

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
parent 9c31bbda
...@@ -335,6 +335,10 @@ export interface NextAdapter { ...@@ -335,6 +335,10 @@ export interface NextAdapter {
config: NextConfigComplete, config: NextConfigComplete,
ctx: { ctx: {
phase: PHASE_TYPE phase: PHASE_TYPE
/**
* nextVersion is the current version of Next.js being used
*/
nextVersion: string
} }
) => Promise<NextConfigComplete> | NextConfigComplete ) => Promise<NextConfigComplete> | NextConfigComplete
onBuildComplete?: (ctx: { onBuildComplete?: (ctx: {
......
...@@ -1442,6 +1442,7 @@ async function applyModifyConfig( ...@@ -1442,6 +1442,7 @@ async function applyModifyConfig(
config = await adapterMod.modifyConfig(config, { config = await adapterMod.modifyConfig(config, {
phase, phase,
nextVersion: process.env.__NEXT_VERSION as string,
}) })
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment