Unverified Commit 4f9db53e authored by Tim Neutkens's avatar Tim Neutkens Committed by GitHub

Turbopack build: Ensure nanoid is installed during actions test runs (#67666)

The nanoid dependency was not installed in some of these suites, even
though the application code uses it. So this failed to resolve the
dependency in turn causing the build to fail.

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
parent 00ed837b
...@@ -6,6 +6,7 @@ describe('app-dir action handling - next export', () => { ...@@ -6,6 +6,7 @@ describe('app-dir action handling - next export', () => {
skipStart: true, skipStart: true,
skipDeployment: true, skipDeployment: true,
dependencies: { dependencies: {
nanoid: '4.0.1',
'server-only': 'latest', 'server-only': 'latest',
}, },
}) })
......
...@@ -5,6 +5,9 @@ import { check } from 'next-test-utils' ...@@ -5,6 +5,9 @@ import { check } from 'next-test-utils'
describe('app-dir action useActionState', () => { describe('app-dir action useActionState', () => {
const { next } = nextTestSetup({ const { next } = nextTestSetup({
files: __dirname, files: __dirname,
dependencies: {
nanoid: '4.0.1',
},
}) })
it('should support submitting form state with JS', async () => { it('should support submitting form state with JS', async () => {
const browser = await next.browser('/client/form-state') const browser = await next.browser('/client/form-state')
......
...@@ -7,7 +7,7 @@ describe('app-dir action progressive enhancement', () => { ...@@ -7,7 +7,7 @@ describe('app-dir action progressive enhancement', () => {
const { next } = nextTestSetup({ const { next } = nextTestSetup({
files: __dirname, files: __dirname,
dependencies: { dependencies: {
nanoid: 'latest', nanoid: '4.0.1',
'server-only': 'latest', 'server-only': 'latest',
}, },
}) })
......
...@@ -11,6 +11,7 @@ describe('app-dir action size limit invalid config', () => { ...@@ -11,6 +11,7 @@ describe('app-dir action size limit invalid config', () => {
skipDeployment: true, skipDeployment: true,
skipStart: true, skipStart: true,
dependencies: { dependencies: {
nanoid: '4.0.1',
'server-only': 'latest', 'server-only': 'latest',
}, },
}) })
......
...@@ -19,7 +19,7 @@ describe('app-dir action handling', () => { ...@@ -19,7 +19,7 @@ describe('app-dir action handling', () => {
nextTestSetup({ nextTestSetup({
files: __dirname, files: __dirname,
dependencies: { dependencies: {
nanoid: 'latest', nanoid: '4.0.1',
'server-only': 'latest', 'server-only': 'latest',
}, },
}) })
......
...@@ -92,22 +92,22 @@ ...@@ -92,22 +92,22 @@
"runtimeError": false "runtimeError": false
}, },
"test/e2e/app-dir/actions/app-action-export.test.ts": { "test/e2e/app-dir/actions/app-action-export.test.ts": {
"passed": [], "passed": [
"failed": [
"app-dir action handling - next export should error when use export output for server actions" "app-dir action handling - next export should error when use export output for server actions"
], ],
"failed": [],
"pending": [], "pending": [],
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
}, },
"test/e2e/app-dir/actions/app-action-form-state.test.ts": { "test/e2e/app-dir/actions/app-action-form-state.test.ts": {
"passed": [], "passed": [
"failed": [
"app-dir action useActionState should send the action to the provided permalink with form state when JS disabled", "app-dir action useActionState should send the action to the provided permalink with form state when JS disabled",
"app-dir action useActionState should support hydrating the app from progressively enhanced form request", "app-dir action useActionState should support hydrating the app from progressively enhanced form request",
"app-dir action useActionState should support submitting form state with JS", "app-dir action useActionState should support submitting form state with JS",
"app-dir action useActionState should support submitting form state without JS" "app-dir action useActionState should support submitting form state without JS"
], ],
"failed": [],
"pending": [], "pending": [],
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
...@@ -126,12 +126,11 @@ ...@@ -126,12 +126,11 @@
"passed": [ "passed": [
"app-dir action size limit invalid config should error if serverActions.bodySizeLimit config is a negative number", "app-dir action size limit invalid config should error if serverActions.bodySizeLimit config is a negative number",
"app-dir action size limit invalid config should error if serverActions.bodySizeLimit config is a negative size", "app-dir action size limit invalid config should error if serverActions.bodySizeLimit config is a negative size",
"app-dir action size limit invalid config should error if serverActions.bodySizeLimit config is invalid" "app-dir action size limit invalid config should error if serverActions.bodySizeLimit config is invalid",
],
"failed": [
"app-dir action size limit invalid config should respect the size set in serverActions.bodySizeLimit", "app-dir action size limit invalid config should respect the size set in serverActions.bodySizeLimit",
"app-dir action size limit invalid config should respect the size set in serverActions.bodySizeLimit when submitting form" "app-dir action size limit invalid config should respect the size set in serverActions.bodySizeLimit when submitting form"
], ],
"failed": [],
"pending": [], "pending": [],
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment