Unverified Commit 54ae78f9 authored by Tobias Koppers's avatar Tobias Koppers Committed by GitHub

include stdio in error message (#30358)

Improve CI experience
parent 7a34e5ea
...@@ -144,26 +144,38 @@ export function runNextCommand(argv, options = {}) { ...@@ -144,26 +144,38 @@ export function runNextCommand(argv, options = {}) {
options.instance(instance) options.instance(instance)
} }
let mergedStdio = ''
let stderrOutput = '' let stderrOutput = ''
if (options.stderr) { if (options.stderr) {
instance.stderr.on('data', function (chunk) { instance.stderr.on('data', function (chunk) {
mergedStdio += chunk
stderrOutput += chunk stderrOutput += chunk
if (options.stderr === 'log') { if (options.stderr === 'log') {
console.log(chunk.toString()) console.log(chunk.toString())
} }
}) })
} else {
instance.stderr.on('data', function (chunk) {
mergedStdio += chunk
})
} }
let stdoutOutput = '' let stdoutOutput = ''
if (options.stdout) { if (options.stdout) {
instance.stdout.on('data', function (chunk) { instance.stdout.on('data', function (chunk) {
mergedStdio += chunk
stdoutOutput += chunk stdoutOutput += chunk
if (options.stdout === 'log') { if (options.stdout === 'log') {
console.log(chunk.toString()) console.log(chunk.toString())
} }
}) })
} else {
instance.stdout.on('data', function (chunk) {
mergedStdio += chunk
})
} }
instance.on('close', (code, signal) => { instance.on('close', (code, signal) => {
...@@ -173,7 +185,9 @@ export function runNextCommand(argv, options = {}) { ...@@ -173,7 +185,9 @@ export function runNextCommand(argv, options = {}) {
!options.ignoreFail && !options.ignoreFail &&
code !== 0 code !== 0
) { ) {
return reject(new Error(`command failed with code ${code}`)) return reject(
new Error(`command failed with code ${code}\n${mergedStdio}`)
)
} }
resolve({ resolve({
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment