Unverified Commit 55b20af2 authored by Jamiboy Mohammad's avatar Jamiboy Mohammad Committed by GitHub

test: move whole development-only suites out of e2e (#98842)

## Summary

Move whole development-only suites from `test/e2e` to
`test/development`: instant-validation-causes (including its
partial-prefetching variant), webpack-loader-errors,
use-cache-deadlock-probe, and next-image-https. Update the corresponding
test manifests and remove redundant mode checks.

Existing disabled coverage remains disabled. The HTTPS image test
continues to use its shared e2e fixture. Mixed-suite extractions are
reviewed separately in the next PR in the stack.

## Verification

- Formatting, ESLint, and whitespace checks passed.
- Verified that the two-PR stack's final tree is identical to the
previously published combined change.
- Runtime tests were not rerun locally for this history-only split; CI
runs on both layers.

<!-- NEXT_JS_LLM -->
parent 9b16af81
...@@ -86,6 +86,7 @@ ...@@ -86,6 +86,7 @@
"test/development/app-dir/cache-components-*/**/*", "test/development/app-dir/cache-components-*/**/*",
"test/development/app-dir/edge-errors-hmr/index.test.ts", "test/development/app-dir/edge-errors-hmr/index.test.ts",
"test/development/app-dir/next-after-app-invalid-usage/index.test.ts", "test/development/app-dir/next-after-app-invalid-usage/index.test.ts",
"test/development/app-dir/next-image-https/next-image-https.test.ts",
"test/development/app-dir/owner-stack-react-missing-key-prop/owner-stack-react-missing-key-prop.test.ts", "test/development/app-dir/owner-stack-react-missing-key-prop/owner-stack-react-missing-key-prop.test.ts",
"test/development/app-dir/react-performance-track/react-performance-track.test.ts", "test/development/app-dir/react-performance-track/react-performance-track.test.ts",
"test/development/app-dir/segment-explorer/segment-explorer.test.ts", "test/development/app-dir/segment-explorer/segment-explorer.test.ts",
...@@ -212,7 +213,6 @@ ...@@ -212,7 +213,6 @@
"test/e2e/app-dir/next-after-app/index.test.ts", "test/e2e/app-dir/next-after-app/index.test.ts",
"test/e2e/app-dir/next-dynamic-css/next-dynamic-css.test.ts", "test/e2e/app-dir/next-dynamic-css/next-dynamic-css.test.ts",
"test/e2e/app-dir/next-font/**/*", "test/e2e/app-dir/next-font/**/*",
"test/e2e/app-dir/next-image/next-image-https.test.ts",
"test/e2e/app-dir/next-image/next-image-proxy.test.ts", "test/e2e/app-dir/next-image/next-image-proxy.test.ts",
"test/e2e/app-dir/next-image/next-image.test.ts", "test/e2e/app-dir/next-image/next-image.test.ts",
"test/e2e/app-dir/node-extensions/node-extensions.random.test.ts", "test/e2e/app-dir/node-extensions/node-extensions.random.test.ts",
......
...@@ -2,18 +2,13 @@ import { nextTestSetup } from 'e2e-utils' ...@@ -2,18 +2,13 @@ import { nextTestSetup } from 'e2e-utils'
import { createGetInstantInsight } from 'e2e-utils/instant-validation' import { createGetInstantInsight } from 'e2e-utils/instant-validation'
describe('instant validation causes', () => { describe('instant validation causes', () => {
const { next, skipped, isNextDev } = nextTestSetup({ const { next } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
env: { env: {
NEXT_TEST_LOG_VALIDATION: '1', NEXT_TEST_LOG_VALIDATION: '1',
}, },
}) })
if (skipped) return
if (!isNextDev) {
it.skip('Only implemented in dev', () => {})
return
}
let currentCliOutputIndex = 0 let currentCliOutputIndex = 0
beforeEach(() => { beforeEach(() => {
......
import { join } from 'node:path'
import { nextTestSetup } from 'e2e-utils' import { nextTestSetup } from 'e2e-utils'
// TODO: Test didn't (or maybe) never ran in CI but it should. // TODO: Test didn't (or maybe) never ran in CI but it should.
describe.skip('app dir - next-image (with https)', () => { describe.skip('app dir - next-image (with https)', () => {
const { next, skipped } = nextTestSetup({ const { next } = nextTestSetup({
files: __dirname, files: join(__dirname, '../../../e2e/app-dir/next-image'),
skipDeployment: true,
startCommand: `pnpm next dev --experimental-https`, startCommand: `pnpm next dev --experimental-https`,
}) })
if (skipped) {
return
}
it('loads images without any errors', async () => { it('loads images without any errors', async () => {
let failCount = 0 let failCount = 0
const browser = await next.browser('/', { const browser = await next.browser('/', {
......
...@@ -24,23 +24,12 @@ function expectedDeadlockMessage(route: string) { ...@@ -24,23 +24,12 @@ function expectedDeadlockMessage(route: string) {
// than detected as a deadlock. Revisit by surfacing these deadlocks at build // than detected as a deadlock. Revisit by surfacing these deadlocks at build
// time via `next build --debug-prerender`, then re-enable (and retarget) this // time via `next build --debug-prerender`, then re-enable (and retarget) this
// suite. // suite.
// TODO(deploy-test-completion): Re-enable this suite in deploy mode.
// It likely asserts local CLI or runtime output that deploy tests do not expose.
// @force-gate !deploy
// @force-gate TODO // @force-gate TODO
describe('use-cache-deadlock-probe', () => { describe('use-cache-deadlock-probe', () => {
const { next, isNextDev } = nextTestSetup({ const { next } = nextTestSetup({
files: __dirname, files: __dirname,
// Probe behavior is dev-only; skip the production server start, but
// let dev mode auto-start.
skipStart: process.env.NEXT_TEST_MODE !== 'dev',
}) })
if (!isNextDev) {
it('is a dev-only suite', () => {})
return
}
describe('when a "use cache" fill hangs in the static stage due to module-scope state', () => { describe('when a "use cache" fill hangs in the static stage due to module-scope state', () => {
it('should show a module-scope deadlock error early', async () => { it('should show a module-scope deadlock error early', async () => {
const outputIndex = next.cliOutput.length const outputIndex = next.cliOutput.length
......
...@@ -3,17 +3,11 @@ import { retry, waitForRedbox, getRedboxSource } from 'next-test-utils' ...@@ -3,17 +3,11 @@ import { retry, waitForRedbox, getRedboxSource } from 'next-test-utils'
import stripAnsi from 'strip-ansi' import stripAnsi from 'strip-ansi'
describe('webpack-loader-errors', () => { describe('webpack-loader-errors', () => {
const { next, isNextDev, isTurbopack, skipped } = nextTestSetup({ const { next, isTurbopack } = nextTestSetup({
files: __dirname, files: __dirname,
skipDeployment: true,
skipStart: true, skipStart: true,
}) })
if (skipped) return
if (!isNextDev) {
it('should skip in non-dev mode', () => {})
return
}
beforeAll(async () => { beforeAll(async () => {
await next.start() await next.start()
......
...@@ -3531,13 +3531,6 @@ ...@@ -3531,13 +3531,6 @@
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
}, },
"test/e2e/app-dir/instant-validation-causes/instant-validation-causes.test.ts": {
"passed": [],
"failed": [],
"pending": ["instant validation causes Only implemented in dev"],
"flakey": [],
"runtimeError": false
},
"test/e2e/app-dir/instant-validation-client/instant-validation-client.test.ts": { "test/e2e/app-dir/instant-validation-client/instant-validation-client.test.ts": {
"passed": [ "passed": [
"app dir - instant-validation-client should error when a client component exports instant" "app dir - instant-validation-client should error when a client component exports instant"
...@@ -5247,15 +5240,6 @@ ...@@ -5247,15 +5240,6 @@
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
}, },
"test/e2e/app-dir/next-image/next-image-https.test.ts": {
"passed": [],
"failed": [],
"pending": [
"app dir - next-image (with https) loads images without any errors"
],
"flakey": [],
"runtimeError": false
},
"test/e2e/app-dir/next-image/next-image-proxy.test.ts": { "test/e2e/app-dir/next-image/next-image-proxy.test.ts": {
"passed": [], "passed": [],
"failed": [ "failed": [
...@@ -8463,13 +8447,6 @@ ...@@ -8463,13 +8447,6 @@
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
}, },
"test/e2e/app-dir/webpack-loader-errors/webpack-loader-errors.test.ts": {
"passed": ["webpack-loader-errors should skip in non-dev mode"],
"failed": [],
"pending": [],
"flakey": [],
"runtimeError": false
},
"test/e2e/app-dir/webpack-loader-fs/webpack-loader-fs.test.ts": { "test/e2e/app-dir/webpack-loader-fs/webpack-loader-fs.test.ts": {
"passed": ["webpack-loader-fs should allow reading the input FS"], "passed": ["webpack-loader-fs should allow reading the input FS"],
"failed": [], "failed": [],
...@@ -1042,6 +1042,19 @@ ...@@ -1042,6 +1042,19 @@
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
}, },
"test/development/app-dir/instant-validation-causes/instant-validation-causes.test.ts": {
"passed": [
"instant validation causes aliased export - export { instantConfig as instant }",
"instant validation causes does not add an instant stack for random instant exports",
"instant validation causes indirect export - const instantConfig = _instant; export { instantConfig as instant }",
"instant validation causes named export - export { instant }",
"instant validation causes re-export - export { instant } from \"./config\""
],
"failed": [],
"pending": [],
"flakey": [],
"runtimeError": false
},
"test/development/app-dir/isolated-dev-build/isolated-dev-build.test.ts": { "test/development/app-dir/isolated-dev-build/isolated-dev-build.test.ts": {
"passed": [ "passed": [
"isolated-dev-build should create dev artifacts in .next/dev/ directory", "isolated-dev-build should create dev artifacts in .next/dev/ directory",
...@@ -1099,6 +1112,15 @@ ...@@ -1099,6 +1112,15 @@
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
}, },
"test/development/app-dir/next-image-https/next-image-https.test.ts": {
"passed": [],
"failed": [],
"pending": [
"app dir - next-image (with https) loads images without any errors"
],
"flakey": [],
"runtimeError": false
},
"test/development/app-dir/owner-stack-invalid-element-type/owner-stack-invalid-element-type.test.ts": { "test/development/app-dir/owner-stack-invalid-element-type/owner-stack-invalid-element-type.test.ts": {
"passed": [ "passed": [
"app-dir - owner-stack-invalid-element-type should catch invalid element from a browser only component", "app-dir - owner-stack-invalid-element-type should catch invalid element from a browser only component",
...@@ -1392,6 +1414,20 @@ ...@@ -1392,6 +1414,20 @@
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
}, },
"test/development/app-dir/webpack-loader-errors/webpack-loader-errors.test.ts": {
"passed": [
"webpack-loader-errors CLI output should show the loader path and error message when a loader throws a plain string",
"webpack-loader-errors CLI output should show the loader path and error message when a loader throws an Error",
"webpack-loader-errors error overlay should show error overlay with loader path when a loader throws a filesystem error",
"webpack-loader-errors error overlay should show error overlay with loader path when a loader throws a plain string",
"webpack-loader-errors error overlay should show error overlay with loader path when a loader throws an Error",
"webpack-loader-errors error overlay should show error overlay with loader path when a loader throws an Error without stack"
],
"failed": [],
"pending": [],
"flakey": [],
"runtimeError": false
},
"test/development/app-hmr/hmr-env.test.ts": { "test/development/app-hmr/hmr-env.test.ts": {
"passed": [ "passed": [
"app-dir hmr-env should update server components pages when env files is changed (node)", "app-dir hmr-env should update server components pages when env files is changed (node)",
...@@ -6100,19 +6136,6 @@ ...@@ -6100,19 +6136,6 @@
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
}, },
"test/e2e/app-dir/instant-validation-causes/instant-validation-causes.test.ts": {
"passed": [
"instant validation causes aliased export - export { instantConfig as instant }",
"instant validation causes does not add an instant stack for random instant exports",
"instant validation causes indirect export - const instantConfig = _instant; export { instantConfig as instant }",
"instant validation causes named export - export { instant }",
"instant validation causes re-export - export { instant } from \"./config\""
],
"failed": [],
"pending": [],
"flakey": [],
"runtimeError": false
},
"test/e2e/app-dir/instant-validation-client/instant-validation-client.test.ts": { "test/e2e/app-dir/instant-validation-client/instant-validation-client.test.ts": {
"passed": [ "passed": [
"app dir - instant-validation-client should error when a client component exports instant" "app dir - instant-validation-client should error when a client component exports instant"
...@@ -8040,15 +8063,6 @@ ...@@ -8040,15 +8063,6 @@
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
}, },
"test/e2e/app-dir/next-image/next-image-https.test.ts": {
"passed": [],
"failed": [],
"pending": [
"app dir - next-image (with https) loads images without any errors"
],
"flakey": [],
"runtimeError": false
},
"test/e2e/app-dir/next-image/next-image-proxy.test.ts": { "test/e2e/app-dir/next-image/next-image-proxy.test.ts": {
"passed": [], "passed": [],
"failed": [ "failed": [
...@@ -10908,20 +10922,6 @@ ...@@ -10908,20 +10922,6 @@
"flakey": [], "flakey": [],
"runtimeError": false "runtimeError": false
}, },
"test/e2e/app-dir/webpack-loader-errors/webpack-loader-errors.test.ts": {
"passed": [
"webpack-loader-errors CLI output should show the loader path and error message when a loader throws a plain string",
"webpack-loader-errors CLI output should show the loader path and error message when a loader throws an Error",
"webpack-loader-errors error overlay should show error overlay with loader path when a loader throws a filesystem error",
"webpack-loader-errors error overlay should show error overlay with loader path when a loader throws a plain string",
"webpack-loader-errors error overlay should show error overlay with loader path when a loader throws an Error",
"webpack-loader-errors error overlay should show error overlay with loader path when a loader throws an Error without stack"
],
"failed": [],
"pending": [],
"flakey": [],
"runtimeError": false
},
"test/e2e/app-dir/webpack-loader-fs/webpack-loader-fs.test.ts": { "test/e2e/app-dir/webpack-loader-fs/webpack-loader-fs.test.ts": {
"passed": ["webpack-loader-fs should allow reading the input FS"], "passed": ["webpack-loader-fs should allow reading the input FS"],
"failed": [], "failed": [],
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment