Unverified Commit 57ea96fa authored by Tobias Koppers's avatar Tobias Koppers Committed by GitHub

build(turbopack): upgrade notify to 9.0.0-rc.5 (#98737)

### What?

Upgrades the Turbopack filesystem-watcher dependency from `notify 8.1.0`
to the published `9.0.0-rc.5` release candidate.

Stack: **4/5** · Previous: #98863 · Next: #97673

### Why?

notify-rs/notify#981 fixes PollWatcher dropping multiple edits to the
same regular file within one second. The old implementation stored file
mtimes at whole-second precision; with content hashing disabled, a
second write in the same second compared equal and produced no event.
This is the root cause behind #96982.

rc.5 keeps nanosecond mtime precision for ordinary files without
enabling content hashing. It remains a pre-release, so the pin should be
revisited when notify 9.0 stable is available.

### How?

The workspace dependency is pinned to exactly `9.0.0-rc.5`, and Cargo
regenerates the lockfile. No Rust source compatibility changes are
required: `turbo-tasks-fs` uses a narrow notify API surface and does not
rely on removed APIs.

The lockfile update includes notify's current backend dependencies
across Linux, macOS, and Windows; cross-platform CI remains important
because local runtime verification is Linux-only.

### Filesystem-watcher fuzzer impact

The preceding stack layer adds `--poll-interval-ms` to `turbo-tasks-fuzz
fs-watcher`, which provides a direct before/after control for this
dependency update. Using a 100 ms polling interval, a 1,000 ms
observation window, and no directory recreation:

| Fuzzer mode | notify 8.1.0 | notify 9.0.0-rc.5 |
| --- | --- | --- |
| `--track-read-writes` | **230/288 iterations had mismatches** over
five minutes | **0/291 iterations had mismatches** over five minutes |
| ordinary reads | same-second changes can be missed depending on timing
| **0 missing invalidations across 295 iterations** over five minutes |

The read/write mode is the strongest comparison: it repeatedly produces
an external edit after a read-derived write in the same-second window,
so notify 8 fails consistently while rc.5 remains clean.

Two findings are intentionally unchanged by this PR:

- polling symlink mutations can still be missed within one second
because rc.5 retains whole-second mtime precision for non-files; the
fuzzer documents this limitation;
- directory recreation can produce recoverable `PathNotFound`
diagnostics while PollWatcher scans deleted subtrees. A 60-second
resilience run completed 500 iterations with no panic or terminal error.

A fresh native SWC/Turbopack build also passes the upper integration
suite's rapid subsecond HMR case without timestamp workarounds.

Fixes #96982

<!-- NEXT_JS_LLM -->


<!-- fleet 6488265d-2685-49d3-b632-6511b4b47690 -->
Co-authored-by: 's avatarvercel-fleet-prod[bot] <318278635+vercel-fleet-prod[bot]@users.noreply.github.com>
Co-authored-by: 's avatarTobias Koppers <1365881+sokra@users.noreply.github.com>
Co-authored-by: 's avatarBenjamin Woodruff ‮ <180404+bgw@users.noreply.github.com>
parent 946d560a
This diff is collapsed.
...@@ -310,7 +310,7 @@ napi = { version = "3.10.0", default-features = false, features = [ ...@@ -310,7 +310,7 @@ napi = { version = "3.10.0", default-features = false, features = [
napi-derive = "3.5.8" napi-derive = "3.5.8"
napi-build = "2.3.2" napi-build = "2.3.2"
nohash-hasher = "0.2.0" nohash-hasher = "0.2.0"
notify = "8.1.0" notify = "9.0.0-rc.5"
owo-colors = "4.2.2" owo-colors = "4.2.2"
parcel_selectors = "0.28.2" parcel_selectors = "0.28.2"
parking_lot = "0.12.1" parking_lot = "0.12.1"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment