Unverified Commit 598b1ef1 authored by JJ Kasper's avatar JJ Kasper Committed by GitHub

Fix long URLs causing 400s with dynamic routes/rewrites (#26221)

Co-authored-by: 's avatarkodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
parent 67aba846
...@@ -16,7 +16,7 @@ export async function fileExists( ...@@ -16,7 +16,7 @@ export async function fileExists(
} }
return true return true
} catch (err) { } catch (err) {
if (err.code === 'ENOENT') { if (err.code === 'ENOENT' || err.code === 'ENAMETOOLONG') {
return false return false
} }
throw err throw err
......
...@@ -39,6 +39,17 @@ let appPort ...@@ -39,6 +39,17 @@ let appPort
let app let app
const runTests = (isDev = false) => { const runTests = (isDev = false) => {
it('should support long URLs for rewrites', async () => {
const res = await fetchViaHTTP(
appPort,
'/catchall-rewrite/a9btBxtHQALZ6cxfuj18X6OLGNSkJVzrOXz41HG4QwciZfn7ggRZzPx21dWqGiTBAqFRiWvVNm5ko2lpyso5jtVaXg88dC1jKfqI2qmIcdeyJat8xamrIh2LWnrYRrsBcoKfQU65KHod8DPANuzPS3fkVYWlmov05GQbc82HwR1exOvPVKUKb5gBRWiN0WOh7hN4QyezIuq3dJINAptFQ6m2bNGjYACBRk4MOSHdcQG58oq5Ch7luuqrl9EcbWSa'
)
const html = await res.text()
expect(res.status).toBe(200)
expect(html).toContain('/with-params')
})
it('should resolveHref correctly navigating through history', async () => { it('should resolveHref correctly navigating through history', async () => {
const browser = await webdriver(appPort, '/') const browser = await webdriver(appPort, '/')
await browser.eval('window.beforeNav = 1') await browser.eval('window.beforeNav = 1')
......
export default () => 'hi' export default function Page(props) {
return 'hi'
}
...@@ -30,6 +30,18 @@ const appDir = join(__dirname, '../') ...@@ -30,6 +30,18 @@ const appDir = join(__dirname, '../')
const buildIdPath = join(appDir, '.next/BUILD_ID') const buildIdPath = join(appDir, '.next/BUILD_ID')
function runTests(dev) { function runTests(dev) {
it('should support long URLs for dynamic routes', async () => {
const res = await fetchViaHTTP(
appPort,
'/dash/a9btBxtHQALZ6cxfuj18X6OLGNSkJVzrOXz41HG4QwciZfn7ggRZzPx21dWqGiTBAqFRiWvVNm5ko2lpyso5jtVaXg88dC1jKfqI2qmIcdeyJat8xamrIh2LWnrYRrsBcoKfQU65KHod8DPANuzPS3fkVYWlmov05GQbc82HwR1exOvPVKUKb5gBRWiN0WOh7hN4QyezIuq3dJINAptFQ6m2bNGjYACBRk4MOSHdcQG58oq5Ch7luuqrl9EcbWSa'
)
const html = await res.text()
expect(res.status).toBe(200)
expect(html).toContain('hi')
expect(html).toContain('/dash/[hello-world]')
})
it('should handle only query on dynamic route', async () => { it('should handle only query on dynamic route', async () => {
const browser = await webdriver(appPort, '/post-1') const browser = await webdriver(appPort, '/post-1')
......
import { useRouter } from 'next/router' import { useRouter } from 'next/router'
export default function Page() { export default function Page() {
return <p>hello {useRouter().query}</p> return <p>hello {useRouter().query.slug}</p>
} }
export const getServerSideProps = () => { export const getServerSideProps = () => {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment