Unverified Commit 5ad7b1f8 authored by Tobias Koppers's avatar Tobias Koppers Committed by GitHub

Turbopack: fix side effects optimization bug (#77640)

### What?

the local fragment need to reference evaluation references

So if importing local exports of a module that is flagged as side effect free it potentially need to run the side effects of imports (if they are not flagged as side effect free).
parent 5b6b225b
......@@ -180,8 +180,8 @@ describe('ReactRefreshLogBox', () => {
| ^",
"stack": [
"[project]/index.js [ssr] (ecmascript) index.js (3:7)",
"<FIXME-next-dist-dir>",
"<FIXME-next-dist-dir>",
"[project]/pages/index.js [ssr] (ecmascript) <module evaluation> pages/index.js (1:1)",
"[project]/pages/index.js [ssr] (ecmascript) pages/index.js (1:1)",
"<FIXME-next-dist-dir>",
],
}
......
......@@ -276,6 +276,7 @@ impl AnalyzeEcmascriptModuleResultBuilder {
/// If you're unsure about which function to use, use `add_reference()`
pub fn add_esm_evaluation_reference(&mut self, idx: usize) {
self.esm_references.insert(idx);
self.esm_local_references.insert(idx);
self.esm_evaluation_references.insert(idx);
}
......
import {
a as a0,
b as b0,
c as c0,
d as d0,
e as e0,
def as def0,
} from "package-named";
it("should optimize named reexports from side effect free module", () => {
expect(a0).toBe("a");
expect(b0).toBe("b");
expect(c0).toBe("x");
expect(d0).toBe("y");
expect(e0).toBe("x");
expect(def0).toBe("default");
});
import {
a as a1,
b as b1,
......@@ -7,8 +24,8 @@ import {
local as local1,
default as default1,
def as def1,
} from "package-named";
it("should optimize named reexports from side effect free module", () => {
} from "package-named-local";
it("should optimize named reexports with locals from side effect free module", () => {
expect(a1).toBe("a");
expect(b1).toBe("b");
expect(c1).toBe("x");
......@@ -19,11 +36,10 @@ it("should optimize named reexports from side effect free module", () => {
expect(def1).toBe("default");
});
import { a as a2, b as b2, local as local2 } from "package-star";
import { a as a2, b as b2 } from "package-star";
it("should optimize star reexports from side effect free module", () => {
expect(a2).toBe("a");
expect(b2).toBe("b");
expect(local2).toBe("local");
});
import {
......
export { notCompiled } from "./not-compiled.js";
export { notExecuted } from "./not-executed.js";
export * from "./not-compiled.js";
export * from "./not-executed.js";
export { a } from "./a.js";
export { b } from "./b.js";
export { x as c } from "./x.js";
export { y as d } from "./y.js";
export { x as e } from "./y.js";
export { default as def } from "./default.js";
export const local = "local";
export default "local-default";
......@@ -10,5 +10,3 @@ export { x as c } from "./x.js";
export { y as d } from "./y.js";
export { x as e } from "./y.js";
export { default as def } from "./default.js";
export const local = "local";
export default "local-default";
export { notCompiled } from "./not-compiled.js";
export { notExisting } from "./not-existing.js";
export { notExecuted } from "./not-executed.js";
export * from "./not-executed.js";
export * from "./a.js";
......
import getValue from "./reexport.js";
it("should not optimize away side effects", () => {
expect(getValue()).toBe(42);
});
import { value } from "./valueSetter.js";
export { value } from "./valueSetter.js";
export default () => {
return value
}
import { setValue } from "./valueContainer.js";
setValue(42);
export * from "./valueContainer.js";
import "../../../side-effects-optimization/follow-keeps-side-effect/input/index.js";
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment