Unverified Commit 5b4e139d authored by Thibaut SABOT's avatar Thibaut SABOT Committed by GitHub

Fix no-server-import-in-page eslint rule for subfolder middleware (#32139)

People have been reporting on https://github.com/vercel/next.js/pull/30973 that the `no-server-import-in-page` eslint rule is reporting false positives for `_middleware` files inside sub-page folders.

Unlike `_document`, we can have multiple `_middleware` files.

Fixes #32121
parent 20814c34
......@@ -21,8 +21,8 @@ module.exports = {
if (
!page ||
page.startsWith(`${path.sep}_middleware`) ||
page.startsWith(`${path.posix.sep}_middleware`)
page.includes(`${path.sep}_middleware`) ||
page.includes(`${path.posix.sep}_middleware`)
) {
return
}
......
......@@ -78,6 +78,15 @@ ruleTester.run('no-server-import-in-page', rule, {
`,
filename: 'pagesapp/src/pages/_middleware.js',
},
{
code: `import { NextFetchEvent, NextRequest } from "next/server"
export function middleware(req, ev) {
return new Response('Hello, world!')
}
`,
filename: 'src/pages/subFolder/_middleware.js',
},
],
invalid: [
{
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment