Unverified Commit 5b883bb5 authored by Jimmy Lai's avatar Jimmy Lai Committed by GitHub

performance: enable minification for the server bundles (#51831)

This PR makes the server code be minified.

## Why

This will improve performance of the server code because of the lesser
size, lesser time to parse and lesser code via tree sharking.

Cons: this should lead to increased build times, so a
`disableServerMinification` config was added


<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->

link NEXT-1319
parent 5b5ea47c
......@@ -1766,7 +1766,11 @@ export default async function getBaseWebpackConfig(
runtimeChunk: isClient
? { name: CLIENT_STATIC_FILES_RUNTIME_WEBPACK }
: undefined,
minimize: !dev && (isClient || isEdgeServer),
minimize:
!dev &&
(isClient ||
isEdgeServer ||
(isNodeServer && config.experimental.serverMinification)),
minimizer: [
// Minify JavaScript
(compiler: webpack.Compiler) => {
......@@ -2724,6 +2728,7 @@ export default async function getBaseWebpackConfig(
experimental: config.experimental,
disableStaticImages: config.images.disableStaticImages,
transpilePackages: config.transpilePackages,
serverSourceMaps: config.experimental.serverSourceMaps,
})
// @ts-ignore Cache exists
......
......@@ -34,6 +34,7 @@ export const base = curry(function base(
} else {
if (
ctx.isEdgeRuntime ||
(ctx.isServer && ctx.serverSourceMaps) ||
// Enable browser sourcemaps:
(ctx.productionBrowserSourceMaps && ctx.isClient)
) {
......
......@@ -25,6 +25,7 @@ export async function buildConfiguration(
transpilePackages,
experimental,
disableStaticImages,
serverSourceMaps,
}: {
hasAppDir: boolean
supportedBrowsers: string[] | undefined
......@@ -41,6 +42,7 @@ export async function buildConfiguration(
future: NextConfigComplete['future']
experimental: NextConfigComplete['experimental']
disableStaticImages: NextConfigComplete['disableStaticImages']
serverSourceMaps: NextConfigComplete['experimental']['serverSourceMaps']
}
): Promise<webpack.Configuration> {
const ctx: ConfigurationContext = {
......@@ -64,6 +66,7 @@ export async function buildConfiguration(
transpilePackages,
future,
experimental,
serverSourceMaps: serverSourceMaps ?? false,
}
let fns = [base(ctx), css(ctx)]
......
......@@ -22,6 +22,7 @@ export type ConfigurationContext = {
sassOptions: any
productionBrowserSourceMaps: boolean
serverSourceMaps: boolean
transpilePackages: NextConfigComplete['transpilePackages']
......
......@@ -512,6 +512,12 @@ const configSchema = {
logging: {
type: 'string',
},
serverMinification: {
type: 'boolean',
},
serverSourceMaps: {
type: 'boolean',
},
},
type: 'object',
},
......
......@@ -287,6 +287,16 @@ export interface ExperimentalConfig {
* Allows adjusting body parser size limit for server actions.
*/
serverActionsBodySizeLimit?: SizeLimit
/**
* enables the minification of server code.
*/
serverMinification?: boolean
/**
* Enables source maps generation for the server production bundle.
*/
serverSourceMaps?: boolean
}
export type ExportPathMap = {
......@@ -670,6 +680,8 @@ export const defaultConfig: NextConfig = {
output: !!process.env.NEXT_PRIVATE_STANDALONE ? 'standalone' : undefined,
modularizeImports: undefined,
experimental: {
serverMinification: false,
serverSourceMaps: false,
caseSensitiveRoutes: false,
useDeploymentId: false,
deploymentId: undefined,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment