Unverified Commit 5cf4f878 authored by Tim Neutkens's avatar Tim Neutkens Committed by GitHub

Remove incorrect test (#61335)

## What?

Noticed this test failed on Turbopack but it's actually not checking
anything meaningful so it can be removed.

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->


Closes NEXT-2285
parent 3008af6b
module.exports = {
onDemandEntries: {
// Make sure entries are not getting disposed.
maxInactiveAge: 1000 * 60 * 60,
},
}
export default function Abc() {
return <div id="a">hello</div>
}
/* eslint-env jest */
import {
check,
File,
findPort,
hasRedbox,
killApp,
launchApp,
} from 'next-test-utils'
import webdriver from 'next-webdriver'
import { join } from 'path'
const appDir = join(__dirname, '../')
describe('no duplicate compile error output', () => {
it('should not show compile error on page refresh', async () => {
let stderr = ''
const appPort = await findPort()
const app = await launchApp(appDir, appPort, {
env: { __NEXT_TEST_WITH_DEVTOOL: true },
onStderr(msg) {
stderr += msg || ''
},
})
const browser = await webdriver(appPort, '/')
await browser.waitForElementByCss('#a')
const f = new File(join(appDir, 'pages', 'index.js'))
f.replace('<div id="a">hello</div>', '<div id="a"!>hello</div>')
try {
// Wait for compile error:
expect(await hasRedbox(browser)).toBe(true)
await browser.refresh()
// Wait for compile error to re-appear:
expect(await hasRedbox(browser)).toBe(true)
} finally {
f.restore()
}
// Wait for compile error to disappear:
await check(() => hasRedbox(browser).then((r) => (r ? 'yes' : 'no')), /no/)
await browser.waitForElementByCss('#a')
function getRegexCount(str, regex) {
return (str.match(regex) || []).length
}
const correctMessagesRegex = /Caused by:/g
const totalMessagesRegex = /Unexpected token/g
const correctMessages = getRegexCount(stderr, correctMessagesRegex)
const totalMessages = getRegexCount(stderr, totalMessagesRegex)
expect(correctMessages).toBeGreaterThanOrEqual(1)
expect(correctMessages).toBe(totalMessages)
await killApp(app)
})
})
......@@ -13690,15 +13690,6 @@
"flakey": [],
"runtimeError": false
},
"test/integration/no-duplicate-compile-error/test/index.test.js": {
"passed": [],
"failed": [
"no duplicate compile error output should not show compile error on page refresh"
],
"pending": [],
"flakey": [],
"runtimeError": false
},
"test/integration/no-op-export/test/index.test.js": {
"passed": [],
"failed": [],
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment