Unverified Commit 5d3303f5 authored by Joe Haddad's avatar Joe Haddad Committed by GitHub

Ensure Build Output Does Not Contain `<buildId>` (#10021)

* Ensure Build Output Does Not Contain `<buildId>`

* use posix join for common file
parent de0b0e87
...@@ -343,7 +343,7 @@ async function computeFromManifest( ...@@ -343,7 +343,7 @@ async function computeFromManifest(
// Add well-known shared file // Add well-known shared file
files.set( files.set(
path.join( path.posix.join(
`static/${buildId}/pages/`, `static/${buildId}/pages/`,
`/_app${isModern ? '.module' : ''}.js` `/_app${isModern ? '.module' : ''}.js`
), ),
......
...@@ -30,6 +30,7 @@ describe('Build Output', () => { ...@@ -30,6 +30,7 @@ describe('Build Output', () => {
expect(stdout).not.toContain(' /_document') expect(stdout).not.toContain(' /_document')
expect(stdout).not.toContain(' /_app') expect(stdout).not.toContain(' /_app')
expect(stdout).not.toContain(' /_error') expect(stdout).not.toContain(' /_error')
expect(stdout).not.toContain('<buildId>')
expect(stdout).toContain('○ /') expect(stdout).toContain('○ /')
}) })
...@@ -55,6 +56,7 @@ describe('Build Output', () => { ...@@ -55,6 +56,7 @@ describe('Build Output', () => {
expect(stdout).not.toContain(' /_document') expect(stdout).not.toContain(' /_document')
expect(stdout).not.toContain(' /_error') expect(stdout).not.toContain(' /_error')
expect(stdout).not.toContain('<buildId>')
expect(stdout).toContain(' /_app') expect(stdout).toContain(' /_app')
expect(stdout).toContain('○ /') expect(stdout).toContain('○ /')
...@@ -82,6 +84,7 @@ describe('Build Output', () => { ...@@ -82,6 +84,7 @@ describe('Build Output', () => {
expect(stdout).not.toContain(' /_document') expect(stdout).not.toContain(' /_document')
expect(stdout).not.toContain(' /_error') expect(stdout).not.toContain(' /_error')
expect(stdout).not.toContain('<buildId>')
expect(stdout).toContain('○ /') expect(stdout).toContain('○ /')
}) })
...@@ -107,6 +110,7 @@ describe('Build Output', () => { ...@@ -107,6 +110,7 @@ describe('Build Output', () => {
expect(stdout).not.toContain(' /_document') expect(stdout).not.toContain(' /_document')
expect(stdout).not.toContain(' /_app') expect(stdout).not.toContain(' /_app')
expect(stdout).not.toContain('<buildId>')
expect(stdout).toContain(' /_error') expect(stdout).toContain(' /_error')
expect(stdout).toContain('○ /') expect(stdout).toContain('○ /')
...@@ -126,6 +130,7 @@ describe('Build Output', () => { ...@@ -126,6 +130,7 @@ describe('Build Output', () => {
stdout: true, stdout: true,
}) })
expect(stdout).toContain('○ /_error') expect(stdout).toContain('○ /_error')
expect(stdout).not.toContain('<buildId>')
}) })
// This test is not really correct. // This test is not really correct.
...@@ -135,6 +140,7 @@ describe('Build Output', () => { ...@@ -135,6 +140,7 @@ describe('Build Output', () => {
stdout: true, stdout: true,
}) })
expect(stdout).toContain('λ /_error') expect(stdout).toContain('λ /_error')
expect(stdout).not.toContain('<buildId>')
}) })
}) })
}) })
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment