Unverified Commit 5d532afa authored by Jiachi Liu's avatar Jiachi Liu Committed by GitHub

Mark styled-jsx as client-only package (#41414)

For css-in-js libs like styled-jsx we don't recommend to use on server side since it will blow up the rsc payload during navigation. This upgration of styled-jsx includes `client-only` as dependency so that it will throw when it's been used on serevr layer

x-ref: https://github.com/vercel/styled-jsx/pull/816
parent 7bde099a
...@@ -78,7 +78,7 @@ ...@@ -78,7 +78,7 @@
"@swc/helpers": "0.4.11", "@swc/helpers": "0.4.11",
"caniuse-lite": "^1.0.30001406", "caniuse-lite": "^1.0.30001406",
"postcss": "8.4.14", "postcss": "8.4.14",
"styled-jsx": "5.0.7", "styled-jsx": "5.1.0",
"use-sync-external-store": "1.2.0" "use-sync-external-store": "1.2.0"
}, },
"peerDependencies": { "peerDependencies": {
......
...@@ -614,7 +614,7 @@ importers: ...@@ -614,7 +614,7 @@ importers:
string_decoder: 1.3.0 string_decoder: 1.3.0
string-hash: 1.1.3 string-hash: 1.1.3
strip-ansi: 6.0.0 strip-ansi: 6.0.0
styled-jsx: 5.0.7 styled-jsx: 5.1.0
tar: 6.1.11 tar: 6.1.11
taskr: 1.1.0 taskr: 1.1.0
terser: 5.14.1 terser: 5.14.1
...@@ -639,7 +639,7 @@ importers: ...@@ -639,7 +639,7 @@ importers:
'@swc/helpers': 0.4.11 '@swc/helpers': 0.4.11
caniuse-lite: 1.0.30001406 caniuse-lite: 1.0.30001406
postcss: 8.4.14 postcss: 8.4.14
styled-jsx: 5.0.7_uuaxwgga6hqycsez5ok7v2wg4i styled-jsx: 5.1.0_uuaxwgga6hqycsez5ok7v2wg4i
use-sync-external-store: 1.2.0_react@18.2.0 use-sync-external-store: 1.2.0_react@18.2.0
devDependencies: devDependencies:
'@ampproject/toolbox-optimizer': 2.8.3 '@ampproject/toolbox-optimizer': 2.8.3
...@@ -11097,6 +11097,13 @@ packages: ...@@ -11097,6 +11097,13 @@ packages:
} }
engines: { node: '>= 10' } engines: { node: '>= 10' }
/client-only/0.0.1:
resolution:
{
integrity: sha512-IV3Ou0jSMzZrd3pZ48nLkT9DA7Ag1pnPzaiQhpW7c3RbcqqzvzzVu+L8gfqMp/8IM2MQtSiqaCxrrcfu8I8rMA==,
}
dev: false
/cliui/5.0.0: /cliui/5.0.0:
resolution: resolution:
{ {
...@@ -28106,10 +28113,10 @@ packages: ...@@ -28106,10 +28113,10 @@ packages:
postcss-load-plugins: 2.3.0 postcss-load-plugins: 2.3.0
dev: true dev: true
/styled-jsx/5.0.7_uuaxwgga6hqycsez5ok7v2wg4i: /styled-jsx/5.1.0_uuaxwgga6hqycsez5ok7v2wg4i:
resolution: resolution:
{ {
integrity: sha512-b3sUzamS086YLRuvnaDigdAewz1/EFYlHpYBP5mZovKEdQQOIIYq8lApylub3HHZ6xFjV051kkGU7cudJmrXEA==, integrity: sha512-/iHaRJt9U7T+5tp6TRelLnqBqiaIT0HsO0+vgyj8hK2KUk7aejFqRrumqPUlAqDwAj8IbS/1hk3IhBAAK/FCUQ==,
} }
engines: { node: '>= 12.0.0' } engines: { node: '>= 12.0.0' }
peerDependencies: peerDependencies:
...@@ -28123,6 +28130,7 @@ packages: ...@@ -28123,6 +28130,7 @@ packages:
optional: true optional: true
dependencies: dependencies:
'@babel/core': 7.18.0 '@babel/core': 7.18.0
client-only: 0.0.1
react: 18.2.0 react: 18.2.0
dev: false dev: false
......
...@@ -1240,62 +1240,6 @@ describe('app dir', () => { ...@@ -1240,62 +1240,6 @@ describe('app dir', () => {
await next.patchFile(filePath, origContent) await next.patchFile(filePath, origContent)
} }
}) })
it('should throw an error when getServerSideProps is used', async () => {
const pageFile =
'app/client-with-errors/get-server-side-props/page.js'
const content = await next.readFile(pageFile)
const uncomment = content.replace(
'// export function getServerSideProps',
'export function getServerSideProps'
)
await next.patchFile(pageFile, uncomment)
const res = await fetchViaHTTP(
next.url,
'/client-with-errors/get-server-side-props'
)
await next.patchFile(pageFile, content)
await check(async () => {
const { status } = await fetchViaHTTP(
next.url,
'/client-with-errors/get-server-side-props'
)
return status
}, /200/)
expect(res.status).toBe(500)
expect(await res.text()).toContain(
'`getServerSideProps` is not allowed in Client Components'
)
})
it('should throw an error when getStaticProps is used', async () => {
const pageFile = 'app/client-with-errors/get-static-props/page.js'
const content = await next.readFile(pageFile)
const uncomment = content.replace(
'// export function getStaticProps',
'export function getStaticProps'
)
await next.patchFile(pageFile, uncomment)
const res = await fetchViaHTTP(
next.url,
'/client-with-errors/get-static-props'
)
await next.patchFile(pageFile, content)
await check(async () => {
const { status } = await fetchViaHTTP(
next.url,
'/client-with-errors/get-static-props'
)
return status
}, /200/)
expect(res.status).toBe(500)
expect(await res.text()).toContain(
'`getStaticProps` is not allowed in Client Components'
)
})
} }
}) })
......
import path from 'path'
import { check, fetchViaHTTP, renderViaHTTP } from 'next-test-utils'
import { createNext, FileRef } from 'e2e-utils'
import { NextInstance } from 'test/lib/next-modes/base'
describe('app dir - rsc basics', () => {
let next: NextInstance
const { isNextDeploy, isNextDev } = global as any
const isReact17 = process.env.NEXT_TEST_REACT_VERSION === '^17'
if (isNextDeploy || isReact17) {
it('should skip tests for next-deploy and react 17', () => {})
return
}
if (!isNextDev) {
it('should skip tests for next-start', () => {})
return
}
beforeAll(async () => {
next = await createNext({
files: new FileRef(path.join(__dirname, './rsc-errors')),
dependencies: {
react: 'experimental',
'react-dom': 'experimental',
},
})
})
afterAll(() => next.destroy())
it('should throw an error when getServerSideProps is used', async () => {
const pageFile = 'app/client-with-errors/get-server-side-props/page.js'
const content = await next.readFile(pageFile)
const uncomment = content.replace(
'// export function getServerSideProps',
'export function getServerSideProps'
)
await next.patchFile(pageFile, uncomment)
const res = await fetchViaHTTP(
next.url,
'/client-with-errors/get-server-side-props'
)
await next.patchFile(pageFile, content)
await check(async () => {
const { status } = await fetchViaHTTP(
next.url,
'/client-with-errors/get-server-side-props'
)
return status
}, /200/)
expect(res.status).toBe(500)
expect(await res.text()).toContain(
'`getServerSideProps` is not allowed in Client Components'
)
})
it('should throw an error when getStaticProps is used', async () => {
const pageFile = 'app/client-with-errors/get-static-props/page.js'
const content = await next.readFile(pageFile)
const uncomment = content.replace(
'// export function getStaticProps',
'export function getStaticProps'
)
await next.patchFile(pageFile, uncomment)
const res = await fetchViaHTTP(
next.url,
'/client-with-errors/get-static-props'
)
await next.patchFile(pageFile, content)
await check(async () => {
const { status } = await fetchViaHTTP(
next.url,
'/client-with-errors/get-static-props'
)
return status
}, /200/)
expect(res.status).toBe(500)
expect(await res.text()).toContain(
'`getStaticProps` is not allowed in Client Components'
)
})
it('should error for styled-jsx imports on server side', async () => {
const html = await renderViaHTTP(next.url, '/server-with-errors/styled-jsx')
expect(html).toContain(
'This module cannot be imported from a Server Component module. It should only be used from a Client Component.'
)
})
})
import JSXStyle from 'styled-jsx/style'
export default function Page() {
return <JSXStyle>{`p{color:red}`}</JSXStyle>
}
module.exports = {
experimental: { appDir: true },
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment