Unverified Commit 5d8aedcf authored by Benjamin Woodruff's avatar Benjamin Woodruff Committed by GitHub

fix(rustdoc): Fix rustdoc warnings, block on rustdoc failures in CI (#76448)

When we break rustdoc, it causes warnings on every PR, e.g:

![Screenshot 2025-02-24 at
1.38.28 PM.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/HAZVitxRNnZz8QMiPn4a/a368e9a5-4ca6-4b3a-913e-df68aa038b7f.png)

...so we should either not check the rustdocs at all, or block on them.
This makes them blocking.
parent 83610c6a
...@@ -164,7 +164,7 @@ jobs: ...@@ -164,7 +164,7 @@ jobs:
stepName: 'rust-check' stepName: 'rust-check'
secrets: inherit secrets: inherit
rust-doc-check: rustdoc-check:
name: rustdoc check name: rustdoc check
needs: ['changes', 'build-next'] needs: ['changes', 'build-next']
if: ${{ needs.changes.outputs.docs-only == 'false' }} if: ${{ needs.changes.outputs.docs-only == 'false' }}
...@@ -175,7 +175,7 @@ jobs: ...@@ -175,7 +175,7 @@ jobs:
skipInstallBuild: 'yes' skipInstallBuild: 'yes'
skipNativeBuild: 'yes' skipNativeBuild: 'yes'
afterBuild: ./scripts/deploy-turbopack-docs.sh afterBuild: ./scripts/deploy-turbopack-docs.sh
stepName: 'rust-doc-check' stepName: 'rustdoc-check'
secrets: inherit secrets: inherit
ast-grep: ast-grep:
...@@ -635,6 +635,7 @@ jobs: ...@@ -635,6 +635,7 @@ jobs:
'test-ppr-integration', 'test-ppr-integration',
'test-cargo-unit', 'test-cargo-unit',
'rust-check', 'rust-check',
'rustdoc-check',
'test-next-swc-wasm', 'test-next-swc-wasm',
'test-turbopack-dev', 'test-turbopack-dev',
'test-turbopack-integration', 'test-turbopack-integration',
......
...@@ -1010,7 +1010,7 @@ pub fn project_hmr_identifiers_subscribe( ...@@ -1010,7 +1010,7 @@ pub fn project_hmr_identifiers_subscribe(
) )
} }
enum UpdateMessage { pub enum UpdateMessage {
Start, Start,
End(UpdateInfo), End(UpdateInfo),
} }
......
...@@ -495,8 +495,8 @@ impl ProjectContainer { ...@@ -495,8 +495,8 @@ impl ProjectContainer {
self.project().hmr_identifiers() self.project().hmr_identifiers()
} }
/// Gets a source map for a particular `file_path`. If `dev` mode is /// Gets a source map for a particular `file_path`. If `dev` mode is disabled, this will always
/// disabled, this will always return [`OptionSourceMap::none`]. /// return [`OptionStringifiedSourceMap::none`].
#[turbo_tasks::function] #[turbo_tasks::function]
pub fn get_source_map( pub fn get_source_map(
&self, &self,
......
...@@ -141,13 +141,12 @@ pub async fn foreign_code_context_condition( ...@@ -141,13 +141,12 @@ pub async fn foreign_code_context_condition(
Ok(result) Ok(result)
} }
/// Determines if the module is an internal asset (i.e overlay, fallback) coming /// Determines if the module is an internal asset (i.e overlay, fallback) coming from the embedded
/// from the embedded FS, don't apply user defined transforms. /// FS, don't apply user defined transforms.
/// //
/// [TODO] turbopack specific embed fs should be handled by internals of // TODO: Turbopack specific embed fs paths should be handled by internals of Turbopack itself and
/// turbopack itself and user config should not try to leak this. However, // user config should not try to leak this. However, currently we apply few transform options
/// currently we apply few transform options subject to next.js's configuration // subject to Next.js's configuration even if it's embedded assets.
/// even if it's embedded assets.
pub async fn internal_assets_conditions() -> Result<ContextCondition> { pub async fn internal_assets_conditions() -> Result<ContextCondition> {
Ok(ContextCondition::any(vec![ Ok(ContextCondition::any(vec![
ContextCondition::InPath(next_js_fs().root().to_resolved().await?), ContextCondition::InPath(next_js_fs().root().to_resolved().await?),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment