Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
5f47bb15
Unverified
Commit
5f47bb15
authored
Jan 29, 2025
by
Tobias Koppers
Committed by
GitHub
Jan 29, 2025
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[Turbopack] only the first task read need to be strongly consistent (#75435)
### What? see code comment
parent
c97dff9b
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
3 deletions
+6
-3
raw_vc.rs
turbopack/crates/turbo-tasks/src/raw_vc.rs
+6
-3
No files found.
turbopack/crates/turbo-tasks/src/raw_vc.rs
View file @
5f47bb15
...
...
@@ -209,7 +209,7 @@ impl RawVc {
self
.resolve_inner
(
ReadConsistency
::
Strong
)
.await
}
async
fn
resolve_inner
(
self
,
consistency
:
ReadConsistency
)
->
Result
<
RawVc
>
{
async
fn
resolve_inner
(
self
,
mut
consistency
:
ReadConsistency
)
->
Result
<
RawVc
>
{
let
tt
=
turbo_tasks
();
let
mut
current
=
self
;
let
mut
notified
=
false
;
...
...
@@ -221,6 +221,10 @@ impl RawVc {
notified
=
true
;
}
current
=
read_task_output
(
&*
tt
,
task
,
consistency
)
.await
?
;
// We no longer need to read strongly consistent, as any Vc returned
// from the first task will be inside of the scope of the first
// task. So it's already strongly consistent.
consistency
=
ReadConsistency
::
Eventual
;
}
RawVc
::
TaskCell
(
_
,
_
)
=>
return
Ok
(
current
),
RawVc
::
LocalOutput
(
task_id
,
local_cell_id
)
=>
{
...
...
@@ -396,8 +400,7 @@ impl Future for ReadRawVcFuture {
Ok
(
Ok
(
vc
))
=>
{
// We no longer need to read strongly consistent, as any Vc returned
// from the first task will be inside of the scope of the first
// task. So it's already strongly
// consistent.
// task. So it's already strongly consistent.
this
.consistency
=
ReadConsistency
::
Eventual
;
this
.current
=
vc
;
continue
'outer
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment