Unverified Commit 600238f0 authored by Steven's avatar Steven Committed by GitHub

breaking(next/image)!: remove 16px from default `images.imageSizes` config (#84647)

We took a look at unique Next.js projects that have one or more requests
for a specific image size and here are the findings as seen from the
Image Optimization API:

- `w=16` 4.2%
- `w=32` 17.1%
- `w=48` 21.4%
- `w=64` 22.6%
- `w=96` 25.8%
- `w=128` 29.5%
- `w=256` 46.5%
- `w=384` 35.1%
- `w=640` 57.2%

Only 4.2% of Next.js projects ever made a request to a 16px width image.
This is low enough to remove from the default configuration so that all
other projects can benefit from reduced html
[srcset](https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/srcset)
and fewer variations exposed from the backend API.

You might think that this means few developers are using `<Image
width={16} />` but it probably means that most displays nowadays use
devicePixelRatio 2 meaning that specifying a 16px image width will
actually fetch the 32px width to ensure it won't looking blurry on your
retina display.

BREAKING CHANGE: this is technically a breaking change but it won't
cause apps to stop working, its just 4% of them may have some requests
serve a 32px image instead of 16px. Those apps can of course opt in by
changing their `images.imageSizes` config back to allowing 16.
parent 79e78381
...@@ -22,7 +22,7 @@ ...@@ -22,7 +22,7 @@
"analyticsId": "", "analyticsId": "",
"images": { "images": {
"deviceSizes": [640, 750, 828, 1080, 1200, 1920, 2048, 3840], "deviceSizes": [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
"imageSizes": [16, 32, 48, 64, 96, 128, 256, 384], "imageSizes": [32, 48, 64, 96, 128, 256, 384],
"path": "/_next/image", "path": "/_next/image",
"loader": "default", "loader": "default",
"loaderFile": "", "loaderFile": "",
......
...@@ -466,7 +466,7 @@ impl Default for ImageConfig { ...@@ -466,7 +466,7 @@ impl Default for ImageConfig {
// https://github.com/vercel/next.js/blob/327634eb/packages/next/shared/lib/image-config.ts#L100-L114 // https://github.com/vercel/next.js/blob/327634eb/packages/next/shared/lib/image-config.ts#L100-L114
Self { Self {
device_sizes: vec![640, 750, 828, 1080, 1200, 1920, 2048, 3840], device_sizes: vec![640, 750, 828, 1080, 1200, 1920, 2048, 3840],
image_sizes: vec![16, 32, 48, 64, 96, 128, 256, 384], image_sizes: vec![32, 48, 64, 96, 128, 256, 384],
path: "/_next/image".to_string(), path: "/_next/image".to_string(),
loader: ImageLoader::Default, loader: ImageLoader::Default,
loader_file: None, loader_file: None,
......
...@@ -684,7 +684,7 @@ If no configuration is provided, the default below is used: ...@@ -684,7 +684,7 @@ If no configuration is provided, the default below is used:
```js filename="next.config.js" ```js filename="next.config.js"
module.exports = { module.exports = {
images: { images: {
imageSizes: [16, 32, 48, 64, 96, 128, 256, 384], imageSizes: [32, 48, 64, 96, 128, 256, 384],
}, },
} }
``` ```
......
...@@ -497,7 +497,7 @@ If no configuration is provided, the default below is used. ...@@ -497,7 +497,7 @@ If no configuration is provided, the default below is used.
```js filename="next.config.js" ```js filename="next.config.js"
module.exports = { module.exports = {
images: { images: {
imageSizes: [16, 32, 48, 64, 96, 128, 256, 384], imageSizes: [32, 48, 64, 96, 128, 256, 384],
}, },
} }
``` ```
......
...@@ -16,7 +16,7 @@ module.exports = { ...@@ -16,7 +16,7 @@ module.exports = {
// limit of 25 deviceSizes values // limit of 25 deviceSizes values
deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840], deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
// limit of 25 imageSizes values // limit of 25 imageSizes values
imageSizes: [16, 32, 48, 64, 96, 128, 256, 384], imageSizes: [32, 48, 64, 96, 128, 256, 384],
// limit of 50 domains values (deprecated) // limit of 50 domains values (deprecated)
domains: [], domains: [],
// path prefix for Image Optimization API, useful with `loader` // path prefix for Image Optimization API, useful with `loader`
......
...@@ -129,7 +129,7 @@ export type ImageConfig = Partial<ImageConfigComplete> ...@@ -129,7 +129,7 @@ export type ImageConfig = Partial<ImageConfigComplete>
export const imageConfigDefault: ImageConfigComplete = { export const imageConfigDefault: ImageConfigComplete = {
deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840], deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
imageSizes: [16, 32, 48, 64, 96, 128, 256, 384], imageSizes: [32, 48, 64, 96, 128, 256, 384],
path: '/_next/image', path: '/_next/image',
loader: 'default', loader: 'default',
loaderFile: '', loaderFile: '',
......
...@@ -344,7 +344,7 @@ function runTests(mode) { ...@@ -344,7 +344,7 @@ function runTests(mode) {
return 'success' return 'success'
}, 'success') }, 'success')
expect(await browser.elementById(id).getAttribute('srcset')).toBe( expect(await browser.elementById(id).getAttribute('srcset')).toBe(
'/docs/_next/image?url=%2Fdocs%2Fwide.png&w=16&q=75 16w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=32&q=75 32w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=48&q=75 48w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=64&q=75 64w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=96&q=75 96w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=128&q=75 128w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=256&q=75 256w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=384&q=75 384w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=640&q=75 640w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=750&q=75 750w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=828&q=75 828w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=1080&q=75 1080w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=1200&q=75 1200w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=1920&q=75 1920w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=2048&q=75 2048w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=3840&q=75 3840w' '/docs/_next/image?url=%2Fdocs%2Fwide.png&w=32&q=75 32w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=48&q=75 48w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=64&q=75 64w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=96&q=75 96w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=128&q=75 128w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=256&q=75 256w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=384&q=75 384w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=640&q=75 640w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=750&q=75 750w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=828&q=75 828w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=1080&q=75 1080w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=1200&q=75 1200w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=1920&q=75 1920w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=2048&q=75 2048w, /docs/_next/image?url=%2Fdocs%2Fwide.png&w=3840&q=75 3840w'
) )
expect(await browser.elementById(id).getAttribute('sizes')).toBe( expect(await browser.elementById(id).getAttribute('sizes')).toBe(
'(max-width: 2048px) 1200px, 3840px' '(max-width: 2048px) 1200px, 3840px'
......
...@@ -708,7 +708,7 @@ function runTests(mode) { ...@@ -708,7 +708,7 @@ function runTests(mode) {
return browser.eval( return browser.eval(
`document.querySelector('#fill4').getAttribute('srcset')` `document.querySelector('#fill4').getAttribute('srcset')`
) )
}, '/_next/image?url=%2Fwide.png&w=16&q=75 16w, /_next/image?url=%2Fwide.png&w=32&q=75 32w, /_next/image?url=%2Fwide.png&w=48&q=75 48w, /_next/image?url=%2Fwide.png&w=64&q=75 64w, /_next/image?url=%2Fwide.png&w=96&q=75 96w, /_next/image?url=%2Fwide.png&w=128&q=75 128w, /_next/image?url=%2Fwide.png&w=256&q=75 256w, /_next/image?url=%2Fwide.png&w=384&q=75 384w, /_next/image?url=%2Fwide.png&w=640&q=75 640w, /_next/image?url=%2Fwide.png&w=750&q=75 750w, /_next/image?url=%2Fwide.png&w=828&q=75 828w, /_next/image?url=%2Fwide.png&w=1080&q=75 1080w, /_next/image?url=%2Fwide.png&w=1200&q=75 1200w, /_next/image?url=%2Fwide.png&w=1920&q=75 1920w, /_next/image?url=%2Fwide.png&w=2048&q=75 2048w, /_next/image?url=%2Fwide.png&w=3840&q=75 3840w') }, '/_next/image?url=%2Fwide.png&w=32&q=75 32w, /_next/image?url=%2Fwide.png&w=48&q=75 48w, /_next/image?url=%2Fwide.png&w=64&q=75 64w, /_next/image?url=%2Fwide.png&w=96&q=75 96w, /_next/image?url=%2Fwide.png&w=128&q=75 128w, /_next/image?url=%2Fwide.png&w=256&q=75 256w, /_next/image?url=%2Fwide.png&w=384&q=75 384w, /_next/image?url=%2Fwide.png&w=640&q=75 640w, /_next/image?url=%2Fwide.png&w=750&q=75 750w, /_next/image?url=%2Fwide.png&w=828&q=75 828w, /_next/image?url=%2Fwide.png&w=1080&q=75 1080w, /_next/image?url=%2Fwide.png&w=1200&q=75 1200w, /_next/image?url=%2Fwide.png&w=1920&q=75 1920w, /_next/image?url=%2Fwide.png&w=2048&q=75 2048w, /_next/image?url=%2Fwide.png&w=3840&q=75 3840w')
} finally { } finally {
if (browser) { if (browser) {
await browser.close() await browser.close()
...@@ -732,7 +732,7 @@ function runTests(mode) { ...@@ -732,7 +732,7 @@ function runTests(mode) {
return 'success' return 'success'
}, 'success') }, 'success')
expect(await browser.elementById(id).getAttribute('srcset')).toBe( expect(await browser.elementById(id).getAttribute('srcset')).toBe(
'/_next/image?url=%2Fwide.png&w=16&q=75 16w, /_next/image?url=%2Fwide.png&w=32&q=75 32w, /_next/image?url=%2Fwide.png&w=48&q=75 48w, /_next/image?url=%2Fwide.png&w=64&q=75 64w, /_next/image?url=%2Fwide.png&w=96&q=75 96w, /_next/image?url=%2Fwide.png&w=128&q=75 128w, /_next/image?url=%2Fwide.png&w=256&q=75 256w, /_next/image?url=%2Fwide.png&w=384&q=75 384w, /_next/image?url=%2Fwide.png&w=640&q=75 640w, /_next/image?url=%2Fwide.png&w=750&q=75 750w, /_next/image?url=%2Fwide.png&w=828&q=75 828w, /_next/image?url=%2Fwide.png&w=1080&q=75 1080w, /_next/image?url=%2Fwide.png&w=1200&q=75 1200w, /_next/image?url=%2Fwide.png&w=1920&q=75 1920w, /_next/image?url=%2Fwide.png&w=2048&q=75 2048w, /_next/image?url=%2Fwide.png&w=3840&q=75 3840w' '/_next/image?url=%2Fwide.png&w=32&q=75 32w, /_next/image?url=%2Fwide.png&w=48&q=75 48w, /_next/image?url=%2Fwide.png&w=64&q=75 64w, /_next/image?url=%2Fwide.png&w=96&q=75 96w, /_next/image?url=%2Fwide.png&w=128&q=75 128w, /_next/image?url=%2Fwide.png&w=256&q=75 256w, /_next/image?url=%2Fwide.png&w=384&q=75 384w, /_next/image?url=%2Fwide.png&w=640&q=75 640w, /_next/image?url=%2Fwide.png&w=750&q=75 750w, /_next/image?url=%2Fwide.png&w=828&q=75 828w, /_next/image?url=%2Fwide.png&w=1080&q=75 1080w, /_next/image?url=%2Fwide.png&w=1200&q=75 1200w, /_next/image?url=%2Fwide.png&w=1920&q=75 1920w, /_next/image?url=%2Fwide.png&w=2048&q=75 2048w, /_next/image?url=%2Fwide.png&w=3840&q=75 3840w'
) )
expect(await browser.elementById(id).getAttribute('sizes')).toBe( expect(await browser.elementById(id).getAttribute('sizes')).toBe(
'(max-width: 2048px) 1200px, 3840px' '(max-width: 2048px) 1200px, 3840px'
......
...@@ -80,7 +80,7 @@ function runTests(mode: 'dev' | 'server') { ...@@ -80,7 +80,7 @@ function runTests(mode: 'dev' | 'server') {
disableStaticImages: false, disableStaticImages: false,
domains: [], domains: [],
formats: ['image/webp'], formats: ['image/webp'],
imageSizes: [16, 32, 48, 64, 96, 128, 256, 384], imageSizes: [32, 48, 64, 96, 128, 256, 384],
loader: 'default', loader: 'default',
loaderFile: '', loaderFile: '',
remotePatterns: [], remotePatterns: [],
...@@ -100,8 +100,8 @@ function runTests(mode: 'dev' | 'server') { ...@@ -100,8 +100,8 @@ function runTests(mode: 'dev' | 'server') {
path: '/_next/image', path: '/_next/image',
qualities: [75], qualities: [75],
sizes: [ sizes: [
640, 750, 828, 1080, 1200, 1920, 2048, 3840, 16, 32, 48, 64, 96, 640, 750, 828, 1080, 1200, 1920, 2048, 3840, 32, 48, 64, 96, 128,
128, 256, 384, 256, 384,
], ],
unoptimized: false, unoptimized: false,
}, },
......
...@@ -97,7 +97,7 @@ function runTests(mode: 'dev' | 'server') { ...@@ -97,7 +97,7 @@ function runTests(mode: 'dev' | 'server') {
disableStaticImages: false, disableStaticImages: false,
domains: [], domains: [],
formats: ['image/webp'], formats: ['image/webp'],
imageSizes: [16, 32, 48, 64, 96, 128, 256, 384], imageSizes: [32, 48, 64, 96, 128, 256, 384],
loader: 'default', loader: 'default',
loaderFile: '', loaderFile: '',
remotePatterns: [], remotePatterns: [],
...@@ -106,8 +106,8 @@ function runTests(mode: 'dev' | 'server') { ...@@ -106,8 +106,8 @@ function runTests(mode: 'dev' | 'server') {
path: '/_next/image', path: '/_next/image',
qualities: [42, 69, 88], qualities: [42, 69, 88],
sizes: [ sizes: [
640, 750, 828, 1080, 1200, 1920, 2048, 3840, 16, 32, 48, 64, 96, 640, 750, 828, 1080, 1200, 1920, 2048, 3840, 32, 48, 64, 96, 128,
128, 256, 384, 256, 384,
], ],
unoptimized: false, unoptimized: false,
}, },
......
...@@ -753,7 +753,7 @@ function runTests(mode: 'dev' | 'server') { ...@@ -753,7 +753,7 @@ function runTests(mode: 'dev' | 'server') {
'/_next/image?url=%2Fwide.png&w=3840&q=75' '/_next/image?url=%2Fwide.png&w=3840&q=75'
) )
expect(await browser.elementById(id).getAttribute('srcset')).toBe( expect(await browser.elementById(id).getAttribute('srcset')).toBe(
'/_next/image?url=%2Fwide.png&w=16&q=75 16w, /_next/image?url=%2Fwide.png&w=32&q=75 32w, /_next/image?url=%2Fwide.png&w=48&q=75 48w, /_next/image?url=%2Fwide.png&w=64&q=75 64w, /_next/image?url=%2Fwide.png&w=96&q=75 96w, /_next/image?url=%2Fwide.png&w=128&q=75 128w, /_next/image?url=%2Fwide.png&w=256&q=75 256w, /_next/image?url=%2Fwide.png&w=384&q=75 384w, /_next/image?url=%2Fwide.png&w=640&q=75 640w, /_next/image?url=%2Fwide.png&w=750&q=75 750w, /_next/image?url=%2Fwide.png&w=828&q=75 828w, /_next/image?url=%2Fwide.png&w=1080&q=75 1080w, /_next/image?url=%2Fwide.png&w=1200&q=75 1200w, /_next/image?url=%2Fwide.png&w=1920&q=75 1920w, /_next/image?url=%2Fwide.png&w=2048&q=75 2048w, /_next/image?url=%2Fwide.png&w=3840&q=75 3840w' '/_next/image?url=%2Fwide.png&w=32&q=75 32w, /_next/image?url=%2Fwide.png&w=48&q=75 48w, /_next/image?url=%2Fwide.png&w=64&q=75 64w, /_next/image?url=%2Fwide.png&w=96&q=75 96w, /_next/image?url=%2Fwide.png&w=128&q=75 128w, /_next/image?url=%2Fwide.png&w=256&q=75 256w, /_next/image?url=%2Fwide.png&w=384&q=75 384w, /_next/image?url=%2Fwide.png&w=640&q=75 640w, /_next/image?url=%2Fwide.png&w=750&q=75 750w, /_next/image?url=%2Fwide.png&w=828&q=75 828w, /_next/image?url=%2Fwide.png&w=1080&q=75 1080w, /_next/image?url=%2Fwide.png&w=1200&q=75 1200w, /_next/image?url=%2Fwide.png&w=1920&q=75 1920w, /_next/image?url=%2Fwide.png&w=2048&q=75 2048w, /_next/image?url=%2Fwide.png&w=3840&q=75 3840w'
) )
expect(await browser.elementById(id).getAttribute('sizes')).toBe( expect(await browser.elementById(id).getAttribute('sizes')).toBe(
'(max-width: 2048px) 1200px, 3840px' '(max-width: 2048px) 1200px, 3840px'
...@@ -800,7 +800,7 @@ function runTests(mode: 'dev' | 'server') { ...@@ -800,7 +800,7 @@ function runTests(mode: 'dev' | 'server') {
'1200' '1200'
) )
expect(await browser.elementById('img2').getAttribute('srcset')).toBe( expect(await browser.elementById('img2').getAttribute('srcset')).toBe(
`/_next/image?url=%2Fwide.png&w=16&q=75 16w, /_next/image?url=%2Fwide.png&w=32&q=75 32w, /_next/image?url=%2Fwide.png&w=48&q=75 48w, /_next/image?url=%2Fwide.png&w=64&q=75 64w, /_next/image?url=%2Fwide.png&w=96&q=75 96w, /_next/image?url=%2Fwide.png&w=128&q=75 128w, /_next/image?url=%2Fwide.png&w=256&q=75 256w, /_next/image?url=%2Fwide.png&w=384&q=75 384w, /_next/image?url=%2Fwide.png&w=640&q=75 640w, /_next/image?url=%2Fwide.png&w=750&q=75 750w, /_next/image?url=%2Fwide.png&w=828&q=75 828w, /_next/image?url=%2Fwide.png&w=1080&q=75 1080w, /_next/image?url=%2Fwide.png&w=1200&q=75 1200w, /_next/image?url=%2Fwide.png&w=1920&q=75 1920w, /_next/image?url=%2Fwide.png&w=2048&q=75 2048w, /_next/image?url=%2Fwide.png&w=3840&q=75 3840w` `/_next/image?url=%2Fwide.png&w=32&q=75 32w, /_next/image?url=%2Fwide.png&w=48&q=75 48w, /_next/image?url=%2Fwide.png&w=64&q=75 64w, /_next/image?url=%2Fwide.png&w=96&q=75 96w, /_next/image?url=%2Fwide.png&w=128&q=75 128w, /_next/image?url=%2Fwide.png&w=256&q=75 256w, /_next/image?url=%2Fwide.png&w=384&q=75 384w, /_next/image?url=%2Fwide.png&w=640&q=75 640w, /_next/image?url=%2Fwide.png&w=750&q=75 750w, /_next/image?url=%2Fwide.png&w=828&q=75 828w, /_next/image?url=%2Fwide.png&w=1080&q=75 1080w, /_next/image?url=%2Fwide.png&w=1200&q=75 1200w, /_next/image?url=%2Fwide.png&w=1920&q=75 1920w, /_next/image?url=%2Fwide.png&w=2048&q=75 2048w, /_next/image?url=%2Fwide.png&w=3840&q=75 3840w`
) )
expect(await browser.elementById('img2').getAttribute('loading')).toBe( expect(await browser.elementById('img2').getAttribute('loading')).toBe(
'lazy' 'lazy'
...@@ -1783,7 +1783,7 @@ function runTests(mode: 'dev' | 'server') { ...@@ -1783,7 +1783,7 @@ function runTests(mode: 'dev' | 'server') {
disableStaticImages: false, disableStaticImages: false,
domains: [], domains: [],
formats: ['image/webp'], formats: ['image/webp'],
imageSizes: [16, 32, 48, 64, 96, 128, 256, 384], imageSizes: [32, 48, 64, 96, 128, 256, 384],
loader: 'default', loader: 'default',
loaderFile: '', loaderFile: '',
remotePatterns: [], remotePatterns: [],
...@@ -1792,8 +1792,8 @@ function runTests(mode: 'dev' | 'server') { ...@@ -1792,8 +1792,8 @@ function runTests(mode: 'dev' | 'server') {
path: '/_next/image', path: '/_next/image',
qualities: [75], qualities: [75],
sizes: [ sizes: [
640, 750, 828, 1080, 1200, 1920, 2048, 3840, 16, 32, 48, 64, 96, 640, 750, 828, 1080, 1200, 1920, 2048, 3840, 32, 48, 64, 96, 128,
128, 256, 384, 256, 384,
], ],
unoptimized: false, unoptimized: false,
}, },
......
...@@ -752,7 +752,7 @@ function runTests(mode) { ...@@ -752,7 +752,7 @@ function runTests(mode) {
'/_next/image?url=%2Fwide.png&w=3840&q=75' '/_next/image?url=%2Fwide.png&w=3840&q=75'
) )
expect(await browser.elementById(id).getAttribute('srcset')).toBe( expect(await browser.elementById(id).getAttribute('srcset')).toBe(
'/_next/image?url=%2Fwide.png&w=16&q=75 16w, /_next/image?url=%2Fwide.png&w=32&q=75 32w, /_next/image?url=%2Fwide.png&w=48&q=75 48w, /_next/image?url=%2Fwide.png&w=64&q=75 64w, /_next/image?url=%2Fwide.png&w=96&q=75 96w, /_next/image?url=%2Fwide.png&w=128&q=75 128w, /_next/image?url=%2Fwide.png&w=256&q=75 256w, /_next/image?url=%2Fwide.png&w=384&q=75 384w, /_next/image?url=%2Fwide.png&w=640&q=75 640w, /_next/image?url=%2Fwide.png&w=750&q=75 750w, /_next/image?url=%2Fwide.png&w=828&q=75 828w, /_next/image?url=%2Fwide.png&w=1080&q=75 1080w, /_next/image?url=%2Fwide.png&w=1200&q=75 1200w, /_next/image?url=%2Fwide.png&w=1920&q=75 1920w, /_next/image?url=%2Fwide.png&w=2048&q=75 2048w, /_next/image?url=%2Fwide.png&w=3840&q=75 3840w' '/_next/image?url=%2Fwide.png&w=32&q=75 32w, /_next/image?url=%2Fwide.png&w=48&q=75 48w, /_next/image?url=%2Fwide.png&w=64&q=75 64w, /_next/image?url=%2Fwide.png&w=96&q=75 96w, /_next/image?url=%2Fwide.png&w=128&q=75 128w, /_next/image?url=%2Fwide.png&w=256&q=75 256w, /_next/image?url=%2Fwide.png&w=384&q=75 384w, /_next/image?url=%2Fwide.png&w=640&q=75 640w, /_next/image?url=%2Fwide.png&w=750&q=75 750w, /_next/image?url=%2Fwide.png&w=828&q=75 828w, /_next/image?url=%2Fwide.png&w=1080&q=75 1080w, /_next/image?url=%2Fwide.png&w=1200&q=75 1200w, /_next/image?url=%2Fwide.png&w=1920&q=75 1920w, /_next/image?url=%2Fwide.png&w=2048&q=75 2048w, /_next/image?url=%2Fwide.png&w=3840&q=75 3840w'
) )
expect(await browser.elementById(id).getAttribute('sizes')).toBe( expect(await browser.elementById(id).getAttribute('sizes')).toBe(
'(max-width: 2048px) 1200px, 3840px' '(max-width: 2048px) 1200px, 3840px'
...@@ -799,7 +799,7 @@ function runTests(mode) { ...@@ -799,7 +799,7 @@ function runTests(mode) {
'1200' '1200'
) )
expect(await browser.elementById('img2').getAttribute('srcset')).toBe( expect(await browser.elementById('img2').getAttribute('srcset')).toBe(
`/_next/image?url=%2Fwide.png&w=16&q=75 16w, /_next/image?url=%2Fwide.png&w=32&q=75 32w, /_next/image?url=%2Fwide.png&w=48&q=75 48w, /_next/image?url=%2Fwide.png&w=64&q=75 64w, /_next/image?url=%2Fwide.png&w=96&q=75 96w, /_next/image?url=%2Fwide.png&w=128&q=75 128w, /_next/image?url=%2Fwide.png&w=256&q=75 256w, /_next/image?url=%2Fwide.png&w=384&q=75 384w, /_next/image?url=%2Fwide.png&w=640&q=75 640w, /_next/image?url=%2Fwide.png&w=750&q=75 750w, /_next/image?url=%2Fwide.png&w=828&q=75 828w, /_next/image?url=%2Fwide.png&w=1080&q=75 1080w, /_next/image?url=%2Fwide.png&w=1200&q=75 1200w, /_next/image?url=%2Fwide.png&w=1920&q=75 1920w, /_next/image?url=%2Fwide.png&w=2048&q=75 2048w, /_next/image?url=%2Fwide.png&w=3840&q=75 3840w` `/_next/image?url=%2Fwide.png&w=32&q=75 32w, /_next/image?url=%2Fwide.png&w=48&q=75 48w, /_next/image?url=%2Fwide.png&w=64&q=75 64w, /_next/image?url=%2Fwide.png&w=96&q=75 96w, /_next/image?url=%2Fwide.png&w=128&q=75 128w, /_next/image?url=%2Fwide.png&w=256&q=75 256w, /_next/image?url=%2Fwide.png&w=384&q=75 384w, /_next/image?url=%2Fwide.png&w=640&q=75 640w, /_next/image?url=%2Fwide.png&w=750&q=75 750w, /_next/image?url=%2Fwide.png&w=828&q=75 828w, /_next/image?url=%2Fwide.png&w=1080&q=75 1080w, /_next/image?url=%2Fwide.png&w=1200&q=75 1200w, /_next/image?url=%2Fwide.png&w=1920&q=75 1920w, /_next/image?url=%2Fwide.png&w=2048&q=75 2048w, /_next/image?url=%2Fwide.png&w=3840&q=75 3840w`
) )
expect(await browser.elementById('img2').getAttribute('loading')).toBe( expect(await browser.elementById('img2').getAttribute('loading')).toBe(
'lazy' 'lazy'
......
...@@ -80,7 +80,7 @@ function runTests(mode: 'server' | 'dev') { ...@@ -80,7 +80,7 @@ function runTests(mode: 'server' | 'dev') {
disableStaticImages: false, disableStaticImages: false,
domains: [], domains: [],
formats: ['image/webp'], formats: ['image/webp'],
imageSizes: [16, 32, 48, 64, 96, 128, 256, 384], imageSizes: [32, 48, 64, 96, 128, 256, 384],
loader: 'default', loader: 'default',
loaderFile: '', loaderFile: '',
remotePatterns: [ remotePatterns: [
...@@ -98,8 +98,8 @@ function runTests(mode: 'server' | 'dev') { ...@@ -98,8 +98,8 @@ function runTests(mode: 'server' | 'dev') {
path: '/_next/image', path: '/_next/image',
qualities: [75], qualities: [75],
sizes: [ sizes: [
640, 750, 828, 1080, 1200, 1920, 2048, 3840, 16, 32, 48, 64, 96, 640, 750, 828, 1080, 1200, 1920, 2048, 3840, 32, 48, 64, 96, 128,
128, 256, 384, 256, 384,
], ],
unoptimized: false, unoptimized: false,
}, },
......
...@@ -105,7 +105,7 @@ function runTests(url: string, mode: 'dev' | 'server') { ...@@ -105,7 +105,7 @@ function runTests(url: string, mode: 'dev' | 'server') {
disableStaticImages: false, disableStaticImages: false,
domains: [], domains: [],
formats: ['image/webp'], formats: ['image/webp'],
imageSizes: [16, 32, 48, 64, 96, 128, 256, 384], imageSizes: [32, 48, 64, 96, 128, 256, 384],
loader: 'default', loader: 'default',
loaderFile: '', loaderFile: '',
remotePatterns: [], remotePatterns: [],
...@@ -114,8 +114,8 @@ function runTests(url: string, mode: 'dev' | 'server') { ...@@ -114,8 +114,8 @@ function runTests(url: string, mode: 'dev' | 'server') {
path: '/_next/image', path: '/_next/image',
qualities: [75], qualities: [75],
sizes: [ sizes: [
640, 750, 828, 1080, 1200, 1920, 2048, 3840, 16, 32, 48, 64, 96, 640, 750, 828, 1080, 1200, 1920, 2048, 3840, 32, 48, 64, 96, 128,
128, 256, 384, 256, 384,
], ],
unoptimized: true, unoptimized: true,
}, },
......
...@@ -254,6 +254,120 @@ describe('getImageProps()', () => { ...@@ -254,6 +254,120 @@ describe('getImageProps()', () => {
['src', '/_next/image?url=%2Ftest.png&w=256&q=75'], ['src', '/_next/image?url=%2Ftest.png&w=256&q=75'],
]) ])
}) })
it('should handle 16px image', async () => {
const { props } = getImageProps({
alt: 'a nice desc',
id: 'my-image',
src: '/test.png',
width: 16,
height: 16,
})
expect(warningMessages).toStrictEqual([])
expect(Object.entries(props)).toStrictEqual([
['alt', 'a nice desc'],
['id', 'my-image'],
['loading', 'lazy'],
['width', 16],
['height', 16],
['decoding', 'async'],
['style', { color: 'transparent' }],
['srcSet', '/_next/image?url=%2Ftest.png&w=32&q=75 1x'],
['src', '/_next/image?url=%2Ftest.png&w=32&q=75'],
])
})
it('should handle 32px image', async () => {
const { props } = getImageProps({
alt: 'a nice desc',
id: 'my-image',
src: '/test.png',
width: 32,
height: 32,
})
expect(warningMessages).toStrictEqual([])
expect(Object.entries(props)).toStrictEqual([
['alt', 'a nice desc'],
['id', 'my-image'],
['loading', 'lazy'],
['width', 32],
['height', 32],
['decoding', 'async'],
['style', { color: 'transparent' }],
[
'srcSet',
'/_next/image?url=%2Ftest.png&w=32&q=75 1x, /_next/image?url=%2Ftest.png&w=64&q=75 2x',
],
['src', '/_next/image?url=%2Ftest.png&w=64&q=75'],
])
})
it('should handle 256px image', async () => {
const { props } = getImageProps({
alt: 'a nice desc',
id: 'my-image',
src: '/test.png',
width: 256,
height: 256,
})
expect(warningMessages).toStrictEqual([])
expect(Object.entries(props)).toStrictEqual([
['alt', 'a nice desc'],
['id', 'my-image'],
['loading', 'lazy'],
['width', 256],
['height', 256],
['decoding', 'async'],
['style', { color: 'transparent' }],
[
'srcSet',
'/_next/image?url=%2Ftest.png&w=256&q=75 1x, /_next/image?url=%2Ftest.png&w=640&q=75 2x',
],
['src', '/_next/image?url=%2Ftest.png&w=640&q=75'],
])
})
it('should handle 512px image', async () => {
const { props } = getImageProps({
alt: 'a nice desc',
id: 'my-image',
src: '/test.png',
width: 512,
height: 512,
})
expect(warningMessages).toStrictEqual([])
expect(Object.entries(props)).toStrictEqual([
['alt', 'a nice desc'],
['id', 'my-image'],
['loading', 'lazy'],
['width', 512],
['height', 512],
['decoding', 'async'],
['style', { color: 'transparent' }],
[
'srcSet',
'/_next/image?url=%2Ftest.png&w=640&q=75 1x, /_next/image?url=%2Ftest.png&w=1080&q=75 2x',
],
['src', '/_next/image?url=%2Ftest.png&w=1080&q=75'],
])
})
it('should handle 3072px image', async () => {
const { props } = getImageProps({
alt: 'a nice desc',
id: 'my-image',
src: '/test.png',
width: 3072,
height: 3072,
})
expect(warningMessages).toStrictEqual([])
expect(Object.entries(props)).toStrictEqual([
['alt', 'a nice desc'],
['id', 'my-image'],
['loading', 'lazy'],
['width', 3072],
['height', 3072],
['decoding', 'async'],
['style', { color: 'transparent' }],
['srcSet', '/_next/image?url=%2Ftest.png&w=3840&q=75 1x'],
['src', '/_next/image?url=%2Ftest.png&w=3840&q=75'],
])
})
it('should handle sizes', async () => { it('should handle sizes', async () => {
const { props } = getImageProps({ const { props } = getImageProps({
alt: 'a nice desc', alt: 'a nice desc',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment