Unverified Commit 600bdb1e authored by Shu Ding's avatar Shu Ding Committed by GitHub

Remove RSC rendering from render (#39045)

(For context, the logic and tests have been moved to `app-render`.)

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
parent e955850d
This diff is collapsed.
module.exports = { module.exports = {}
experimental: {
serverComponents: true,
},
}
...@@ -34,7 +34,6 @@ server.listen(currentPort, (err) => { ...@@ -34,7 +34,6 @@ server.listen(currentPort, (err) => {
distDir: '.next', distDir: '.next',
experimental: { experimental: {
...defaultNextConfig.experimental, ...defaultNextConfig.experimental,
serverComponents: true,
}, },
}, },
}) })
......
...@@ -14,7 +14,7 @@ const react18Deps = { ...@@ -14,7 +14,7 @@ const react18Deps = {
'react-dom': '^18.0.0', 'react-dom': '^18.0.0',
} }
describe('react 18 streaming SSR and RSC in minimal mode', () => { describe('react 18 streaming SSR in minimal mode', () => {
let next: NextInstance let next: NextInstance
beforeAll(async () => { beforeAll(async () => {
...@@ -22,7 +22,7 @@ describe('react 18 streaming SSR and RSC in minimal mode', () => { ...@@ -22,7 +22,7 @@ describe('react 18 streaming SSR and RSC in minimal mode', () => {
next = await createNext({ next = await createNext({
files: { files: {
'pages/index.server.js': ` 'pages/index.js': `
export default function Page() { export default function Page() {
return <p>streaming</p> return <p>streaming</p>
} }
...@@ -33,7 +33,6 @@ describe('react 18 streaming SSR and RSC in minimal mode', () => { ...@@ -33,7 +33,6 @@ describe('react 18 streaming SSR and RSC in minimal mode', () => {
}, },
nextConfig: { nextConfig: {
experimental: { experimental: {
serverComponents: true,
runtime: 'nodejs', runtime: 'nodejs',
}, },
webpack(config, { nextRuntime }) { webpack(config, { nextRuntime }) {
...@@ -124,7 +123,7 @@ describe('react 18 streaming SSR with custom next configs', () => { ...@@ -124,7 +123,7 @@ describe('react 18 streaming SSR with custom next configs', () => {
}) })
}) })
describe('react 18 streaming SSR and RSC with custom server', () => { describe('react 18 streaming SSR with custom server', () => {
let next let next
let server let server
let appPort let appPort
...@@ -158,7 +157,7 @@ describe('react 18 streaming SSR and RSC with custom server', () => { ...@@ -158,7 +157,7 @@ describe('react 18 streaming SSR and RSC with custom server', () => {
await next.destroy() await next.destroy()
if (server) await killApp(server) if (server) await killApp(server)
}) })
it('should render rsc correctly under custom server', async () => { it('should render page correctly under custom server', async () => {
const html = await renderViaHTTP(appPort, '/') const html = await renderViaHTTP(appPort, '/')
expect(html).toContain('streaming') expect(html).toContain('streaming')
}) })
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment