Unverified Commit 63d81de6 authored by Jiachi Liu's avatar Jiachi Liu Committed by GitHub

test: add preconnect tests and move error tests (#46652)

* Add tests for `ReactDOM.preconnect | prefetchDNS | preload` usage
* Move mutate erroring tests to rsc-build-errors test suite
parent c6279129
export default function page(props) {
return <p>mutate</p>
}
export async function generateMetadata(props, parent) {
const parentMetadata = await parent
return {
...parentMetadata,
}
}
...@@ -379,5 +379,39 @@ createNextDescribe( ...@@ -379,5 +379,39 @@ createNextDescribe(
await cleanup() await cleanup()
}) })
it('should freeze parent resolved metadata to avoid mutating in generateMetadata', async () => {
const pagePath = 'app/metadata/mutate/page.js'
const content = `export default function page(props) {
return <p>mutate</p>
}
export async function generateMetadata(props, parent) {
const parentMetadata = await parent
parentMetadata.x = 1
return {
...parentMetadata,
}
}`
const { session, cleanup } = await sandbox(
next,
undefined,
'/metadata/mutate'
)
await session.patch(pagePath, content)
await check(
async () => ((await session.hasRedbox(true)) ? 'success' : 'fail'),
/success/
)
expect(await session.getRedboxDescription()).toContain(
'Cannot add property x, object is not extensible'
)
await cleanup()
})
} }
) )
'use client'
import ReactDOM from 'react-dom'
// NOTE: atm preload/prefetch/prefetchDNS are only supported in the SSR and client, not in RSC yet
export default function Client() {
// @ts-ignore
ReactDOM.preload('/preload-url', { as: 'script' })
// @ts-ignore
ReactDOM.preconnect('/preconnect-url', { crossOrigin: 'use-credentials' })
// @ts-ignore
ReactDOM.prefetchDNS('/dns-prefetch-url')
return null
}
import type { Metadata } from 'next' import type { Metadata } from 'next'
import Link from 'next/link' import Link from 'next/link'
import Client from './client'
export default function Page() { export default function Page() {
return ( return (
...@@ -11,6 +12,7 @@ export default function Page() { ...@@ -11,6 +12,7 @@ export default function Page() {
<Link href="/title-template/extra/inner" id="to-nested"> <Link href="/title-template/extra/inner" id="to-nested">
to /title-template/extra/inner to /title-template/extra/inner
</Link> </Link>
<Client />
</div> </div>
) )
} }
......
import { createNextDescribe } from 'e2e-utils' import { createNextDescribe } from 'e2e-utils'
import { check, hasRedbox, getRedboxDescription } from 'next-test-utils' import { check } from 'next-test-utils'
import { BrowserInterface } from 'test/lib/browsers/base' import { BrowserInterface } from 'test/lib/browsers/base'
createNextDescribe( createNextDescribe(
...@@ -152,6 +152,10 @@ createNextDescribe( ...@@ -152,6 +152,10 @@ createNextDescribe(
'format-detection', 'format-detection',
'telephone=no, address=no, email=no' 'telephone=no, address=no, email=no'
) )
await checkLink(browser, 'preconnect', '/preconnect-url')
await checkLink(browser, 'preload', '/preload-url')
await checkLink(browser, 'dns-prefetch', '/dns-prefetch-url')
}) })
it('should support apple related tags `itunes` and `appWebApp`', async () => { it('should support apple related tags `itunes` and `appWebApp`', async () => {
...@@ -342,40 +346,6 @@ createNextDescribe( ...@@ -342,40 +346,6 @@ createNextDescribe(
expect(resRedirect.status).toBe(307) expect(resRedirect.status).toBe(307)
}) })
if (isNextDev) {
it('should freeze parent resolved metadata to avoid mutating in generateMetadata', async () => {
const pagePath = 'app/mutate/page.tsx'
const content = `export default function page(props) {
return <p>mutate</p>
}
export async function generateMetadata(props, parent) {
const parentMetadata = await parent
parentMetadata.x = 1
return {
...parentMetadata,
}
}`
try {
await next.patchFile(pagePath, content)
const browser = await next.browser('/mutate')
await check(
async () =>
(await hasRedbox(browser, true)) ? 'success' : 'fail',
/success/
)
expect(await getRedboxDescription(browser)).toContain(
'Cannot add property x, object is not extensible'
)
} finally {
await next.deleteFile(pagePath)
}
})
}
it('should handle metadataBase for urls resolved as only URL type', async () => { it('should handle metadataBase for urls resolved as only URL type', async () => {
// including few urls in opengraph and alternates // including few urls in opengraph and alternates
const url$ = await next.render$('/metadata-base/url') const url$ = await next.render$('/metadata-base/url')
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment