Unverified Commit 663fa9cb authored by Hendrik Liebau's avatar Hendrik Liebau Committed by GitHub

Fix SWC and React versions for `14-2-1` branch (#73791)

- installs React v18 instead of latest in tests
- removes Next.js v15 references from lockfile
- installs "current" native SWC binaries instead of latest
parent ed78a4aa
This diff is collapsed.
......@@ -389,7 +389,7 @@ ${ENDGROUP}`)
// a starter Next.js install to re-use to speed up tests
// to avoid having to run yarn each time
console.log(`${GROUP}Creating Next.js install for isolated tests`)
const reactVersion = process.env.NEXT_TEST_REACT_VERSION || 'latest'
const reactVersion = process.env.NEXT_TEST_REACT_VERSION || '^18.2.0'
const { installDir, pkgPaths, tmpRepoDir } = await createNextInstall({
parentSpan: mockSpan(),
dependencies: {
......
......@@ -43,22 +43,22 @@ import fsp from 'fs/promises'
name: 'dummy-package',
version: '1.0.0',
optionalDependencies: {
'@next/swc-darwin-arm64': 'canary',
'@next/swc-darwin-x64': 'canary',
'@next/swc-linux-arm64-gnu': 'canary',
'@next/swc-linux-arm64-musl': 'canary',
'@next/swc-linux-x64-gnu': 'canary',
'@next/swc-linux-x64-musl': 'canary',
'@next/swc-win32-arm64-msvc': 'canary',
'@next/swc-win32-ia32-msvc': 'canary',
'@next/swc-win32-x64-msvc': 'canary',
'@next/swc-darwin-arm64': nextVersion,
'@next/swc-darwin-x64': nextVersion,
'@next/swc-linux-arm64-gnu': nextVersion,
'@next/swc-linux-arm64-musl': nextVersion,
'@next/swc-linux-x64-gnu': nextVersion,
'@next/swc-linux-x64-musl': nextVersion,
'@next/swc-win32-arm64-msvc': nextVersion,
'@next/swc-win32-ia32-msvc': nextVersion,
'@next/swc-win32-x64-msvc': nextVersion,
},
packageManager,
}
fs.writeFileSync(path.join(tmpdir, 'package.json'), JSON.stringify(pkgJson))
fs.writeFileSync(path.join(tmpdir, '.npmrc'), 'node-linker=hoisted')
let { stdout } = await execa('pnpm', ['add', 'next@canary'], {
let { stdout } = await execa('pnpm', ['add', `next@${nextVersion}`], {
cwd: tmpdir,
})
console.log(stdout)
......
......@@ -4,8 +4,8 @@
"license": "MIT",
"dependencies": {
"next": "latest",
"react": "latest",
"react-dom": "latest"
"react": "^18.2.0",
"react-dom": "^18.2.0"
},
"engines": {
"node": ">=18.17.0",
......
......@@ -8,8 +8,8 @@ describe('ReactRefresh app', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
skipStart: true,
})
......
......@@ -9,8 +9,8 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox app %s', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
skipStart: true,
})
......
......@@ -11,8 +11,8 @@ describe.skip('ReactRefreshLogBox scss app', () => {
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
sass: 'latest',
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
skipStart: true,
})
......
......@@ -15,8 +15,8 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox app %s', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
skipStart: true,
})
......
......@@ -9,8 +9,8 @@ describe.skip('ReactRefreshLogBox app', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
skipStart: true,
})
......
......@@ -7,8 +7,8 @@ describe('ReactRefreshModule app', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
skipStart: true,
})
......
......@@ -12,8 +12,8 @@ describe('ReactRefreshRegression app', () => {
'styled-components': '5.1.0',
'@next/mdx': 'canary',
'@mdx-js/loader': '0.18.0',
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
skipStart: true,
})
......
......@@ -8,8 +8,8 @@ describe('ReactRefreshRequire app', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
skipStart: true,
})
......
......@@ -7,8 +7,8 @@ describe('Component Stack in error overlay', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'component-stack')),
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
skipStart: true,
})
......
......@@ -29,8 +29,8 @@ describe('Error overlay - editor links', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
skipStart: true,
})
......
......@@ -7,8 +7,8 @@ describe('Error overlay - error message urls', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
skipStart: true,
})
......
......@@ -9,8 +9,8 @@ describe.each(['default', 'turbo'])('Error recovery app %s', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
skipStart: true,
})
......
......@@ -11,8 +11,8 @@ describe('Error overlay for hydration errors', () => {
const { next, isTurbopack } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
skipStart: true,
})
......
......@@ -8,8 +8,8 @@ describe('Error Overlay invalid imports', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
'server-only': 'latest',
'client-only': 'latest',
},
......
......@@ -8,8 +8,8 @@ describe('Error overlay - RSC build errors', () => {
const { next, isTurbopack } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'rsc-build-errors')),
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
skipStart: true,
})
......
......@@ -9,8 +9,8 @@ describe('Error Overlay for server components', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
skipStart: true,
})
......
......@@ -8,8 +8,8 @@ describe('Error overlay for hydration errors', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
skipStart: true,
})
......
......@@ -28,8 +28,8 @@ describe('Error Overlay for server components compiler errors in pages', () => {
const { next } = nextTestSetup({
files: {},
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
skipStart: true,
})
......
......@@ -10,7 +10,7 @@ createNextDescribe(
dependencies: {
mobx: '6.3.7',
typescript: 'latest',
'@types/react': 'latest',
'@types/react': '^18.2.0',
'@types/node': 'latest',
'mobx-react': '7.2.1',
},
......
......@@ -13,7 +13,7 @@ describe('correct tsconfig.json defaults', () => {
skipStart: true,
dependencies: {
typescript: 'latest',
'@types/react': 'latest',
'@types/react': '^18.2.0',
'@types/node': 'latest',
},
})
......
......@@ -36,7 +36,7 @@ describe('jsconfig-path-reloading', () => {
},
dependencies: {
typescript: 'latest',
'@types/react': 'latest',
'@types/react': '^18.2.0',
'@types/node': 'latest',
},
})
......
......@@ -9,8 +9,8 @@ createNextDescribe(
'pages/index.js': '',
},
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
'@next/font': 'canary',
},
skipStart: true,
......
......@@ -36,7 +36,7 @@ describe('tsconfig-path-reloading', () => {
},
dependencies: {
typescript: 'latest',
'@types/react': 'latest',
'@types/react': '^18.2.0',
'@types/node': 'latest',
},
})
......
......@@ -8,8 +8,8 @@ createNextDescribe(
files: join(__dirname, 'safe-origins'),
skipDeployment: true,
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
'server-only': 'latest',
},
// An arbitrary & random port.
......
......@@ -8,8 +8,8 @@ createNextDescribe(
files: join(__dirname, 'unsafe-origins'),
skipDeployment: true,
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
'server-only': 'latest',
},
},
......
......@@ -7,8 +7,8 @@ createNextDescribe(
skipStart: true,
skipDeployment: true,
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
'server-only': 'latest',
},
},
......
......@@ -7,8 +7,8 @@ createNextDescribe(
{
files: __dirname,
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
},
({ next }) => {
......
......@@ -8,9 +8,9 @@ createNextDescribe(
{
files: __dirname,
dependencies: {
react: 'latest',
react: '^18.2.0',
nanoid: 'latest',
'react-dom': 'latest',
'react-dom': '^18.2.0',
'server-only': 'latest',
},
},
......
......@@ -10,8 +10,8 @@ createNextDescribe(
files: __dirname,
skipDeployment: true,
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
'server-only': 'latest',
},
},
......
......@@ -19,9 +19,9 @@ createNextDescribe(
{
files: __dirname,
dependencies: {
react: 'latest',
react: '^18.2.0',
nanoid: 'latest',
'react-dom': 'latest',
'react-dom': '^18.2.0',
'server-only': 'latest',
},
},
......
......@@ -7,8 +7,8 @@ createNextDescribe(
skipDeployment: true,
dependencies: {
'@picocss/pico': '1.5.7',
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
sass: 'latest',
},
},
......
......@@ -8,8 +8,8 @@ createNextDescribe(
skipDeployment: true,
dependencies: {
'@picocss/pico': '1.5.7',
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
sass: 'latest',
'@next/mdx': 'canary',
},
......
......@@ -74,8 +74,8 @@ import stripAnsi from 'strip-ansi'
),
},
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
})
})
......@@ -128,8 +128,8 @@ import stripAnsi from 'strip-ansi'
),
},
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
})
})
......@@ -237,8 +237,8 @@ import stripAnsi from 'strip-ansi'
),
},
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
})
......
......@@ -9,10 +9,10 @@ describe('navigation between pages and app dir', () => {
next = await createNext({
files: new FileRef(__dirname),
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
typescript: 'latest',
'@types/react': 'latest',
'@types/react': '^18.2.0',
'@types/node': 'latest',
},
})
......
......@@ -5,10 +5,10 @@ createNextDescribe(
{
files: __dirname,
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
typescript: 'latest',
'@types/react': 'latest',
'@types/react': '^18.2.0',
'@types/node': 'latest',
},
},
......
......@@ -17,8 +17,8 @@ describe('New Link Behavior with <a> child', () => {
},
dependencies: {
next: 'latest',
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
})
})
......
......@@ -24,8 +24,8 @@ describe('New Link Behavior with material-ui', () => {
'@mui/material': 'latest',
next: 'latest',
'prop-types': 'latest',
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
// Use minimum peer dep version instead of v9 of eslint to avoid breaking changes
eslint: '8.56.0',
'eslint-config-next': 'latest',
......
......@@ -21,8 +21,8 @@ describe('New Link Behavior with stitches', () => {
dependencies: {
'@stitches/react': '^1.2.6',
next: 'latest',
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
})
})
......
......@@ -30,8 +30,8 @@ describe('next/font/google with proxy', () => {
next = await createNext({
files: new FileRef(join(__dirname, 'with-proxy')),
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
env: {
http_proxy: 'http://localhost:' + PROXY_PORT,
......
......@@ -41,8 +41,8 @@ describe('beforeInteractive in document Head', () => {
`,
},
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
})
})
......@@ -101,8 +101,8 @@ describe('beforeInteractive in document body', () => {
`,
},
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
})
})
......@@ -150,8 +150,8 @@ describe('beforeInteractive in document body', () => {
},
// TODO: @housseindjirdeh: verify React 18 functionality
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
})
})
......@@ -201,8 +201,8 @@ describe('beforeInteractive in document body', () => {
`,
},
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
'@builder.io/partytown': '0.4.2',
},
})
......@@ -290,8 +290,8 @@ describe('beforeInteractive in document body', () => {
`,
},
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
'@builder.io/partytown': '0.4.2',
},
})
......@@ -406,8 +406,8 @@ describe('beforeInteractive in document body', () => {
},
dependencies: {
'@builder.io/partytown': '0.4.2',
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
})
})
......
......@@ -44,8 +44,8 @@ describe('Switchable runtime', () => {
next = await createNext({
files: new FileRef(__dirname),
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
},
})
context = {
......
......@@ -16,8 +16,8 @@ describe('transpile packages', () => {
next = await createNext({
files: new FileRef(path.join(__dirname, './npm')),
dependencies: {
react: 'latest',
'react-dom': 'latest',
react: '^18.2.0',
'react-dom': '^18.2.0',
sass: 'latest',
},
packageJson: {
......
......@@ -158,7 +158,7 @@ export class NextInstance {
}`
)
const reactVersion = process.env.NEXT_TEST_REACT_VERSION || 'latest'
const reactVersion = process.env.NEXT_TEST_REACT_VERSION || '^18.2.0'
const finalDependencies = {
react: reactVersion,
'react-dom': reactVersion,
......
......@@ -93,8 +93,8 @@ describe('eslint plugin deps', () => {
'eslint-plugin-import': 'latest',
'eslint-plugin-react': 'latest',
'@types/node': 'latest',
'@types/react': 'latest',
'@types/react-dom': 'latest',
'@types/react': '^18.2.0',
'@types/react-dom': '^18.2.0',
// Use minimum peer dep version instead of v9 of eslint to avoid breaking changes
eslint: '8.56.0',
'eslint-config-next': 'latest',
......
......@@ -30,7 +30,7 @@ describe('next/jest', () => {
buildCommand: `pnpm build`,
dependencies: {
'@hashicorp/platform-util': '0.2.0',
'@types/react': 'latest',
'@types/react': '^18.2.0',
jest: '27.4.7',
},
})
......
......@@ -13,7 +13,7 @@ createNextDescribe(
},
dependencies: {
typescript: 'latest',
'@types/react': 'latest',
'@types/react': '^18.2.0',
'@types/node': 'latest',
pkg: './pkg',
},
......
......@@ -13,8 +13,8 @@ describe('TypeScript basic', () => {
'@next/bundle-analyzer': 'canary',
typescript: 'latest',
'@types/node': 'latest',
'@types/react': 'latest',
'@types/react-dom': 'latest',
'@types/react': '^18.2.0',
'@types/react-dom': '^18.2.0',
},
})
})
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment