Unverified Commit 67bc262b authored by Tobias Koppers's avatar Tobias Koppers Committed by GitHub

Revert "Revert "feat(turbopack): support next.js specific node polyfills"" (#55392)

Reverts vercel/next.js#55385

Closes WEB-1565
parent 42ad2cef
......@@ -661,6 +661,12 @@ pub async fn insert_next_shared_aliases(
import_map.insert_singleton_alias("react", project_path);
import_map.insert_singleton_alias("react-dom", project_path);
//https://github.com/vercel/next.js/blob/f94d4f93e4802f951063cfa3351dd5a2325724b3/packages/next/src/build/webpack-config.ts#L1196
import_map.insert_exact_alias(
"setimmediate",
request_to_import_mapping(project_path, "next/dist/compiled/setimmediate"),
);
insert_turbopack_dev_alias(import_map);
insert_package_alias(
import_map,
......
'use client'
export default function Component() {
return (
<div id="client">
{Buffer.from('Hello Client Component', 'utf-8').toString()}
</div>
)
}
import Component from './client'
export default function Page() {
return (
<div id="server">
{Buffer.from('Hello Server Component', 'utf-8').toString()}
<Component />
</div>
)
}
export default function RootLayout({ children }: { children: any }) {
return (
<html>
<body>{children}</body>
</html>
)
}
import { useRef } from 'react'
import { Harness, useTestHarness } from '@turbo/pack-test-harness'
export default function Page() {
const pageIframeRef = useRef<HTMLIFrameElement | null>(null)
const appIframeRef = useRef<HTMLIFrameElement | null>(null)
useTestHarness((mod) =>
runTests(mod, pageIframeRef.current!, appIframeRef.current)
)
return (
<>
<iframe
style={{ width: 800, height: 600 }}
src="/app"
ref={appIframeRef}
/>
<iframe
style={{ width: 800, height: 600 }}
src="/page"
ref={pageIframeRef}
/>
</>
)
}
function runTests(
harness: Harness,
page: HTMLIFrameElement,
app: HTMLIFrameElement
) {
const TIMEOUT = 30000
it(
'should support Buffer on pages',
async () => {
await harness.waitForLoaded(page)
const server = await harness.waitForSelector(page, '#server')
expect(server.innerHTML).toContain('Hello Server Page')
const client = await harness.waitForSelector(page, '#client')
expect(client.innerHTML).toContain('Hello Client Page')
},
TIMEOUT
)
it(
'should support Buffer on app',
async () => {
await harness.waitForLoaded(app)
const server = await harness.waitForSelector(app, '#server')
expect(server.innerHTML).toContain('Hello Server Component')
const client = await harness.waitForSelector(app, '#client')
expect(client.innerHTML).toContain('Hello Client Component')
},
TIMEOUT
)
}
import { useEffect, useState } from 'react'
export default function Page() {
const [state, setState] = useState('SSR')
useEffect(() => {
setState(
<div id="client">
{Buffer.from('Hello Client Page', 'utf-8').toString()}
</div>
)
}, [setState])
return (
<div>
<div id="server">
{Buffer.from('Hello Server Page', 'utf-8').toString()}
</div>
{state}
</div>
)
}
warning - [parse] [project]/packages/next/dist/server/lib/node-fs-methods.js /packages/next/dist/server/lib/node-fs-methods.js:18:19 lint TP1004 fs.readFile(???*0*) is very dynamic
14 | default: obj
15 | };
16 | }
17 | const nodeFs = {
+ v
18 + readFile: (f)=>_fs.default.promises.readFile(f),
+ ^
19 | readFileSync: (f)=>_fs.default.readFileSync(f),
20 | writeFile: (f, d)=>_fs.default.promises.writeFile(f, d),
21 | mkdir: (dir)=>_fs.default.promises.mkdir(dir, {
22 | recursive: true
- *0* f
⚠️ pattern without value
\ No newline at end of file
warning - [parse] [project]/packages/next/dist/server/lib/node-fs-methods.js /packages/next/dist/server/lib/node-fs-methods.js:18:19 lint TP1004 fs.readFile(???*0*) is very dynamic
14 | default: obj
15 | };
16 | }
17 | const nodeFs = {
+ v
18 + readFile: (f)=>_fs.default.promises.readFile(f),
+ ^
19 | readFileSync: (f)=>_fs.default.readFileSync(f),
20 | writeFile: (f, d)=>_fs.default.promises.writeFile(f, d),
21 | mkdir: (dir)=>_fs.default.promises.mkdir(dir, {
22 | recursive: true
- *0* f
⚠️ pattern without value
\ No newline at end of file
warning - [parse] [project]/packages/next/dist/server/lib/node-fs-methods.js /packages/next/dist/server/lib/node-fs-methods.js:19:23 lint TP1004 fs.readFileSync(???*0*) is very dynamic
15 | };
16 | }
17 | const nodeFs = {
18 | readFile: (f)=>_fs.default.promises.readFile(f),
+ v
19 + readFileSync: (f)=>_fs.default.readFileSync(f),
+ ^
20 | writeFile: (f, d)=>_fs.default.promises.writeFile(f, d),
21 | mkdir: (dir)=>_fs.default.promises.mkdir(dir, {
22 | recursive: true
23 | }),
- *0* f
⚠️ pattern without value
\ No newline at end of file
warning - [parse] [project]/packages/next/dist/server/lib/node-fs-methods.js /packages/next/dist/server/lib/node-fs-methods.js:19:23 lint TP1004 fs.readFileSync(???*0*) is very dynamic
15 | };
16 | }
17 | const nodeFs = {
18 | readFile: (f)=>_fs.default.promises.readFile(f),
+ v
19 + readFileSync: (f)=>_fs.default.readFileSync(f),
+ ^
20 | writeFile: (f, d)=>_fs.default.promises.writeFile(f, d),
21 | mkdir: (dir)=>_fs.default.promises.mkdir(dir, {
22 | recursive: true
23 | }),
- *0* f
⚠️ pattern without value
\ No newline at end of file
warning - [parse] [project]/packages/next/dist/server/lib/node-fs-methods.js /packages/next/dist/server/lib/node-fs-methods.js:24:15 lint TP1004 fs.stat(???*0*) is very dynamic
20 | writeFile: (f, d)=>_fs.default.promises.writeFile(f, d),
21 | mkdir: (dir)=>_fs.default.promises.mkdir(dir, {
22 | recursive: true
23 | }),
+ v
24 + stat: (f)=>_fs.default.promises.stat(f)
+ ^
25 | };
26 |
27 | //# sourceMappingURL=node-fs-methods.js.map
- *0* f
⚠️ pattern without value
\ No newline at end of file
warning - [parse] [project]/packages/next/dist/server/lib/node-fs-methods.js /packages/next/dist/server/lib/node-fs-methods.js:24:15 lint TP1004 fs.stat(???*0*) is very dynamic
20 | writeFile: (f, d)=>_fs.default.promises.writeFile(f, d),
21 | mkdir: (dir)=>_fs.default.promises.mkdir(dir, {
22 | recursive: true
23 | }),
+ v
24 + stat: (f)=>_fs.default.promises.stat(f)
+ ^
25 | };
26 |
27 | //# sourceMappingURL=node-fs-methods.js.map
- *0* f
⚠️ pattern without value
\ No newline at end of file
export const metadata = {
title: 'Next.js',
description: 'Generated by Next.js',
}
export default function RootLayout({ children }) {
return (
<html lang="en">
<body>{children}</body>
</html>
)
}
......@@ -11,6 +11,7 @@ const enabledTests = [
'test/development/basic/emotion-swc.test.ts',
'test/development/basic/legacy-decorators.test.ts',
'test/development/basic/misc.test.ts',
'test/development/basic/node-builtins.test.ts',
'test/development/basic/next-rs-api.test.ts',
'test/development/basic/tailwind-jit.test.ts',
'test/development/basic/theme-ui.test.ts',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment