Unverified Commit 69ded21f authored by Luke Sandberg's avatar Luke Sandberg Committed by GitHub

[turbopack] Remove turbo_tasks::value attribute from NativeFunction

 (#80170)

## Remove `turbo_tasks::value` attribute from `NativeFunction`

This PR removes the `#[turbo_tasks::value]` attribute from the `NativeFunction` struct in the Turbo Tasks crate.

It seemed a little too meta that this might get stored in a cell or produced by a task.
parent 5736391c
...@@ -6,7 +6,7 @@ use serde::{Deserialize, Serialize}; ...@@ -6,7 +6,7 @@ use serde::{Deserialize, Serialize};
use tracing::Span; use tracing::Span;
use crate::{ use crate::{
self as turbo_tasks, RawVc, TaskInput, TaskPersistence, RawVc, TaskInput, TaskPersistence,
magic_any::{MagicAny, MagicAnyDeserializeSeed, MagicAnySerializeSeed}, magic_any::{MagicAny, MagicAnyDeserializeSeed, MagicAnySerializeSeed},
registry::register_function, registry::register_function,
task::{ task::{
...@@ -148,20 +148,16 @@ pub struct FunctionMeta { ...@@ -148,20 +148,16 @@ pub struct FunctionMeta {
/// A native (rust) turbo-tasks function. It's used internally by /// A native (rust) turbo-tasks function. It's used internally by
/// `#[turbo_tasks::function]`. /// `#[turbo_tasks::function]`.
#[turbo_tasks::value(cell = "new", serialization = "none", eq = "manual")]
pub struct NativeFunction { pub struct NativeFunction {
/// A readable name of the function that is used to reporting purposes. /// A readable name of the function that is used to reporting purposes.
pub name: String, pub name: String,
#[turbo_tasks(trace_ignore)]
pub function_meta: FunctionMeta, pub function_meta: FunctionMeta,
#[turbo_tasks(debug_ignore, trace_ignore)]
pub arg_meta: ArgMeta, pub arg_meta: ArgMeta,
/// The functor that creates a functor from inputs. The inner functor /// The functor that creates a functor from inputs. The inner functor
/// handles the task execution. /// handles the task execution.
#[turbo_tasks(debug_ignore, trace_ignore)]
pub implementation: Box<dyn TaskFn + Send + Sync + 'static>, pub implementation: Box<dyn TaskFn + Send + Sync + 'static>,
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment