Unverified Commit 69f8024a authored by okmttdhr, okp's avatar okmttdhr, okp Committed by GitHub

Call Error.getInitialProps for the top level error (#21240)

* fix: Call Error.getInitialProps to pass `err`

* test: Call Error.getInitialPropsfoe the top level error

* test: Update build output limit

* test: Add tests for top level error

* Revert "test: Call Error.getInitialPropsfoe the top level error"

This reverts commit 81fa0c38c704ae6feb79a65eba316362bbebc939.

* test: Fix failing test
parent 708688dd
......@@ -521,7 +521,7 @@ function renderError(renderErrorProps: RenderErrorProps): Promise<any> {
},
}
return Promise.resolve(
renderErrorProps.props
renderErrorProps.props?.err
? renderErrorProps.props
: loadGetInitialProps(App, appCtx)
).then((initProps) =>
......
const Error = ({ message }) => {
return <p id="error-p">Error Rendered with: {message}</p>
}
Error.getInitialProps = ({ err }) => {
return {
message: err && err.message,
}
}
export default Error
if (typeof window !== 'undefined') {
throw new Error('top level error')
}
const Page = () => 'page'
export default Page
/* eslint-env jest */
import { nextBuild, nextServer, startApp, stopApp } from 'next-test-utils'
import webdriver from 'next-webdriver'
import { join } from 'path'
jest.setTimeout(1000 * 60 * 2)
let appPort
let app
let server
describe('Top Level Error', () => {
beforeAll(async () => {
const appDir = join(__dirname, '../')
await nextBuild(appDir)
app = nextServer({
dir: appDir,
dev: false,
quiet: true,
})
server = await startApp(app)
appPort = server.address().port
})
afterAll(() => stopApp(server))
it('should render error page with getInitialProps', async () => {
const browser = await webdriver(appPort, '/')
try {
const text = await browser.waitForElementByCss('#error-p').text()
expect(text).toBe('Error Rendered with: top level error')
} finally {
await browser.close()
}
})
})
const Error = () => {
return <p id="error-p">Error Rendered</p>
}
export default Error
if (typeof window !== 'undefined') {
throw new Error('top level error')
}
const Page = () => 'page'
export default Page
/* eslint-env jest */
import { nextBuild, nextServer, startApp, stopApp } from 'next-test-utils'
import webdriver from 'next-webdriver'
import { join } from 'path'
jest.setTimeout(1000 * 60 * 2)
let appPort
let app
let server
describe('Top Level Error', () => {
beforeAll(async () => {
const appDir = join(__dirname, '../')
await nextBuild(appDir)
app = nextServer({
dir: appDir,
dev: false,
quiet: true,
})
server = await startApp(app)
appPort = server.address().port
})
afterAll(() => stopApp(server))
it('should render error page', async () => {
const browser = await webdriver(appPort, '/')
try {
const text = await browser.waitForElementByCss('#error-p').text()
expect(text).toBe('Error Rendered')
} finally {
await browser.close()
}
})
})
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment