Unverified Commit 6ba8c3c1 authored by Sam Selikoff's avatar Sam Selikoff Committed by GitHub

Navigation inspector UI updates (#94959)

Updates the Navigation Inspector panel UI to match the new
shell-inspection design.

- Reworks the idle, waiting, static shell, and client shell states
around the new “Pause on navigations” toggle
- Adds full-width waiting/debugger banners, updated copy, URL labels,
and the `Resume` action
- Simplifies the panel expansion animation so only the panel
opens/closes, without fading the inner content

To try it out, run

```
pnpm next dev test/development/app-dir/instant-navs-devtools
```


https://github.com/user-attachments/assets/271d788e-87b9-4787-8d31-8008b9e693c0

---------
Co-authored-by: 's avatarvercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
parent f965c004
...@@ -31,4 +31,7 @@ ...@@ -31,4 +31,7 @@
.draggable-content { .draggable-content {
flex: 1; flex: 1;
overflow: auto; overflow: auto;
border-radius: inherit;
border-top-left-radius: 0;
border-top-right-radius: 0;
} }
...@@ -46,16 +46,14 @@ describe('instant-nav-panel', () => { ...@@ -46,16 +46,14 @@ describe('instant-nav-panel', () => {
} }
async function clickStartCapturing(browser: Playwright) { async function clickStartCapturing(browser: Playwright) {
await browser await browser.locator('#instant-nav-pause-toggle').click()
.locator('.instant-nav-capture-button', { hasText: 'Start Capturing' })
.click()
await waitForInstantModeCookie(browser) await waitForInstantModeCookie(browser)
} }
async function clickContinueRendering(browser: Playwright) { async function clickResume(browser: Playwright) {
await browser await browser
.locator('.instant-nav-capture-button', { .locator('.instant-nav-debugger-paused-button', {
hasText: 'Continue Rendering', hasText: 'Resume',
}) })
.click() .click()
} }
...@@ -204,38 +202,40 @@ describe('instant-nav-panel', () => { ...@@ -204,38 +202,40 @@ describe('instant-nav-panel', () => {
async function expectIdlePanel(browser: Playwright) { async function expectIdlePanel(browser: Playwright) {
await expectInstantNavPanelText( await expectInstantNavPanelText(
browser, browser,
'Inspect the UI', 'Pause on navigations',
'Start Capturing', 'When enabled, every navigation will pause so you can inspect the loading shell before resuming.'
'Continue Rendering'
) )
} }
async function expectPendingPanel(browser: Playwright) { async function expectPendingPanel(browser: Playwright) {
await expectInstantNavPanelText( await expectInstantNavPanelText(
browser, browser,
'Awaiting navigation', 'Waiting for navigation',
'Stop Capturing', 'Click any link or refresh the page to inspect the shell.',
'Continue Rendering' 'Pause on navigations'
) )
} }
async function expectMpaPanel(browser: Playwright) { async function expectMpaPanel(browser: Playwright) {
await expectInstantNavPanelText( await expectInstantNavPanelText(
browser, browser,
'Page load', 'Debugger paused',
'prerendered UI', 'Resume',
'Stop Capturing', 'Loading shell',
'Continue Rendering' "You're viewing the shell for this page's initial load.",
'TARGET'
) )
} }
async function expectSpaPanel(browser: Playwright) { async function expectSpaPanel(browser: Playwright) {
await expectInstantNavPanelText( await expectInstantNavPanelText(
browser, browser,
'Navigation', 'Debugger paused',
'prefetched UI', 'Resume',
'Stop Capturing', 'Loading shell',
'Continue Rendering' "You're viewing the shell for the current navigation.",
'SOURCE',
'TARGET'
) )
} }
...@@ -351,9 +351,10 @@ describe('instant-nav-panel', () => { ...@@ -351,9 +351,10 @@ describe('instant-nav-panel', () => {
// Panel should show the idle helper copy and capture controls. // Panel should show the idle helper copy and capture controls.
await retry(async () => { await retry(async () => {
const text = await getInstantNavPanelText(browser) const text = await getInstantNavPanelText(browser)
expect(text).toContain('Inspect the UI') expect(text).toContain('Pause on navigations')
expect(text).toContain('Start Capturing') expect(text).toContain(
expect(text).toContain('Continue Rendering') 'When enabled, every navigation will pause so you can inspect the loading shell before resuming.'
)
}) })
// Cookie should NOT be set yet (only set when user starts capturing) // Cookie should NOT be set yet (only set when user starts capturing)
...@@ -437,8 +438,10 @@ describe('instant-nav-panel', () => { ...@@ -437,8 +438,10 @@ describe('instant-nav-panel', () => {
await retry(async () => { await retry(async () => {
await getInstantNavPanel(browser) await getInstantNavPanel(browser)
const text = await getInstantNavPanelText(browser) const text = await getInstantNavPanelText(browser)
expect(text).toContain('Page load') expect(text).toContain('Loading shell')
expect(text).toContain('prerendered UI') expect(text).toContain(
"You're viewing the shell for this page's initial load."
)
}) })
// Clean up // Clean up
...@@ -504,7 +507,7 @@ describe('instant-nav-panel', () => { ...@@ -504,7 +507,7 @@ describe('instant-nav-panel', () => {
).toBe(0) ).toBe(0)
}) })
it('should restart capture and return to awaiting navigation after Continue Rendering from MPA state', async () => { it('should restart capture and return to awaiting navigation after resuming from MPA state', async () => {
const browser = await next.browser('/target-page/my-post?search=foo') const browser = await next.browser('/target-page/my-post?search=foo')
await clearInstantModeCookie(browser) await clearInstantModeCookie(browser)
...@@ -516,7 +519,7 @@ describe('instant-nav-panel', () => { ...@@ -516,7 +519,7 @@ describe('instant-nav-panel', () => {
await expectTargetPageMpaShell(browser) await expectTargetPageMpaShell(browser)
await waitForAppHydration(browser) await waitForAppHydration(browser)
await clickContinueRendering(browser) await clickResume(browser)
await expectPendingPanel(browser) await expectPendingPanel(browser)
await expectTargetPageRendered(browser) await expectTargetPageRendered(browser)
await waitForInstantModeCookie(browser) await waitForInstantModeCookie(browser)
...@@ -538,9 +541,11 @@ describe('instant-nav-panel', () => { ...@@ -538,9 +541,11 @@ describe('instant-nav-panel', () => {
// Panel should show the awaiting navigation state // Panel should show the awaiting navigation state
await retry(async () => { await retry(async () => {
const text = await getInstantNavPanelText(browser) const text = await getInstantNavPanelText(browser)
expect(text).toContain('Awaiting navigation') expect(text).toContain('Waiting for navigation')
expect(text).toContain('Stop Capturing') expect(text).toContain(
expect(text).toContain('Continue Rendering') 'Click any link or refresh the page to inspect the shell.'
)
expect(text).toContain('Pause on navigations')
}) })
// Navigate to target page via SPA (use eval to bypass overlay pointer interception) // Navigate to target page via SPA (use eval to bypass overlay pointer interception)
...@@ -622,7 +627,7 @@ describe('instant-nav-panel', () => { ...@@ -622,7 +627,7 @@ describe('instant-nav-panel', () => {
await expectTargetPageSpaShellWithRuntimeData(browser) await expectTargetPageSpaShellWithRuntimeData(browser)
}) })
it('should restart capture and return to awaiting navigation after Continue Rendering from SPA state', async () => { it('should restart capture and return to awaiting navigation after resuming from SPA state', async () => {
const browser = await openHomeWithTargetPageWarmup() const browser = await openHomeWithTargetPageWarmup()
await openInstantNavPanel(browser) await openInstantNavPanel(browser)
...@@ -630,13 +635,13 @@ describe('instant-nav-panel', () => { ...@@ -630,13 +635,13 @@ describe('instant-nav-panel', () => {
await clickLink(browser, '/target-page/my-post?search=foo') await clickLink(browser, '/target-page/my-post?search=foo')
await expectSpaPanel(browser) await expectSpaPanel(browser)
await clickContinueRendering(browser) await clickResume(browser)
await expectPendingPanel(browser) await expectPendingPanel(browser)
await expectTargetPageRendered(browser) await expectTargetPageRendered(browser)
await waitForInstantModeCookie(browser) await waitForInstantModeCookie(browser)
}) })
it('should continue rendering a captured await connection navigation with loading.tsx', async () => { it('should resume rendering a captured await connection navigation with loading.tsx', async () => {
const browser = await openHomeWithTargetPageWarmup() const browser = await openHomeWithTargetPageWarmup()
await openInstantNavPanel(browser) await openInstantNavPanel(browser)
...@@ -645,7 +650,7 @@ describe('instant-nav-panel', () => { ...@@ -645,7 +650,7 @@ describe('instant-nav-panel', () => {
await expectSpaPanel(browser) await expectSpaPanel(browser)
await expectAwaitConnectionPageLoading(browser) await expectAwaitConnectionPageLoading(browser)
await clickContinueRendering(browser) await clickResume(browser)
await expectPendingPanel(browser) await expectPendingPanel(browser)
await expectTargetPageRendered(browser) await expectTargetPageRendered(browser)
await waitForInstantModeCookie(browser) await waitForInstantModeCookie(browser)
...@@ -691,7 +696,7 @@ describe('instant-nav-panel', () => { ...@@ -691,7 +696,7 @@ describe('instant-nav-panel', () => {
const initialPanelText = await getInstantNavPanelText(browser) const initialPanelText = await getInstantNavPanelText(browser)
expect(initialPanelText).toContain('Page load') expect(initialPanelText).toContain('Page load')
expect(initialPanelText).not.toContain('Navigation') expect(initialPanelText).not.toContain('Client nav')
await expectMpaPanel(browser) await expectMpaPanel(browser)
await expectTargetPageMpaShell(browser) await expectTargetPageMpaShell(browser)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment