Unverified Commit 6c3560db authored by Grace Yun's avatar Grace Yun Committed by GitHub

[create-next-app] fix template css for top / bottom alignment (#53227)

Fixes a small CSS regression with the `create-next-app` template(s). Especially evident with templates using Tailwind CSS.

Before:
<img width="1047" alt="image" src="https://github.com/vercel/next.js/assets/74513600/9d3e8ef4-52b9-4590-be26-ee91f4bd65dd">

After:
![image](https://github.com/vercel/next.js/assets/74513600/952ca166-59df-40d1-bb6d-cb2fbc592c3b)
parent f814fb80
...@@ -3,7 +3,7 @@ import Image from 'next/image' ...@@ -3,7 +3,7 @@ import Image from 'next/image'
export default function Home() { export default function Home() {
return ( return (
<main className="flex min-h-screen flex-col items-center justify-between p-24"> <main className="flex min-h-screen flex-col items-center justify-between p-24">
<div className="z-10 w-full max-w-5xl items-center justify-between font-mono text-sm lg:flex"> <div className="z-10 max-w-5xl w-full items-center justify-between font-mono text-sm lg:flex">
<p className="fixed left-0 top-0 flex w-full justify-center border-b border-gray-300 bg-gradient-to-b from-zinc-200 pb-6 pt-8 backdrop-blur-2xl dark:border-neutral-800 dark:bg-zinc-800/30 dark:from-inherit lg:static lg:w-auto lg:rounded-xl lg:border lg:bg-gray-200 lg:p-4 lg:dark:bg-zinc-800/30"> <p className="fixed left-0 top-0 flex w-full justify-center border-b border-gray-300 bg-gradient-to-b from-zinc-200 pb-6 pt-8 backdrop-blur-2xl dark:border-neutral-800 dark:bg-zinc-800/30 dark:from-inherit lg:static lg:w-auto lg:rounded-xl lg:border lg:bg-gray-200 lg:p-4 lg:dark:bg-zinc-800/30">
Get started by editing&nbsp; Get started by editing&nbsp;
<code className="font-mono font-bold">app/page.js</code> <code className="font-mono font-bold">app/page.js</code>
...@@ -39,7 +39,7 @@ export default function Home() { ...@@ -39,7 +39,7 @@ export default function Home() {
/> />
</div> </div>
<div className="mb-32 grid text-center lg:mb-0 lg:grid-cols-4 lg:text-left"> <div className="mb-32 grid text-center lg:max-w-5xl lg:w-full lg:mb-0 lg:grid-cols-4 lg:text-left">
<a <a
href="https://nextjs.org/docs?utm_source=create-next-app&utm_medium=appdir-template&utm_campaign=create-next-app" href="https://nextjs.org/docs?utm_source=create-next-app&utm_medium=appdir-template&utm_campaign=create-next-app"
className="group rounded-lg border border-transparent px-5 py-4 transition-colors hover:border-gray-300 hover:bg-gray-100 hover:dark:border-neutral-700 hover:dark:bg-neutral-800/30" className="group rounded-lg border border-transparent px-5 py-4 transition-colors hover:border-gray-300 hover:bg-gray-100 hover:dark:border-neutral-700 hover:dark:bg-neutral-800/30"
......
...@@ -3,7 +3,7 @@ import Image from 'next/image' ...@@ -3,7 +3,7 @@ import Image from 'next/image'
export default function Home() { export default function Home() {
return ( return (
<main className="flex min-h-screen flex-col items-center justify-between p-24"> <main className="flex min-h-screen flex-col items-center justify-between p-24">
<div className="z-10 w-full max-w-5xl items-center justify-between font-mono text-sm lg:flex"> <div className="z-10 max-w-5xl w-full items-center justify-between font-mono text-sm lg:flex">
<p className="fixed left-0 top-0 flex w-full justify-center border-b border-gray-300 bg-gradient-to-b from-zinc-200 pb-6 pt-8 backdrop-blur-2xl dark:border-neutral-800 dark:bg-zinc-800/30 dark:from-inherit lg:static lg:w-auto lg:rounded-xl lg:border lg:bg-gray-200 lg:p-4 lg:dark:bg-zinc-800/30"> <p className="fixed left-0 top-0 flex w-full justify-center border-b border-gray-300 bg-gradient-to-b from-zinc-200 pb-6 pt-8 backdrop-blur-2xl dark:border-neutral-800 dark:bg-zinc-800/30 dark:from-inherit lg:static lg:w-auto lg:rounded-xl lg:border lg:bg-gray-200 lg:p-4 lg:dark:bg-zinc-800/30">
Get started by editing&nbsp; Get started by editing&nbsp;
<code className="font-mono font-bold">app/page.tsx</code> <code className="font-mono font-bold">app/page.tsx</code>
...@@ -39,7 +39,7 @@ export default function Home() { ...@@ -39,7 +39,7 @@ export default function Home() {
/> />
</div> </div>
<div className="mb-32 grid text-center lg:mb-0 lg:grid-cols-4 lg:text-left"> <div className="mb-32 grid text-center lg:max-w-5xl lg:w-full lg:mb-0 lg:grid-cols-4 lg:text-left">
<a <a
href="https://nextjs.org/docs?utm_source=create-next-app&utm_medium=appdir-template&utm_campaign=create-next-app" href="https://nextjs.org/docs?utm_source=create-next-app&utm_medium=appdir-template&utm_campaign=create-next-app"
className="group rounded-lg border border-transparent px-5 py-4 transition-colors hover:border-gray-300 hover:bg-gray-100 hover:dark:border-neutral-700 hover:dark:bg-neutral-800/30" className="group rounded-lg border border-transparent px-5 py-4 transition-colors hover:border-gray-300 hover:bg-gray-100 hover:dark:border-neutral-700 hover:dark:bg-neutral-800/30"
......
...@@ -42,8 +42,8 @@ ...@@ -42,8 +42,8 @@
.grid { .grid {
display: grid; display: grid;
grid-template-columns: repeat(4, minmax(25%, auto)); grid-template-columns: repeat(4, minmax(25%, auto));
width: var(--max-width);
max-width: 100%; max-width: 100%;
width: var(--max-width);
} }
.card { .card {
......
...@@ -42,8 +42,8 @@ ...@@ -42,8 +42,8 @@
.grid { .grid {
display: grid; display: grid;
grid-template-columns: repeat(4, minmax(25%, auto)); grid-template-columns: repeat(4, minmax(25%, auto));
width: var(--max-width);
max-width: 100%; max-width: 100%;
width: var(--max-width);
} }
.card { .card {
......
...@@ -8,7 +8,7 @@ export default function Home() { ...@@ -8,7 +8,7 @@ export default function Home() {
<main <main
className={`flex min-h-screen flex-col items-center justify-between p-24 ${inter.className}`} className={`flex min-h-screen flex-col items-center justify-between p-24 ${inter.className}`}
> >
<div className="z-10 w-full max-w-5xl items-center justify-between font-mono text-sm lg:flex"> <div className="z-10 max-w-5xl w-full items-center justify-between font-mono text-sm lg:flex">
<p className="fixed left-0 top-0 flex w-full justify-center border-b border-gray-300 bg-gradient-to-b from-zinc-200 pb-6 pt-8 backdrop-blur-2xl dark:border-neutral-800 dark:bg-zinc-800/30 dark:from-inherit lg:static lg:w-auto lg:rounded-xl lg:border lg:bg-gray-200 lg:p-4 lg:dark:bg-zinc-800/30"> <p className="fixed left-0 top-0 flex w-full justify-center border-b border-gray-300 bg-gradient-to-b from-zinc-200 pb-6 pt-8 backdrop-blur-2xl dark:border-neutral-800 dark:bg-zinc-800/30 dark:from-inherit lg:static lg:w-auto lg:rounded-xl lg:border lg:bg-gray-200 lg:p-4 lg:dark:bg-zinc-800/30">
Get started by editing&nbsp; Get started by editing&nbsp;
<code className="font-mono font-bold">pages/index.js</code> <code className="font-mono font-bold">pages/index.js</code>
...@@ -44,7 +44,7 @@ export default function Home() { ...@@ -44,7 +44,7 @@ export default function Home() {
/> />
</div> </div>
<div className="mb-32 grid text-center lg:mb-0 lg:grid-cols-4 lg:text-left"> <div className="mb-32 grid text-center lg:max-w-5xl lg:w-full lg:mb-0 lg:grid-cols-4 lg:text-left">
<a <a
href="https://nextjs.org/docs?utm_source=create-next-app&utm_medium=default-template-tw&utm_campaign=create-next-app" href="https://nextjs.org/docs?utm_source=create-next-app&utm_medium=default-template-tw&utm_campaign=create-next-app"
className="group rounded-lg border border-transparent px-5 py-4 transition-colors hover:border-gray-300 hover:bg-gray-100 hover:dark:border-neutral-700 hover:dark:bg-neutral-800/30" className="group rounded-lg border border-transparent px-5 py-4 transition-colors hover:border-gray-300 hover:bg-gray-100 hover:dark:border-neutral-700 hover:dark:bg-neutral-800/30"
......
...@@ -8,7 +8,7 @@ export default function Home() { ...@@ -8,7 +8,7 @@ export default function Home() {
<main <main
className={`flex min-h-screen flex-col items-center justify-between p-24 ${inter.className}`} className={`flex min-h-screen flex-col items-center justify-between p-24 ${inter.className}`}
> >
<div className="z-10 w-full max-w-5xl items-center justify-between font-mono text-sm lg:flex"> <div className="z-10 max-w-5xl w-full items-center justify-between font-mono text-sm lg:flex">
<p className="fixed left-0 top-0 flex w-full justify-center border-b border-gray-300 bg-gradient-to-b from-zinc-200 pb-6 pt-8 backdrop-blur-2xl dark:border-neutral-800 dark:bg-zinc-800/30 dark:from-inherit lg:static lg:w-auto lg:rounded-xl lg:border lg:bg-gray-200 lg:p-4 lg:dark:bg-zinc-800/30"> <p className="fixed left-0 top-0 flex w-full justify-center border-b border-gray-300 bg-gradient-to-b from-zinc-200 pb-6 pt-8 backdrop-blur-2xl dark:border-neutral-800 dark:bg-zinc-800/30 dark:from-inherit lg:static lg:w-auto lg:rounded-xl lg:border lg:bg-gray-200 lg:p-4 lg:dark:bg-zinc-800/30">
Get started by editing&nbsp; Get started by editing&nbsp;
<code className="font-mono font-bold">pages/index.tsx</code> <code className="font-mono font-bold">pages/index.tsx</code>
...@@ -44,7 +44,7 @@ export default function Home() { ...@@ -44,7 +44,7 @@ export default function Home() {
/> />
</div> </div>
<div className="mb-32 grid text-center lg:mb-0 lg:grid-cols-4 lg:text-left"> <div className="mb-32 grid text-center lg:max-w-5xl lg:w-full lg:mb-0 lg:grid-cols-4 lg:text-left">
<a <a
href="https://nextjs.org/docs?utm_source=create-next-app&utm_medium=default-template-tw&utm_campaign=create-next-app" href="https://nextjs.org/docs?utm_source=create-next-app&utm_medium=default-template-tw&utm_campaign=create-next-app"
className="group rounded-lg border border-transparent px-5 py-4 transition-colors hover:border-gray-300 hover:bg-gray-100 hover:dark:border-neutral-700 hover:dark:bg-neutral-800/30" className="group rounded-lg border border-transparent px-5 py-4 transition-colors hover:border-gray-300 hover:bg-gray-100 hover:dark:border-neutral-700 hover:dark:bg-neutral-800/30"
......
...@@ -42,8 +42,8 @@ ...@@ -42,8 +42,8 @@
.grid { .grid {
display: grid; display: grid;
grid-template-columns: repeat(4, minmax(25%, auto)); grid-template-columns: repeat(4, minmax(25%, auto));
width: var(--max-width); max-width: var(--max-width);
max-width: 100%; width: 100%;
} }
.card { .card {
......
...@@ -42,8 +42,8 @@ ...@@ -42,8 +42,8 @@
.grid { .grid {
display: grid; display: grid;
grid-template-columns: repeat(4, minmax(25%, auto)); grid-template-columns: repeat(4, minmax(25%, auto));
width: var(--max-width);
max-width: 100%; max-width: 100%;
width: var(--max-width);
} }
.card { .card {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment