Unverified Commit 6dfe02d2 authored by zhoulixiang's avatar zhoulixiang Committed by GitHub

Optimize offline condition judgment (#33238)

* perf: optimize offline condition judgment

* lint-fix
Co-authored-by: 's avatarJJ Kasper <jj@jjsweb.site>
parent 04ca8dbf
...@@ -69,16 +69,13 @@ export function install( ...@@ -69,16 +69,13 @@ export function install(
* install`. * install`.
*/ */
args = ['install'] args = ['install']
if (useYarn) { if (!isOnline) {
if (!isOnline) { console.log(chalk.yellow('You appear to be offline.'))
console.log(chalk.yellow('You appear to be offline.')) if (useYarn) {
console.log(chalk.yellow('Falling back to the local Yarn cache.')) console.log(chalk.yellow('Falling back to the local Yarn cache.'))
console.log() console.log()
args.push('--offline') args.push('--offline')
} } else {
} else {
if (!isOnline) {
console.log(chalk.yellow('You appear to be offline.'))
console.log() console.log()
} }
} }
......
...@@ -69,16 +69,13 @@ export function install( ...@@ -69,16 +69,13 @@ export function install(
* install`. * install`.
*/ */
args = ['install'] args = ['install']
if (useYarn) { if (!isOnline) {
if (!isOnline) { console.log(chalk.yellow('You appear to be offline.'))
console.log(chalk.yellow('You appear to be offline.')) if (useYarn) {
console.log(chalk.yellow('Falling back to the local Yarn cache.')) console.log(chalk.yellow('Falling back to the local Yarn cache.'))
console.log() console.log()
args.push('--offline') args.push('--offline')
} } else {
} else {
if (!isOnline) {
console.log(chalk.yellow('You appear to be offline.'))
console.log() console.log()
} }
} }
......
...@@ -69,16 +69,13 @@ export function install( ...@@ -69,16 +69,13 @@ export function install(
* install`. * install`.
*/ */
args = ['install'] args = ['install']
if (useYarn) { if (!isOnline) {
if (!isOnline) { console.log(chalk.yellow('You appear to be offline.'))
console.log(chalk.yellow('You appear to be offline.')) if (useYarn) {
console.log(chalk.yellow('Falling back to the local Yarn cache.')) console.log(chalk.yellow('Falling back to the local Yarn cache.'))
console.log() console.log()
args.push('--offline') args.push('--offline')
} } else {
} else {
if (!isOnline) {
console.log(chalk.yellow('You appear to be offline.'))
console.log() console.log()
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment